[
http://issues.apache.org/jira/browse/DERBY-1149?page=comments#action_12372464 ]
David Van Couvering commented on DERBY-1149:
Thanks, Kristian, I'll fix this.
I don't tick off the ASF grant because I don't intend this code to be committed
an
[
http://issues.apache.org/jira/browse/DERBY-1149?page=comments#action_12372394 ]
Kristian Waagan commented on DERBY-1149:
The following part of the patch does not make sense to me:
+if ( ! expectedState.equals(sqle.getSQLState()) )
+
David W. Van Couvering wrote:
Kristian Waagan (JIRA) wrote:
[
http://issues.apache.org/jira/browse/DERBY-1149?page=comments#action_12372240
]
Kristian Waagan commented on DERBY-1149:
This patch will (and does) fail, due to the way SQLStates are
Kristian Waagan (JIRA) wrote:
[ http://issues.apache.org/jira/browse/DERBY-1149?page=comments#action_12372240 ]
Kristian Waagan commented on DERBY-1149:
This patch will (and does) fail, due to the way SQLStates are compared. I will
brush up the pa
[
http://issues.apache.org/jira/browse/DERBY-1149?page=comments#action_12372240 ]
Kristian Waagan commented on DERBY-1149:
This patch will (and does) fail, due to the way SQLStates are compared. I will
brush up the patch, only changing things in Sta
I think you have a good point, and I think that what we can shoot for is
over time targetting having the same canons for embedded and network client.
Of course, if we took the original intent of the 'am' (Abstract Machine)
package and put it on top of both the embedded and network code, then a
David W. Van Couvering wrote:
I am also realizing that we as a community need to decide if we want
to ensure that the network client and the engine should always have
the same SQL States for the same exceptions. It's laudable, and if we
catch differences I think we should fix them, but I am no
David W. Van Couvering wrote:
Hi, Kristian, thanks for your research on this! I didn't know there
was more to be said on what SQL States should be used when. It's a
little daunting -- every time I change a SQL State in the client I have
to peruse this massive tome.
Anyway, I would probably
Thanks, that seems reasonable to me, and is the approach I will follow
unless I hear some good arguments to the contrary.
David
Rick Hillegas wrote:
Hi David,
I agree that this is a good goal. However, I wouldn't say that this is
the most important discrepancy distinguishing our clients. It
Hi David,
I agree that this is a good goal. However, I wouldn't say that this is
the most important discrepancy distinguishing our clients. It seems to
me that client-convergence, including SQLState agreement, is a big
project, requiring a systematic plan. I say, keep closing the gap on an
ad
Hi, Kristian, thanks for your research on this! I didn't know there
was more to be said on what SQL States should be used when. It's a
little daunting -- every time I change a SQL State in the client I have
to peruse this massive tome.
Anyway, I would probably use 25001, which is currently
David W. Van Couvering wrote:
Thanks for catching this, Kristian. As I go through messages on the
client, I try to find a matching message that already exists for the
embedded code. I have not tried to actually look at the "same" code
on the embedded side, as it's really hard to tell what th
I thought I'd change the subject because of something I brought up at
the end of this message. Take a look, I think it's something worth
discovering, and potentially bringing up for a vote.
David
David W. Van Couvering wrote:
Thanks for catching this, Kristian. As I go through messages on th
Thanks for catching this, Kristian. As I go through messages on the
client, I try to find a matching message that already exists for the
embedded code. I have not tried to actually look at the "same" code on
the embedded side, as it's really hard to tell what the "same" code is,
and where it
[
http://issues.apache.org/jira/browse/DERBY-1149?page=comments#action_12371754 ]
Kristian Waagan commented on DERBY-1149:
I need a little help on my issue. The following diff is from r388309:
--- /db/derby/code/trunk/java/client/org/apache/derby/cl
[
http://issues.apache.org/jira/browse/DERBY-1149?page=comments#action_12371720 ]
Kristian Waagan commented on DERBY-1149:
I will look into this, and fix the test by either adjusting the expected
exception message, or compare SQLStates if it has bee
16 matches
Mail list logo
