[jira] Commented: (DERBY-2014) NullPointerException with NULLIF in GROUP BY clause

2006-11-04 Thread Bryan Pendleton (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-2014?page=comments#action_12447153 ] Bryan Pendleton commented on DERBY-2014: I'm ready to commit this, but I wanted to confirm the Javadoc change and am having trouble running 'ant derbydocs'

[jira] Commented: (DERBY-2014) NullPointerException with NULLIF in GROUP BY clause

2006-11-03 Thread Bryan Pendleton (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-2014?page=comments#action_12447105 ] Bryan Pendleton commented on DERBY-2014: Thanks Yip! The new Javadoc is clear and detailed and very useful. The new JUnit tests are also very clear and eas

Re: [jira] Commented: (DERBY-2014) NullPointerException with NULLIF in GROUP BY clause

2006-10-31 Thread Bernt M. Johnsen
Daniel John Debrunner (JIRA) wrote (2006-10-31 08:01:03): > [ > http://issues.apache.org/jira/browse/DERBY-2014?page=comments#action_12445933 > ] > > Daniel John Debrunner commented on DERBY-2014: > -- > > The behaviour o

[jira] Commented: (DERBY-2014) NullPointerException with NULLIF in GROUP BY clause

2006-10-31 Thread Yip Ng (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-2014?page=comments#action_12445976 ] Yip Ng commented on DERBY-2014: --- Sure, I'll be submitting a follow-up patch - addressing junit testcase conversion + the javadoc issue in ValueNode.isEquivalent. >

[jira] Commented: (DERBY-2014) NullPointerException with NULLIF in GROUP BY clause

2006-10-31 Thread Bryan Pendleton (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-2014?page=comments#action_12445969 ] Bryan Pendleton commented on DERBY-2014: Dan is this the Javadoc you are referring to? http://db.apache.org/derby/javadoc/engine/org/apache/derby/impl/sql/c

[jira] Commented: (DERBY-2014) NullPointerException with NULLIF in GROUP BY clause

2006-10-31 Thread Daniel John Debrunner (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-2014?page=comments#action_12445933 ] Daniel John Debrunner commented on DERBY-2014: -- The behaviour of isEquivalent() is described by the javadoc comments for ValueNode.isEquivalent(). Be

[jira] Commented: (DERBY-2014) NullPointerException with NULLIF in GROUP BY clause

2006-10-31 Thread Yip Ng (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-2014?page=comments#action_12445862 ] Yip Ng commented on DERBY-2014: --- Thanks Manish and Bernt for reviewing the patch. Bernt: Good question. If I am not mistaken, the isEquivalent() method is used

[jira] Commented: (DERBY-2014) NullPointerException with NULLIF in GROUP BY clause

2006-10-31 Thread Bernt M. Johnsen (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-2014?page=comments#action_12445854 ] Bernt M. Johnsen commented on DERBY-2014: - I'm not sure what kind of equivalence isEquivalent, but is the following correct? + // va

[jira] Commented: (DERBY-2014) NullPointerException with NULLIF in GROUP BY clause

2006-10-30 Thread Manish Khettry (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-2014?page=comments#action_12445682 ] Manish Khettry commented on DERBY-2014: --- The change to ConstantNode is fine. Thanks for finding and fixing this. On adding tests for this bug: Would it be be