[jira] Commented: (DERBY-2107) Move page latching out of the lock manager

2007-02-07 Thread Knut Anders Hatlen (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470853 ] Knut Anders Hatlen commented on DERBY-2107: --- Committed 2a with revision 504462. Move page latching out

[jira] Commented: (DERBY-2107) Move page latching out of the lock manager

2007-02-04 Thread Knut Anders Hatlen (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470067 ] Knut Anders Hatlen commented on DERBY-2107: --- I agree that any timeout on the latch wait should be a

[jira] Commented: (DERBY-2107) Move page latching out of the lock manager

2007-02-02 Thread Knut Anders Hatlen (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469712 ] Knut Anders Hatlen commented on DERBY-2107: --- Thanks for reviewing the patch, Suresh! Those are great

[jira] Commented: (DERBY-2107) Move page latching out of the lock manager

2007-02-02 Thread Daniel John Debrunner (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469806 ] Daniel John Debrunner commented on DERBY-2107: -- I agree that any timeout on the latch wait should be a

[jira] Commented: (DERBY-2107) Move page latching out of the lock manager

2007-02-01 Thread Knut Anders Hatlen (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469431 ] Knut Anders Hatlen commented on DERBY-2107: --- If there are no more comments, I plan to commit 1c after the

[jira] Commented: (DERBY-2107) Move page latching out of the lock manager

2007-02-01 Thread Suresh Thalamati (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469575 ] Suresh Thalamati commented on DERBY-2107: - Hi Knut, I reviewed the latest patch, it looks good to be

[jira] Commented: (DERBY-2107) Move page latching out of the lock manager

2007-01-29 Thread Knut Anders Hatlen (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468291 ] Knut Anders Hatlen commented on DERBY-2107: --- Does anyone plan to review the latest version of the patch?

[jira] Commented: (DERBY-2107) Move page latching out of the lock manager

2007-01-18 Thread Knut Anders Hatlen (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465695 ] Knut Anders Hatlen commented on DERBY-2107: --- Attached new patch (1c). The only change from 1b is that the

[jira] Commented: (DERBY-2107) Move page latching out of the lock manager

2006-12-19 Thread Daniel John Debrunner (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-2107?page=comments#action_12459725 ] Daniel John Debrunner commented on DERBY-2107: -- Maybe that's the best approach, leave latching as it is for now, and first work on removing the

[jira] Commented: (DERBY-2107) Move page latching out of the lock manager

2006-12-19 Thread Knut Anders Hatlen (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-2107?page=comments#action_12459846 ] Knut Anders Hatlen commented on DERBY-2107: --- Will do that. I have logged DERBY-2197 to track those changes. Move page latching out of the lock manager

[jira] Commented: (DERBY-2107) Move page latching out of the lock manager

2006-12-15 Thread Knut Anders Hatlen (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-2107?page=comments#action_12458736 ] Knut Anders Hatlen commented on DERBY-2107: --- Thanks for your comments, Dan and Mike. It seems to me that all your comments are about the variants of

Re: [jira] Commented: (DERBY-2107) Move page latching out of the lock manager

2006-12-15 Thread Oystein Grovlen - Sun Norway
Mike Matrigali (JIRA) wrote: The case I am trying to work out in my mind is the space reclamation thread. It gets latches on pages and loops through rows requesting zero duration locks to see if it can purge a row from a page. In the first case the row we are requesting a lock on will never

Re: [jira] Commented: (DERBY-2107) Move page latching out of the lock manager

2006-12-15 Thread Knut Anders Hatlen
Daniel John Debrunner [EMAIL PROTECTED] writes: Knut Anders Hatlen (JIRA) wrote: [ http://issues.apache.org/jira/browse/DERBY-2107?page=comments#action_12458736 ] Knut Anders Hatlen commented on DERBY-2107: --- Thanks for your

[jira] Commented: (DERBY-2107) Move page latching out of the lock manager

2006-12-14 Thread Daniel John Debrunner (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-2107?page=comments#action_12458593 ] Daniel John Debrunner commented on DERBY-2107: -- Even though the parameters have changed for LockingPolicy.lockRecordForRead its description has not,

[jira] Commented: (DERBY-2107) Move page latching out of the lock manager

2006-12-14 Thread Mike Matrigali (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-2107?page=comments#action_12458608 ] Mike Matrigali commented on DERBY-2107: --- I am reviewing the changes, and do agree with Dan's comments. Have you thought about the implecations of order

[jira] Commented: (DERBY-2107) Move page latching out of the lock manager

2006-12-14 Thread Daniel John Debrunner (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-2107?page=comments#action_12458609 ] Daniel John Debrunner commented on DERBY-2107: -- I think the patch has a severe problem, here is code from RowLocking3.lockRecordForRead (one of

[jira] Commented: (DERBY-2107) Move page latching out of the lock manager

2006-12-14 Thread Daniel John Debrunner (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-2107?page=comments#action_12458623 ] Daniel John Debrunner commented on DERBY-2107: -- This is how the page latching currently works in the case when the lock manager releases its latch:

[jira] Commented: (DERBY-2107) Move page latching out of the lock manager

2006-12-14 Thread Daniel John Debrunner (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-2107?page=comments#action_12458628 ] Daniel John Debrunner commented on DERBY-2107: -- I think the patch hit this issue due to some existing confusion with naming in the existing code.

[jira] Commented: (DERBY-2107) Move page latching out of the lock manager

2006-12-08 Thread Knut Anders Hatlen (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-2107?page=comments#action_12456770 ] Knut Anders Hatlen commented on DERBY-2107: --- The first may have been an existing issue: 1) The field nestedLatch is used under synchronization when

Re: [jira] Commented: (DERBY-2107) Move page latching out of the lock manager

2006-12-08 Thread Oystein Grovlen - Sun Norway
Mike Matrigali wrote: I assume changes to remove latching out of lock manage will break existing in progress work to do in memory store - but I don't know for sure. I would not think so since AFAIK that work is just replacing the current io system with memory. Hence, it should still operate

[jira] Commented: (DERBY-2107) Move page latching out of the lock manager

2006-12-08 Thread Daniel John Debrunner (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-2107?page=comments#action_12456903 ] Daniel John Debrunner commented on DERBY-2107: -- Sorry, I was wrong on issue 2), got confused mentally walking through the code. Though the patch does

[jira] Commented: (DERBY-2107) Move page latching out of the lock manager

2006-12-07 Thread Daniel John Debrunner (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-2107?page=comments#action_12456463 ] Daniel John Debrunner commented on DERBY-2107: -- Couple of comments jump out from an initial look at the patch. The first may have been an existing

[jira] Commented: (DERBY-2107) Move page latching out of the lock manager

2006-12-07 Thread Daniel John Debrunner (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-2107?page=comments#action_12456466 ] Daniel John Debrunner commented on DERBY-2107: -- On more, I think there has to be synchronization in isLatched() based upon previous discussions on

Re: [jira] Commented: (DERBY-2107) Move page latching out of the lock manager

2006-12-07 Thread Mike Matrigali
I am ok with moving latching out of the lockmanager, if it really is necessary to get the performance you are looking for. I had hoped that latching would remain a service provided by another module so that if there are multiple store implementation they could share a single latching

A note on the in-memory store (was: Re: [jira] Commented: (DERBY-2107) Move page latching out of the lock manager)

2006-12-07 Thread Kristian Waagan
Mike Matrigali wrote: I am ok with moving latching out of the lockmanager, if it really is necessary to get the performance you are looking for. I had hoped that latching would remain a service provided by another module so that if there are multiple store implementation they could share a