[
https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12526121
]
V.Narayanan commented on DERBY-3064:
The Log shipper will be in charge of shipping the Log Record
chunks from the
[
https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12526154
]
Jørgen Løland commented on DERBY-3064:
--
Thank you for addressing this issue, Narayanan.
I had a look at the pr
[
https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529772
]
V.Narayanan commented on DERBY-3064:
In keeping with the design diagrams introduced in Derby-2872 I have modified
[
https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529808
]
Øystein Grøvlen commented on DERBY-3064:
Thanks for the desgin overview, Narayanan. I have a few questions
a
[
https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529813
]
V.Narayanan commented on DERBY-3064:
>1. If I understand you correctly, log records will be shipped either
> wh
[
https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529815
]
V.Narayanan commented on DERBY-3064:
"I have introduced the time concept to overcome the limitation imposed by
Da
[
https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529834
]
V.Narayanan commented on DERBY-3064:
>If I understand you correctly, this time interval will only be helpful in t
[
https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529838
]
Jørgen Løland commented on DERBY-3064:
--
> Does this mean atleast in the case of log shipper we would be forced t
[
https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529842
]
Øystein Grøvlen commented on DERBY-3064:
V.Narayanan (JIRA) wrote:
> I however do not want to do this in the
[
https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12530385
]
V.Narayanan commented on DERBY-3064:
> Jorgen says
> In the general case, we should use DaemonService whenever po
[
https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12530407
]
Øystein Grøvlen commented on DERBY-3064:
Thanks for the patch, Narayanan. It looks good and is very well
doc
[
https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12530410
]
V.Narayanan commented on DERBY-3064:
Thank you for the comments and the reviews oystein.
>4. Why are exceptions
[
https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12530420
]
Øystein Grøvlen commented on DERBY-3064:
V.Narayanan (JIRA) wrote:
>> 4. Why are exceptions from shipALogChun
[
https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12530434
]
V.Narayanan commented on DERBY-3064:
Thank you for the comments Oystein
>Maybe there is a need for the MasterCon
[
https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12530437
]
Øystein Grøvlen commented on DERBY-3064:
Your plan for handleExceptions sounds good. You need to decide whet
[
https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12530669
]
V.Narayanan commented on DERBY-3064:
I will keep to one method to handle the exceptions for now. I will write the
[
https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12530922
]
V.Narayanan commented on DERBY-3064:
While working on creating the handleExceptions method in
MasterController, I
[
https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12530938
]
Jørgen Løland commented on DERBY-3064:
--
If I understand you correctly, you are asking two questions:
Q1. Shoul
[
https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12531499
]
Øystein Grøvlen commented on DERBY-3064:
Thanks for addressing my comments. I have a few follw-up issues and
[
https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12531728
]
Øystein Grøvlen commented on DERBY-3064:
All looks very good, except that it seems I did not explain what I
m
[
https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532069
]
Knut Anders Hatlen commented on DERBY-3064:
---
I don't quite understand this part of the patch:
+} c
[
https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12535545
]
V.Narayanan commented on DERBY-3064:
While working on the integration of the log shipper into the
MasterControll
[
https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537882
]
Øystein Grøvlen commented on DERBY-3064:
Narayanan, thanks for the patch. Here are my comments and questions
[
https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537889
]
Øystein Grøvlen commented on DERBY-3064:
Some additional minor comments:
7. There is an unused import of Sa
[
https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538504
]
Knut Anders Hatlen commented on DERBY-3064:
---
Do we need try/catch here? (in MasterController.startMaster)
[
https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538513
]
Knut Anders Hatlen commented on DERBY-3064:
---
> I have overcome this by doing
>
> failedChunk = (mesg==null)
[
https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538704
]
Jørgen Løland commented on DERBY-3064:
--
> (snip) And exceptions are automatically logged in accordance with
> d
[
https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538715
]
Knut Anders Hatlen commented on DERBY-3064:
---
Sounds like a good plan, Jørgen. I guess it would be best if t
[
https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12547767
]
Øystein Grøvlen commented on DERBY-3064:
Thanks, for the patch Narayanan. Most of my comments are just
cosme
[
https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548660
]
Øystein Grøvlen commented on DERBY-3064:
Thanks for the new patch Narayanan and for fixing all the minor nits
[
https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549433
]
Øystein Grøvlen commented on DERBY-3064:
I must admit, I do not have deep knowledge about Socket communicatio
[
https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550015
]
V.Narayanan commented on DERBY-3064:
1) when you attempt the first connect
2) when a connection failure occurs
1
[
https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550017
]
V.Narayanan commented on DERBY-3064:
should have started the comment with "we have two cases in consideration her
[
https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550066
]
Øystein Grøvlen commented on DERBY-3064:
Narayanan, I agree with your analysis with respect to connection fai
2. It seems like you suggest that the shipping thread will continously
check to see whether the timeout has expired. Generally, such
busy-waits should be avoided. I think you should introduce a timer
or something so that the thread can be suspended until it is time
to ship log records.
Jørgen Løland (JIRA) wrote:
[ https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529838 ]
Jørgen Løland commented on DERBY-3064:
--
Does this mean atleast in the case of lo
+1
Sounds reasonable to me too.
V.Narayanan (JIRA) wrote:
[ https://issues.apache.org/jira/browse/DERBY-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550015 ]
V.Narayanan commented on DERBY-3064:
1) when you atte
37 matches
Mail list logo