[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12575249#action_12575249
]
Mamta A. Satoor commented on DERBY-3304:
Checked in 628130, 629926 and 631481 into
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12556941#action_12556941
]
Daniel John Debrunner commented on DERBY-3304:
--
I can't reproduce this problem
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12556978#action_12556978
]
Dag H. Wanvik commented on DERBY-3304:
--
Interesting. It seems to have been fixed as a
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12556987#action_12556987
]
Daniel John Debrunner commented on DERBY-3304:
--
Not sure how that code could b
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557476#action_12557476
]
Dag H. Wanvik commented on DERBY-3304:
--
My preliminary analysis shows that the added c
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557480#action_12557480
]
Daniel John Debrunner commented on DERBY-3304:
--
Nice findings!
> Interestingl
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557483#action_12557483
]
Daniel John Debrunner commented on DERBY-3304:
--
Since holdability is at the ac
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557829#action_12557829
]
Dag H. Wanvik commented on DERBY-3304:
--
Tried this, but it is not sufficient, it seems
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560264#action_12560264
]
Mamta A. Satoor commented on DERBY-3304:
i will investigate more into this.
> Expl
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12561389#action_12561389
]
Mamta A. Satoor commented on DERBY-3304:
Following seems to say that CallStatementR
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12561435#action_12561435
]
Mamta A. Satoor commented on DERBY-3304:
I added a junit test case for the test cas
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12561565#action_12561565
]
Dag H. Wanvik commented on DERBY-3304:
--
I meant only that CallStatementResultSet#close
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12561582#action_12561582
]
Mamta A. Satoor commented on DERBY-3304:
Sorry for misinterpreting your comment, Da
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565471#action_12565471
]
Daniel John Debrunner commented on DERBY-3304:
--
I think the issue with the sta
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565446#action_12565446
]
Daniel John Debrunner commented on DERBY-3304:
--
+ //Do n
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565435#action_12565435
]
Mamta A. Satoor commented on DERBY-3304:
Based on the research/comments on this iss
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565649#action_12565649
]
Mamta A. Satoor commented on DERBY-3304:
I agree that Activation.reset should be ab
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565901#action_12565901
]
Mamta A. Satoor commented on DERBY-3304:
Committed changes into trunk with revision
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565902#action_12565902
]
Mamta A. Satoor commented on DERBY-3304:
I will work on migrating this change into
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565921#action_12565921
]
Daniel John Debrunner commented on DERBY-3304:
--
I think that revision 618788 m
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565924#action_12565924
]
Daniel John Debrunner commented on DERBY-3304:
--
Even the 'andClose' parameter
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566033#action_12566033
]
Mamta A. Satoor commented on DERBY-3304:
The commit comments for 618788 did not inc
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566034#action_12566034
]
Mamta A. Satoor commented on DERBY-3304:
I need to admit that I do not completely u
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566040#action_12566040
]
Mamta A. Satoor commented on DERBY-3304:
Since we do not reset the activations at t
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566168#action_12566168
]
Daniel John Debrunner commented on DERBY-3304:
--
mamta> I am thinking of changi
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566169#action_12566169
]
Daniel John Debrunner commented on DERBY-3304:
--
Thanks for the info about the
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566199#action_12566199
]
Mamta A. Satoor commented on DERBY-3304:
Dan, thanks for your feedback.
I will wo
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566453#action_12566453
]
Mamta A. Satoor commented on DERBY-3304:
After re-reading Dan's comment about updat
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566482#action_12566482
]
Mamta A. Satoor commented on DERBY-3304:
Created jira entry DERBY-3396(At the end t
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566928#action_12566928
]
Mamta A. Satoor commented on DERBY-3304:
Made some code cleanup changes into
Gener
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568817#action_12568817
]
Mamta A. Satoor commented on DERBY-3304:
Added a junit test case for number of code
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571144#action_12571144
]
Mamta A. Satoor commented on DERBY-3304:
I just finished making code changes and ad
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12572131#action_12572131
]
Knut Anders Hatlen commented on DERBY-3304:
---
I read through the commit log and fo
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12572185#action_12572185
]
Mamta A. Satoor commented on DERBY-3304:
Knut, I appreciate your code review. I wil
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12572374#action_12572374
]
Mamta A. Satoor commented on DERBY-3304:
Before addressing Knut's comments, I wante
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12572567#action_12572567
]
Mamta A. Satoor commented on DERBY-3304:
Merged 631108 from trunk into 10.3.2.2 cod
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12572641#action_12572641
]
Mamta A. Satoor commented on DERBY-3304:
Knut suggested if we can use EmbedResultSe
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12572789#action_12572789
]
Mamta A. Satoor commented on DERBY-3304:
Made some code cleanup changes based on th
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12572792#action_12572792
]
Mamta A. Satoor commented on DERBY-3304:
Forgot to add a comment about 2 trivial ch
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573002#action_12573002
]
Mamta A. Satoor commented on DERBY-3304:
Number of fixes have gone in this jira ent
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573246#action_12573246
]
Knut Anders Hatlen commented on DERBY-3304:
---
Regarding isClosed() vs checkIfClose
[
https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573355#action_12573355
]
Mamta A. Satoor commented on DERBY-3304:
I haven't investigated why the isClosed()
"Mamta A. Satoor (JIRA)" <[EMAIL PROTECTED]> writes:
> [
> https://issues.apache.org/jira/browse/DERBY-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12561582#action_12561582
> ]
>
> Mamta A. Satoor commented on DERBY-3304:
>
43 matches
Mail list logo