[
http://issues.apache.org/jira/browse/DERBY-941?page=comments#action_12377760 ]
V.Narayanan commented on DERBY-941:
---
Thanx for the commit knut !
Narayanan
Add JDBC4 support for Statement Events
--
Key:
[
http://issues.apache.org/jira/browse/DERBY-941?page=comments#action_12376896 ]
Knut Anders Hatlen commented on DERBY-941:
--
Hi Narayanan, I'm not able to apply your patch cleanly. Could you please
resolve the conflicts and upload a new patch?
[
http://issues.apache.org/jira/browse/DERBY-941?page=comments#action_12376904 ]
V.Narayanan commented on DERBY-941:
---
sorry for having made u go through the trouble of applying the broken patch.
Missed the conflict when I submitted the patches.
thanx
[
http://issues.apache.org/jira/browse/DERBY-941?page=comments#action_12376908 ]
Knut Anders Hatlen commented on DERBY-941:
--
Thanks Narayanan! Your new patch addresses all my comments. I have started the
tests, and will commit when they have
[
http://issues.apache.org/jira/browse/DERBY-941?page=comments#action_12376925 ]
Knut Anders Hatlen commented on DERBY-941:
--
I get this diff when running the jdbc40 suite with DerbyNetClient:
* Diff file
[
http://issues.apache.org/jira/browse/DERBY-941?page=comments#action_12376479 ]
Knut Anders Hatlen commented on DERBY-941:
--
Looks good, but I have some questions/comments:
* Should ClientJDBCObjectFactory40.newPreparedStatement() have
returned
[
http://issues.apache.org/jira/browse/DERBY-941?page=comments#action_12376244 ]
Knut Anders Hatlen commented on DERBY-941:
--
The patch looks good and the tests ran cleanly. I reindented some parts of the
code, since they had twice as much
[
http://issues.apache.org/jira/browse/DERBY-941?page=comments#action_12376246 ]
V.Narayanan commented on DERBY-941:
---
Thanx for the commit! My sincere apologies for the indentation errors. No I
have actually set it to a tab width of four. Anyway I will
[
http://issues.apache.org/jira/browse/DERBY-941?page=comments#action_12375102 ]
Knut Anders Hatlen commented on DERBY-941:
--
V.Narayanan commented on DERBY-941:
---
Hi,
thanx for the comments!
1) In the
[
http://issues.apache.org/jira/browse/DERBY-941?page=comments#action_12375103 ]
V.Narayanan commented on DERBY-941:
---
Hi knut,
thanx again for the comments!
I see ur point. Getting the StatementErrorOccured event would mean that the
Knut Anders Hatlen (JIRA) wrote:
[ http://issues.apache.org/jira/browse/DERBY-941?page=comments#action_12375102 ]
Knut Anders Hatlen commented on DERBY-941:
--
V.Narayanan commented on DERBY-941:
---
Hi,
This more so seems to assert true what Knut has said. In the specific
case of Derby although the PreparedStatement seems to be temporarily
rendered invalid it does not become unusable. The questions is whether
the connection pool manager needs to be informed of the seemingly
temporary
[
http://issues.apache.org/jira/browse/DERBY-941?page=comments#action_12374888 ]
Anurag Shekhar commented on DERBY-941:
--
Statement Event Listener is expected to be used by Statement pooling.
Nothing stops a regular application of add use this but
[
http://issues.apache.org/jira/browse/DERBY-941?page=comments#action_12374914 ]
Knut Anders Hatlen commented on DERBY-941:
--
Hi Anurag,
I'm not sure if the statement was invalid. That, I guess, depends on
the definition of invalid (you could
[
http://issues.apache.org/jira/browse/DERBY-941?page=comments#action_12374933 ]
V.Narayanan commented on DERBY-941:
---
Hi,
thanx for the comments!
1) In the example we are waiting for the affect of the Delete table operation
to be undone by the create
[
http://issues.apache.org/jira/browse/DERBY-941?page=comments#action_12374937 ]
V.Narayanan commented on DERBY-941:
---
Hi,
We are throwing the error occurred event only upon doing an execute on the
PreparedStatement. If the ConnectionPoolManager did know
[
http://issues.apache.org/jira/browse/DERBY-941?page=comments#action_12374821 ]
Rick Hillegas commented on DERBY-941:
-
Committed statementeventlisteners_embedded_v2.diff at subversion revision
394788. Derbyall runs cleanly modulo the wisconsin diffs.
[
http://issues.apache.org/jira/browse/DERBY-941?page=comments#action_12374600 ]
V.Narayanan commented on DERBY-941:
---
Hi Rick,
Thank you for the reviews of this patch. The class
EmbeddedConnectionPoolDataSource40 ,which ,has been added as part of 1137 is
[
http://issues.apache.org/jira/browse/DERBY-941?page=comments#action_12374333 ]
Rick Hillegas commented on DERBY-941:
-
Hi Narayanan: Now that DERBY-1163 and DERBY-1137 are committed, is this patch
ready for committing? Thanks-Rick
Add JDBC4 support
[
http://issues.apache.org/jira/browse/DERBY-941?page=comments#action_12374379 ]
Rick Hillegas commented on DERBY-941:
-
Hi Narayanan,
I'm afraid that I can't apply this patch. I think it might have been garbled
when you uploaded it. Could you retry
[
http://issues.apache.org/jira/browse/DERBY-941?page=comments#action_12373850 ]
V.Narayanan commented on DERBY-941:
---
Hi Rick,
Thank you for going through the patch. The class
EmbeddedConnectionPoolDataSource40 is being added as part of derby-1137. I
[
http://issues.apache.org/jira/browse/DERBY-941?page=comments#action_12373607 ]
V.Narayanan commented on DERBY-941:
---
please note that this patch has a dependency on derby-1137
Add JDBC4 support for Statement Events
[
http://issues.apache.org/jira/browse/DERBY-941?page=comments#action_12373707 ]
Rick Hillegas commented on DERBY-941:
-
Hi Narayanan,
Thanks for the patch and the accompanying explanation page. One issue:
EmbeddedConnectionPoolDataSource40 needs
[
http://issues.apache.org/jira/browse/DERBY-941?page=comments#action_12366224 ]
Rick Hillegas commented on DERBY-941:
-
Concerning connection events, here is Section 11.2 of the JDBC 4 spec:
70 JDBC 4.0 Specification • October 2005
11.2 Connection
24 matches
Mail list logo
