[jira] Updated: (DERBY-1146) Verify that JDBC4 signatures satisfied

2006-05-02 Thread Kristian Waagan (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1146?page=all ] Kristian Waagan updated DERBY-1146: --- Attachment: derby-1146-v2-enable.diff 'derby-1146-v2-enable.diff' enables the VerifySignatures patch, as it no longer fails. In addition, it sorts the

[jira] Updated: (DERBY-1146) Verify that JDBC4 signatures satisfied

2006-05-02 Thread Kristian Waagan (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1146?page=all ] Kristian Waagan updated DERBY-1146: --- Derby Info: [Patch Available] Verify that JDBC4 signatures satisfied -- Key: DERBY-1146 URL:

[jira] Updated: (DERBY-1146) Verify that JDBC4 signatures satisfied

2006-03-28 Thread Knut Anders Hatlen (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1146?page=all ] Knut Anders Hatlen updated DERBY-1146: -- Attachment: client.txt embedded.txt The test is not ready to be uploaded yet, but I thought I'd share the results I have found so

Re: [jira] Updated: (DERBY-1146) Verify that JDBC4 signatures satisfied

2006-03-28 Thread Andreas Korneliussen
This is very interesting. However, isn't it the job of the compiler to figure out that the signatures of an interface has been implemented ? I did the following change to EmbedResultSet40: I added implements java.sql.ResultSet in the class definition. The compilation then failed with:

Re: [jira] Updated: (DERBY-1146) Verify that JDBC4 signatures satisfied

2006-03-28 Thread Dyre . Tjeldvoll
Andreas Korneliussen [EMAIL PROTECTED] writes: This is very interesting. However, isn't it the job of the compiler to figure out that the signatures of an interface has been implemented ? It should be :) I think it would be good for all EmbedXXX40 to declare which interface they are

Re: [jira] Updated: (DERBY-1146) Verify that JDBC4 signatures satisfied

2006-03-28 Thread Anurag Shekhar
Also, I think this also indicates that we should consider using delegation instead of inheritance for code reuse. Andreas I didn't get it, how does it indicates that ? anurag

Re: [jira] Updated: (DERBY-1146) Verify that JDBC4 signatures satisfied

2006-03-28 Thread Andreas Korneliussen
Anurag Shekhar wrote: Also, I think this also indicates that we should consider using delegation instead of inheritance for code reuse. Andreas I didn't get it, how does it indicates that ? anurag Because now we are fooling the compiler to think that EmbedXXX40 classes implement

Re: [jira] Updated: (DERBY-1146) Verify that JDBC4 signatures satisfied

2006-03-28 Thread Knut Anders Hatlen
Andreas Korneliussen [EMAIL PROTECTED] writes: This is very interesting. However, isn't it the job of the compiler to figure out that the signatures of an interface has been implemented ? I did the following change to EmbedResultSet40: I added implements java.sql.ResultSet in the class

Re: [jira] Updated: (DERBY-1146) Verify that JDBC4 signatures satisfied

2006-03-28 Thread Anurag Shekhar
Adding the implements java.sql.XXX should take care of detecting missing methods in 4.0 classes. Delegating calls may be a safer way doing things but it has practical problem take the case of EmbedConnection. This class is being used in 102 different places in engine code. I haven't seen all

Re: [jira] Updated: (DERBY-1146) Verify that JDBC4 signatures satisfied

2006-03-28 Thread Rick Hillegas
I think that this test is the gold-standard. It supplies a missing sanity check which won't be available until we have a TCK for JDBC4. Thanks for writing this test, Knut Anders. Regards, -Rick Knut Anders Hatlen wrote: Andreas Korneliussen [EMAIL PROTECTED] writes: This is very

[jira] Updated: (DERBY-1146) Verify that JDBC4 signatures satisfied

2006-03-24 Thread Knut Anders Hatlen (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1146?page=all ] Knut Anders Hatlen updated DERBY-1146: -- Component: Test Verify that JDBC4 signatures satisfied -- Key: DERBY-1146 URL:

[jira] Updated: (DERBY-1146) Verify that JDBC4 signatures satisfied

2006-03-23 Thread Rick Hillegas (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1146?page=all ] Rick Hillegas updated DERBY-1146: - Component: JDBC Verify that JDBC4 signatures satisfied -- Key: DERBY-1146 URL: