[ http://issues.apache.org/jira/browse/DERBY-1417?page=all ]
Kristian Waagan updated DERBY-1417:
---
Derby Info: (was: [Patch Available])
> Add new, lengthless overloads to the streaming api
> --
>
>
[ http://issues.apache.org/jira/browse/DERBY-1417?page=all ]
Kristian Waagan updated DERBY-1417:
---
Attachment: derby-1417-9a-blobstream-newapproach.diff
derby-1417-9a-blobstream-newapproach.stat
Knut Anders,
Your worries make sense. How
[ http://issues.apache.org/jira/browse/DERBY-1417?page=all ]
Kristian Waagan updated DERBY-1417:
---
Derby Info: [Patch Available]
> Add new, lengthless overloads to the streaming api
> --
>
>
[ http://issues.apache.org/jira/browse/DERBY-1417?page=all ]
Kristian Waagan updated DERBY-1417:
---
Attachment: derby-1417-8a-enableblobstreaming.diff
derby-1417-8a-enableblobstreaming.stat
'derby-1417-8a-enableblobstreaming.diff' enables
[ http://issues.apache.org/jira/browse/DERBY-1417?page=all ]
Kristian Waagan updated DERBY-1417:
---
Derby Info: (was: [Patch Available])
> Add new, lengthless overloads to the streaming api
> --
>
>
[ http://issues.apache.org/jira/browse/DERBY-1417?page=all ]
Kristian Waagan updated DERBY-1417:
---
Derby Info: [Patch Available]
> Add new, lengthless overloads to the streaming api
> --
>
>
[ http://issues.apache.org/jira/browse/DERBY-1417?page=all ]
Kristian Waagan updated DERBY-1417:
---
Attachment: derby-1417-7a-clientborderfix.diff
derby-1417-7a-clientborderfix.stat
'derby-1417-7a-clientborderfix.diff' fixes bugs in the c
[ http://issues.apache.org/jira/browse/DERBY-1417?page=all ]
Kristian Waagan updated DERBY-1417:
---
Derby Info: (was: [Patch Available])
> Add new, lengthless overloads to the streaming api
> --
>
>
[ http://issues.apache.org/jira/browse/DERBY-1417?page=all ]
Kristian Waagan updated DERBY-1417:
---
Attachment: derby-1417-6d-clientimpl.diff
Thanks for the review Knut Anders.
I have uploaded revision d of patch 6.
See my comments and answers below.
[ http://issues.apache.org/jira/browse/DERBY-1417?page=all ]
Rick Hillegas updated DERBY-1417:
-
Urgency: Normal
> Add new, lengthless overloads to the streaming api
> --
>
> Key: DERBY-1417
Hello Kristian.
Thank you for taking my second opinion into account :)
I think EncodedInputStream is much better than before,
UTF32BEEncodedInputStream.
Best regards.
Kristian Waagan (JIRA) wrote:
[ http://issues.apache.org/jira/browse/DERBY-1417?page=all ]
Kristian Waagan updated DERB
[ http://issues.apache.org/jira/browse/DERBY-1417?page=all ]
Kristian Waagan updated DERBY-1417:
---
Attachment: derby-1417-6c-clientimpl.diff
'derby-1417-6c-clientimpl.diff' deprecates 6b.
Added both size of the character buffer and the initial size of t
TomohitoNakayama wrote:
Hello Kristian.
Thank you for taking my consideration into the patch and fix failure in
the name of class !
One more my opinion
In some encodings, such as UTF-16 "with Byte Order Mark" or ISO-2022-JP,
length of encoded bytes array is not just multiple of character
Hello Kristian.
Thank you for taking my consideration into the patch and fix failure in
the name of class !
One more my opinion
In some encodings, such as UTF-16 "with Byte Order Mark" or ISO-2022-JP,
length of encoded bytes array is not just multiple of characters count.
In those cases,
[ http://issues.apache.org/jira/browse/DERBY-1417?page=all ]
Kristian Waagan updated DERBY-1417:
---
Attachment: derby-1417-6b-clientimpl.diff
'derby-1417-6b-clientimpl.diff' deprecates 6a.
Changes:
1) Add missing license to two files.
2) Added static f
[ http://issues.apache.org/jira/browse/DERBY-1417?page=all ]
Kristian Waagan updated DERBY-1417:
---
Attachment: derby-1417-6a-clientimpl.diff
derby-1417-6a-clientimpl.stat
'derby-1417-6a-clientimpl.diff' adds the client side implementatio
[ http://issues.apache.org/jira/browse/DERBY-1417?page=all ]
Kristian Waagan updated DERBY-1417:
---
Derby Info: [Patch Available]
> Add new, lengthless overloads to the streaming api
> --
>
>
[ http://issues.apache.org/jira/browse/DERBY-1417?page=all ]
Knut Anders Hatlen updated DERBY-1417:
--
Derby Info: (was: [Patch Available])
Committed the 5a patch into trunk with revision 423807.
> Add new, lengthless overloads to the streaming api
[ http://issues.apache.org/jira/browse/DERBY-1417?page=all ]
Kristian Waagan updated DERBY-1417:
---
Derby Info: [Patch Available]
> Add new, lengthless overloads to the streaming api
> --
>
>
[ http://issues.apache.org/jira/browse/DERBY-1417?page=all ]
Kristian Waagan updated DERBY-1417:
---
Attachment: derby-1417-5a-brokered.diff
derby-1417-5a-brokered.stat
'derby-1417-5a-brokered.diff' adds the new overloads to the
iapi/jdbc
[ http://issues.apache.org/jira/browse/DERBY-1417?page=all ]
Knut Anders Hatlen updated DERBY-1417:
--
Derby Info: (was: [Patch Available])
Committed the 4a patch into trunk with revision 423068. (I changed one line
before committing because the pa
[ http://issues.apache.org/jira/browse/DERBY-1417?page=all ]
Kristian Waagan updated DERBY-1417:
---
Attachment: derby-1417-4a-disable-psTestsDnc.diff
'derby-1417-4a-disable-psTestsDnc.diff' disables 5 tests in
jdbc4/PreparedStatementTest for DerbyNetCli
[ http://issues.apache.org/jira/browse/DERBY-1417?page=all ]
Kristian Waagan updated DERBY-1417:
---
Attachment: derby-1417-3b-embimpl-and-tests.diff
derby-1417-3b-embimpl-and-tests.stat
Thanks for the review Knut Anders!
My replies follow
[ http://issues.apache.org/jira/browse/DERBY-1417?page=all ]
Kristian Waagan updated DERBY-1417:
---
Attachment: derby-1417-3a-embimpl-and-tests.diff
derby-1417-3a-embimpl-and-tests.stat
'derby-1417-3a-embimpl-and-tests.diff' provides test
[ http://issues.apache.org/jira/browse/DERBY-1417?page=all ]
Kristian Waagan updated DERBY-1417:
---
Derby Info: [Patch Available]
'derby-1417-2a-rstest-refactor.diff' ready for review/commit.
> Add new, lengthless overloads to the streaming api
> --
[ http://issues.apache.org/jira/browse/DERBY-1417?page=all ]
Kristian Waagan updated DERBY-1417:
---
Attachment: derby-1417-2a-rstest-refactor.diff
'derby-1417-2a-rstest-refactor.diff' refactors and rewrites parts of
jdbc4/ResultSetTest.junit.
A few util
You are correct that using specific implementation classes is completely
appropriate in general. However, in this case, I would not be able to
*easily* share the test code between the embedded and the client driver
when running the JUnit test in our harness (I'm not very fond of the
master base
Bryan Pendleton wrote:
Kristian Waagan (JIRA) wrote:
> I will add tests, but have to wait until the signatures have made it
into
> Mustang (I do have some tests already, but here I use the specific
> implementation classes, not the interfaces).
It seems to me that it's completely appropriat
Kristian Waagan (JIRA) wrote:
> I will add tests, but have to wait until the signatures have made it into
> Mustang (I do have some tests already, but here I use the specific
> implementation classes, not the interfaces).
It seems to me that it's completely appropriate for tests to use
specific i
[ http://issues.apache.org/jira/browse/DERBY-1417?page=all ]
Knut Anders Hatlen updated DERBY-1417:
--
Derby Info: (was: [Patch Available])
Committed 'derby-1417-1a-notImplemented.diff' into trunk with revision 417753.
> Add new, lengthless overloa
[ http://issues.apache.org/jira/browse/DERBY-1417?page=all ]
Kristian Waagan updated DERBY-1417:
---
Derby Info: [Patch Available]
> Add new, lengthless overloads to the streaming api
> --
>
> Key:
[ http://issues.apache.org/jira/browse/DERBY-1417?page=all ]
Kristian Waagan updated DERBY-1417:
---
Attachment: derby-1417-1a-notImplemented.diff
derby-1417-1a-notImplemented.stat
'derby-1417-1a-notImplemented.diff' adds a number of new l
[ http://issues.apache.org/jira/browse/DERBY-1417?page=all ]
Rick Hillegas updated DERBY-1417:
-
Attachment: derby-1417-01-castsInTests.diff
Attaching derby-1417-01-castsInTests.diff. This patch adds some casts to some
jdbc4 tests so that they will conti
[ http://issues.apache.org/jira/browse/DERBY-1417?page=all ]
Rick Hillegas updated DERBY-1417:
-
Description:
The JDBC4 Expert Group has approved a new set of overloads for the streaming
methods. These overloads do not take a length argument. Here are th
34 matches
Mail list logo
