Re: [Bug 1618886] Re: unity-gtk-module.service is racy; session services don't stop if session terminates

2016-10-02 Thread Iain Lane
On Sun, Oct 02, 2016 at 10:27:43AM -, Martin Pitt wrote: > Iain Lane [2016-10-01 19:26 -]: > > Hmm. Maybe this is saying that we should bind ubuntu-session.target to > > something else - like unity7? You can't log in again with an active > > unity7, so in theory (if stop is propagated down

Re: [Bug 1618886] Re: unity-gtk-module.service is racy; session services don't stop if session terminates

2016-10-02 Thread Iain Lane
On Sun, Oct 02, 2016 at 08:39:01AM -, Martin Pitt wrote: > > If you ever end up stopping gnome-keyring from within a new session > then its ExecStopPost kills the upstart session of this new one that we > are starting up, *not* the previous one that it was started up under. > > I assume you me

Re: [Bug 1618886] Re: unity-gtk-module.service is racy; session services don't stop if session terminates

2016-10-02 Thread Martin Pitt
Iain Lane [2016-10-01 19:26 -]: > Hmm. Maybe this is saying that we should bind ubuntu-session.target to > something else - like unity7? You can't log in again with an active > unity7, so in theory (if stop is propagated down to graphical-session > and graphical-session-pre) there wouldn't be a

[Bug 1618886] Re: unity-gtk-module.service is racy; session services don't stop if session terminates

2016-10-02 Thread Martin Pitt
> If you ever end up stopping gnome-keyring from within a new session then its ExecStopPost kills the upstart session of this new one that we are starting up, *not* the previous one that it was started up under. I assume you meant to say "gnome-session.service" here, not keyring (as its ExecStopPo

[Bug 1618886] Re: unity-gtk-module.service is racy; session services don't stop if session terminates

2016-10-02 Thread Launchpad Bug Tracker
This bug was fixed in the package upstart - 1.13.2-0ubuntu32 --- upstart (1.13.2-0ubuntu32) yakkety; urgency=medium * debian/systemd-graphical-session.conf: Stop any lingering active units when logging in. (LP: #1618886) * debian/control: Break old versions of gnome-session, w

Re: [Bug 1618886] Re: unity-gtk-module.service is racy; session services don't stop if session terminates

2016-10-01 Thread Iain Lane
On Sat, Oct 01, 2016 at 01:53:56PM -, Martin Pitt wrote: > > To fix that, something like comment #3 is needed. Such as looping over > all 'active' units that are PartOf graphical-session.target and stopping > them all. > > I think we would only need to "systemctl stop graphical-session.target"

[Bug 1618886] Re: unity-gtk-module.service is racy; session services don't stop if session terminates

2016-10-01 Thread Martin Pitt
> To fix that, something like comment #3 is needed. Such as looping over all 'active' units that are PartOf graphical-session.target and stopping them all. I think we would only need to "systemctl stop graphical-session.target" for this, otherwise a unit forgets the PartOf= and that loop would not

[Bug 1618886] Re: unity-gtk-module.service is racy; session services don't stop if session terminates

2016-09-28 Thread Launchpad Bug Tracker
This bug was fixed in the package gnome-session - 3.20.2-1ubuntu4 --- gnome-session (3.20.2-1ubuntu4) yakkety; urgency=medium * debian/data/run-systemd-session: Stop any lingering active units when logging in. (LP: #1618886) * debian/data/gnome-session.service: Save the XDG SE

[Bug 1618886] Re: unity-gtk-module.service is racy; session services don't stop if session terminates

2016-09-27 Thread Iain Lane
This isn't quite enough in this situation. - Log in over SSH or in a vt (so there is a logind session alive for your user) - Log into the same user in Unity - Simulate an Xorg crash (pkill -f -SEGV Xorg) - Log back in You don't have GTK_MODULES set properly. The previous gnome-session is lingerin

[Bug 1618886] Re: unity-gtk-module.service is racy; session services don't stop if session terminates

2016-09-20 Thread Launchpad Bug Tracker
This bug was fixed in the package upstart - 1.13.2-0ubuntu31 --- upstart (1.13.2-0ubuntu31) yakkety; urgency=medium * init/tests/test_conf.c: Disable previous check harder (on powerpc). upstart (1.13.2-0ubuntu30) yakkety; urgency=medium * init/tests/test_conf.c: Disable check in

[Bug 1618886] Re: unity-gtk-module.service is racy; session services don't stop if session terminates

2016-09-16 Thread Launchpad Bug Tracker
This bug was fixed in the package gnome-session - 3.20.2-1ubuntu3 --- gnome-session (3.20.2-1ubuntu3) yakkety; urgency=medium [ Dmitry Shachnev ] * Backport upstream patch to allow users to override $QT_QPA_PLATFORMTHEME (allow_overriding_qt_platformtheme.patch). [ Martin P

[Bug 1618886] Re: unity-gtk-module.service is racy; session services don't stop if session terminates

2016-09-16 Thread Martin Pitt
** Changed in: gnome-session (Ubuntu) Status: In Progress => Won't Fix ** Changed in: gnome-session (Ubuntu) Status: Won't Fix => Fix Committed -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-session in Ubuntu. htt

[Bug 1618886] Re: unity-gtk-module.service is racy; session services don't stop if session terminates

2016-09-16 Thread Martin Pitt
** Changed in: upstart (Ubuntu) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-session in Ubuntu. https://bugs.launchpad.net/bugs/1618886 Title: unity-gtk-module.service is racy; se

[Bug 1618886] Re: unity-gtk-module.service is racy; session services don't stop if session terminates

2016-09-16 Thread Launchpad Bug Tracker
** Branch linked: lp:~ubuntu-core-dev/upstart/ubuntu -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-session in Ubuntu. https://bugs.launchpad.net/bugs/1618886 Title: unity-gtk-module.service is racy; session services don't st

[Bug 1618886] Re: unity-gtk-module.service is racy; session services don't stop if session terminates

2016-09-16 Thread Martin Pitt
The same "missing $unit" is in /usr/share/upstart/systemd- session/upstart/systemd-graphical-session.conf. ** Also affects: upstart (Ubuntu) Importance: Undecided Status: New ** Changed in: upstart (Ubuntu) Status: New => In Progress ** Changed in: upstart (Ubuntu) Assignee

[Bug 1618886] Re: unity-gtk-module.service is racy; session services don't stop if session terminates

2016-09-16 Thread Launchpad Bug Tracker
** Branch linked: lp:~ubuntu-desktop/gnome-session/ubuntu -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-session in Ubuntu. https://bugs.launchpad.net/bugs/1618886 Title: unity-gtk-module.service is racy; session services don

[Bug 1618886] Re: unity-gtk-module.service is racy; session services don't stop if session terminates

2016-09-16 Thread Martin Pitt
Argh! if [ "$(systemctl --user show -p PartOf --value)" = "graphical- session.target" ]; then The systemctl --user call is missing a $unit argument, so this loop never actually worked. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed

[Bug 1618886] Re: unity-gtk-module.service is racy; session services don't stop if session terminates

2016-09-16 Thread Martin Pitt
> sudo killall -9 Xorg This causes some havoc -- as this does not actually stop anything in the session, random services just start failing the next time they try to talk to X. Due to our Restart=on-failure, these units then try to restart a few times until they hit the restart limit and go to "fa

[Bug 1618886] Re: unity-gtk-module.service is racy; session services don't stop if session terminates

2016-09-16 Thread Martin Pitt
** Changed in: gnome-session (Ubuntu) Status: Triaged => In Progress ** Changed in: gnome-session (Ubuntu) Milestone: None => ubuntu-16.09 -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-session in Ubuntu. https://bug

[Bug 1618886] Re: unity-gtk-module.service is racy; session services don't stop if session terminates

2016-09-13 Thread Launchpad Bug Tracker
This bug was fixed in the package unity-gtk-module - 0.0.0+16.10.20160913-0ubuntu1 --- unity-gtk-module (0.0.0+16.10.20160913-0ubuntu1) yakkety; urgency=medium * Fix $GTK_MODULES race condition (LP: #1618886) -- Martin Pitt Tue, 13 Sep 2016 15:27:01 + ** Changed in: unity-g

[Bug 1618886] Re: unity-gtk-module.service is racy; session services don't stop if session terminates

2016-09-13 Thread Martin Pitt
** Changed in: unity-gtk-module (Ubuntu) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-session in Ubuntu. https://bugs.launchpad.net/bugs/1618886 Title: unity-gtk-module.service is

[Bug 1618886] Re: unity-gtk-module.service is racy; session services don't stop if session terminates

2016-09-13 Thread Launchpad Bug Tracker
** Branch linked: lp:~pitti/unity-gtk-module/env-race -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-session in Ubuntu. https://bugs.launchpad.net/bugs/1618886 Title: unity-gtk-module.service is racy; session services don't s

[Bug 1618886] Re: unity-gtk-module.service is racy

2016-09-13 Thread Martin Pitt
The unity-gtk-module problem is simple enough to fix (bring back the upstart job, and restrict the systemd unit to dbus+systemd to avoid calling initctl set-env twice). Opening a second gnome-session task to investigate the more general "services don't go down when the session stops" issue. ** Als