As discussed with Cimi on irc, this one now uses unmap/map to avoid
setting the GTK_VISIBLE flag, so that the notifications come through
correctly.
** Patch added: Re-try of the fixed patch using map/unmap
the only thing I would do is trying to make the coding style a little
bit more consistent with the rest of gtk+, like the order of
variables/g_return_if_fail. aparto from that, I trust you if you tested
it and it seems to work. did you test it globally and in all your
previous testcases? if so,
This patch fixes a couple of coding style issues and simplifies
gtk_menubar_show and _hide.
** Patch added: Re-re-try of the fixed patch using map/unmap
https://bugs.launchpad.net/ubuntu/+source/gtk+2.0/+bug/705112/+attachment/1910444/+files/043_ubuntu_menu_proxy.patch
--
You received this
I see what could cause a failure, we should simply don't call
gtk_widget_show/hide but gtk_menu_bar_local_show/hide and set there the
private structure, no need of new signals like in your patch
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is
The updated patch helps with the issue, but some kind of race still
prevails. The updated test program sometimes shows and sometimes hides
the bar. Upping the priority to G_PRIORITY_HIGH_IDLE shows the menubar
(nearly) every time.
** Attachment added: lp705112-regression.c
Found the problem to be that GtkWidgetClass::hide is only called if the widget
was visible, thus if the call order is:
1. show()
2. hide()
3. local_notify(local = 1)
the menubar remains shown, but if the call order is:
1. show()
2. local_notify(local = 1)
3. hide()
things work correctly.
--
Reopening the bug and reverting the patch for now since it breaks things
** Changed in: gtk+2.0 (Ubuntu)
Status: Fix Released = Triaged
** Changed in: gtk+2.0 (Ubuntu)
Assignee: Didier Roche (didrocks) = (unassigned)
--
You received this bug notification because you are a member of
thanks Santtu for your work, we will get an updated patch in when the
issues are solved
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gtk+2.0 in ubuntu.
https://bugs.launchpad.net/bugs/705112
Title:
the menubar with appmenu-gtk
@Santtu:
with my patch, the menubar is never shown with your test app... are you sure
you tried my updated patch?
Also, looking at my code, I can't find anything wrong that could cause a
failure.
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is
The patch breaks applications that don't want to show a menubar on
startup (I noticed it with gnome-terminal). Attached file shows broken
behavior: even though menubar is explicitly hidden, it still shows up
when run.
** Attachment added: Sample application showing regression with the patch
the new issue is bug #717358
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gtk+2.0 in ubuntu.
https://bugs.launchpad.net/bugs/705112
Title:
the menubar with appmenu-gtk is 1px tall
--
desktop-bugs mailing list
Ok, I should update the patch
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gtk+2.0 in ubuntu.
https://bugs.launchpad.net/bugs/705112
Title:
the menubar with appmenu-gtk is 1px tall
--
desktop-bugs mailing list
** Changed in: gtk+2.0 (Ubuntu)
Assignee: (unassigned) = Didier Roche (didrocks)
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gtk+2.0 in ubuntu.
https://bugs.launchpad.net/bugs/705112
Title:
the menubar with appmenu-gtk is
Hey Cimi,
the patch unfortunatly fails to be build there, did you try on an updated natty?
You can find the relevant part of the build log here:
http://paste.ubuntu.com/565326/
Unsusbcribing ubuntu sponsor for now.
--
You received this bug notification because you are a member of Ubuntu
I'm trying a dpkg-buildpackage with this
** Patch added: fixes the typo
https://bugs.launchpad.net/ubuntu/+source/gtk+2.0/+bug/705112/+attachment/1841233/+files/043_ubuntu_menu_proxy.patch
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is
This bug was fixed in the package gtk+2.0 - 2.24.0-0ubuntu2
---
gtk+2.0 (2.24.0-0ubuntu2) natty; urgency=low
* update debian/patches/043_ubuntu_menu_proxy.patch:
- fix the menubar with appmenu-gtk is 1px tall (by Cimi) (LP: #705112)
-- Didier Roche didro...@ubuntu.com Thu,
Seb? could you please update the gtk+ package with that patch?
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gtk+2.0 in ubuntu.
https://bugs.launchpad.net/bugs/705112
Title:
the menubar with appmenu-gtk is 1px tall
--
** Changed in: gtk+2.0 (Ubuntu)
Importance: Undecided = Low
** Changed in: gtk+2.0 (Ubuntu)
Status: New = Confirmed
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gtk+2.0 in ubuntu.
https://bugs.launchpad.net/bugs/705112
** Tags added: patch
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gtk+2.0 in ubuntu.
https://bugs.launchpad.net/bugs/705112
Title:
the menubar with appmenu-gtk is 1px tall
--
desktop-bugs mailing list
In this patch, I've removed the code which uses requisition, and I simply
show/hide the menubar.
I was frightened that this could have broken something, but it seems to work
fine, and cody told me to proceed with that.
If we find any kind of regression, going back is easy.
It fixes an annoying
Overriding gtk_menu_bar_show, to make sure it will always hide the bar
(need testing)
** Patch added: updated patch of the updated patch :)
https://bugs.launchpad.net/ubuntu/+source/gtk+2.0/+bug/705112/+attachment/1799961/+files/043_ubuntu_menu_proxy.patch
--
You received this bug
21 matches
Mail list logo
