Re: Reminder: action required when updating dependencies or build options

2021-01-13 Thread Michael Catanzaro
On Wed, Jan 13, 2021 at 9:28 pm, Philip Withnall wrote: Given that you’ve just committed to submitting MRs and waiting for CI to pass, rather than pushing directly to master, perhaps this rule should be rethought? Hm... as long as we have permission to merge the MR after CI has passed, or

Re: Reminder: action required when updating dependencies or build options

2021-01-13 Thread Philip Withnall
On Wed, 2021-01-13 at 15:15 -0600, Michael Catanzaro wrote: >  > And similar behaviour over the years where you seemed to be under > the >  > impression that I was the only person in GNOME that felt that > peer- >  > reviewed patches and CI-gated merge requests were a requirement. >  > >  > Until

Re: Reminder: action required when updating dependencies or build options

2021-01-13 Thread Michael Catanzaro
On Wed, Jan 13, 2021 at 7:53 pm, Bastien Nocera wrote: > "I need to remember not to [push commits directly to the main branch] > for your modules, sorry" I was trying to be sincere, not dismissive: mcatanzaro: "I need to remember not to for your modules, sorry" "Can hardly complain about

Re: Reminder: action required when updating dependencies or build options

2021-01-13 Thread Bastien Nocera
On Wed, 2021-01-13 at 10:06 -0600, Michael Catanzaro wrote: > Hi, > > Yesterday, after I committed the typo to Calendar, I promised to use > merge requests from now on when committing build fixes. Previously, I > had promised to do this only for your projects, but yesterday I > forgot, > and

Re: Reminder: action required when updating dependencies or build options

2021-01-13 Thread Michael Catanzaro
Hi, Yesterday, after I committed the typo to Calendar, I promised to use merge requests from now on when committing build fixes. Previously, I had promised to do this only for your projects, but yesterday I forgot, and not for the first time. I understand that's frustrating. From now on,

Re: Reminder: action required when updating dependencies or build options

2021-01-13 Thread Bastien Nocera
(I tried to send this to the release-team@ alias/mailing-list, but that was shuttered last August, so seeing as it would be public on discourse anyway) On Tue, 2021-01-12 at 09:31 -0600, Michael Catanzaro wrote: > Hi developers, > > Please remember that action is required when updating your >

Re: Reminder: action required when updating dependencies or build options

2021-01-13 Thread Bastien Nocera
On Tue, 2021-01-12 at 16:50 +, Philip Withnall wrote: > On Tue, 2021-01-12 at 09:31 -0600, Michael Catanzaro wrote: > > Hi developers, > > > > Please remember that action is required when updating your > > dependencies > > or build options. You need to either make sure gnome-build-meta is >