Re: Reg. bug 704831

2013-09-08 Thread Sindhu S
Bump, another review perhaps? Thanks! On Wed, Sep 4, 2013 at 1:03 AM, Sindhu S sind...@live.in wrote: No problem, thank you for doing the review. I appreciate it. I have followed it up with another iteration of the patch. https://bugzilla.gnome.org/show_bug.cgi?id=704831#c2

Re: Reg. bug 704831

2013-09-03 Thread Sindhu S
No problem, thank you for doing the review. I appreciate it. I have followed it up with another iteration of the patch. https://bugzilla.gnome.org/show_bug.cgi?id=704831#c2 https://bugzilla.gnome.org/show_bug.cgi?id=704831#c3 On Mon, Aug 26, 2013 at 7:27 PM, Jasper St. Pierre

Re: Reg. bug 704831

2013-08-26 Thread Alberto Ruiz
Hey Sundhu, I have a question why are you using 'W' as the default? I can see a potential problem here since people use Ctrl+W to close tabs/documents/windows. Wouldn't Super_T make more sense as a shortcut? AFAIK is not used for anything atm. 2013/8/26 Sindhu S sind...@live.in: Hi, I have

Re: Reg. bug 704831

2013-08-26 Thread Sindhu S
Hi, Alberto There is no particular reason for Super + W by default (it's not Ctrl + W) but that key binding is customisable in dconf-editor. I don't mind changing the default to something else either :-) sure we can make it Super + T. I'd like a review on the code itself and the style so it be

Re: Reg. bug 704831

2013-08-26 Thread Jasper St. Pierre
Reviewed. Sorry for taking so long, other stuff came up and I flat out forgot about it. Feel free to ping me on IRC or send another mailing list post if I forget again. On Mon, Aug 26, 2013 at 12:25 AM, Sindhu S sind...@live.in wrote: Hi, I have patched mutter to have a keyboard binding for

Reg. bug 704831

2013-08-25 Thread Sindhu S
Hi, I have patched mutter to have a keyboard binding for the Always on Top window option. Can someone please review this patch? https://bugzilla.gnome.org/show_bug.cgi?id=704831 Thanks. -Sindhu ___ desktop-devel-list mailing list