Re: git commit messages

2009-05-16 Thread Filippo Argiolas
2009/4/22 Vincent Untz vu...@gnome.org: Hey,  - First line (the brief description) must only be one sentence and    should start with a capital letter unless it starts with a lowercase    symbol or identifier. Don't use a trailing period either. Don't exceed    72 characters. Hey, Sorry for

Re: git commit messages

2009-04-25 Thread Felipe Contreras
On Wed, Apr 22, 2009 at 10:10 PM, Behdad Esfahbod beh...@behdad.org wrote: Another option I like to document if we can agree on is prefixing the short-summary with a tag, like for example:  [layout] Improve X or Y Others suggested:  layout: Improve X or Y I prefer the former as it's

Re: git commit messages

2009-04-25 Thread Felipe Contreras
On Thu, Apr 23, 2009 at 7:09 PM, Shaun McCance sha...@gnome.org wrote: On Thu, 2009-04-23 at 11:45 +0200, Murray Cumming wrote: On Wed, 2009-04-22 at 16:46 +0200, Vincent Untz wrote: Don't use a trailing period either. I find this really odd and rather arbitrary. I think it's something to

Re: git commit messages

2009-04-25 Thread Felipe Contreras
On Wed, Apr 22, 2009 at 6:09 PM, Christophe Fergeau t...@gnome.org wrote: Hi Vincent, 2009/4/22 Vincent Untz vu...@gnome.org - When committing code on behalf of others use the --author option, e.g.    git commit -a --author Joe Coder j...@coder.org and --signoff.

Re: git commit messages

2009-04-24 Thread Vincent Untz
Le mercredi 22 avril 2009, à 16:46 +0200, Vincent Untz a écrit : We can copy paste it to http://live.gnome.org/Git/CommitMessages if people agree. I created this, with a few changes: + removed mention of --signoff + add tag on first line of commit message (as suggested by Behdad) + mention

Re: git commit messages

2009-04-24 Thread Vincent Untz
Le mercredi 22 avril 2009, à 07:55 -0700, Sandy Armstrong a écrit : I agree. And either Git/Developers should be expanded to include all these details, or its commit message section should link to Git/CommitMessages. I changed the section to link to Git/CommitMessages. Vincent -- Les gens

Re: git commit messages

2009-04-23 Thread Shaun McCance
On Thu, 2009-04-23 at 11:45 +0200, Murray Cumming wrote: On Wed, 2009-04-22 at 16:46 +0200, Vincent Untz wrote: Don't use a trailing period either. I find this really odd and rather arbitrary. I think it's something to do with you wanting to use these first lines in bullet-point lists. But

Re: git commit messages

2009-04-23 Thread Behdad Esfahbod
On 04/23/2009 08:47 AM, Loïc Minier wrote: On Wed, Apr 22, 2009, Vincent Untz wrote: Frédéric (fredp) is suggesting to also propose a standard scheme to reference bugs that are fixed by a commit (so we can script things if it's needed one day -- that's similar to what Debian does). Something

Re: git commit messages

2009-04-23 Thread Vincent Untz
Le jeudi 23 avril 2009, à 15:42 -0400, Behdad Esfahbod a écrit : On 04/23/2009 08:47 AM, Loïc Minier wrote: On Wed, Apr 22, 2009, Vincent Untz wrote: Frédéric (fredp) is suggesting to also propose a standard scheme to reference bugs that are fixed by a commit (so we can script things if it's

Re: git commit messages

2009-04-23 Thread Owen Taylor
On Thu, 2009-04-23 at 21:59 +0200, Vincent Untz wrote: Le jeudi 23 avril 2009, à 15:42 -0400, Behdad Esfahbod a écrit : On 04/23/2009 08:47 AM, Loïc Minier wrote: On Wed, Apr 22, 2009, Vincent Untz wrote: Frédéric (fredp) is suggesting to also propose a standard scheme to reference bugs

Re: git commit messages

2009-04-23 Thread Shaun McCance
On Thu, 2009-04-23 at 16:23 -0400, Owen Taylor wrote: On Thu, 2009-04-23 at 21:59 +0200, Vincent Untz wrote: Le jeudi 23 avril 2009, à 15:42 -0400, Behdad Esfahbod a écrit : On 04/23/2009 08:47 AM, Loïc Minier wrote: On Wed, Apr 22, 2009, Vincent Untz wrote: Frédéric (fredp) is

git commit messages

2009-04-22 Thread Vincent Untz
Hey, The GTK+ team documented how they'd like to see the git commit messages in http://git.gnome.org/cgit/gtk+/tree/README.commits = copy paste = The expected format for git commit messages is as follows: === begin example commit === Short explanation

Re: git commit messages

2009-04-22 Thread Sandy Armstrong
On Wed, Apr 22, 2009 at 7:46 AM, Vincent Untz vu...@gnome.org wrote: Hey, The GTK+ team documented how they'd like to see the git commit messages in http://git.gnome.org/cgit/gtk+/tree/README.commits = copy paste = The expected format for git commit

Re: git commit messages

2009-04-22 Thread Simos Xenitellis
On Wed, Apr 22, 2009 at 4:09 PM, Christophe Fergeau t...@gnome.org wrote: Hi Vincent, 2009/4/22 Vincent Untz vu...@gnome.org - When committing code on behalf of others use the --author option, e.g.    git commit -a --author Joe Coder j...@coder.org and --signoff.

Re: git commit messages

2009-04-22 Thread Steve Frécinaux
Vincent Untz wrote: Frédéric (fredp) is suggesting to also propose a standard scheme to reference bugs that are fixed by a commit (so we can script things if it's needed one day -- that's similar to what Debian does). Something like Closes: #123456 or Fixes: #123456. I think KDE uses

Re: git commit messages

2009-04-22 Thread Vincent Untz
Le mercredi 22 avril 2009, à 16:46 +0200, Vincent Untz a écrit : Hey, The GTK+ team documented how they'd like to see the git commit messages in http://git.gnome.org/cgit/gtk+/tree/README.commits = copy paste = The expected format for git commit

Re: git commit messages

2009-04-22 Thread Christophe Fergeau
Hi Vincent, 2009/4/22 Vincent Untz vu...@gnome.org - When committing code on behalf of others use the --author option, e.g. git commit -a --author Joe Coder j...@coder.org and --signoff. Opinions? Not sure about the --signoff

Re: git commit messages

2009-04-22 Thread Behdad Esfahbod
On 04/22/2009 10:46 AM, Vincent Untz wrote: I'd like to suggest that this is the default recommendation for GNOME modules, since having some common guidelines will make the life easier for most people. If some maintainers disagree, they can of course ask for something else in their modules.