[Desktop-packages] [Bug 33288]

2014-02-21 Thread Brian Ewins
(In reply to comment #70) (I originally replied on launchpad, which is supposed to copy it through to here, but it hasn't.) Carlos: it isn't a regression that lines outside a rectangle formed by the start and endpoints are included, it's the intent. Consider selecting in a document with two

[Desktop-packages] [Bug 33288] Re: Evince doesn't handle columns properly

2013-12-01 Thread Brian Ewins
(oops, replied on launchpad, not sure if Carlos reads there. Repeating for fdo) Carlos: it isn't a regression that lines outside a rectangle formed by the start and endpoints are included, it's the intent. Consider selecting in a document with two columns, starting in the 1st column 2/3 down the

[Desktop-packages] [Bug 33288] Re: Evince doesn't handle columns properly

2013-12-01 Thread Brian Ewins
Carlos: it isn't a regression that lines outside a rectangle formed by the start and endpoints are included, it's the intent. Consider selecting in a document with two columns, starting in the 1st column 2/3 down the page, ending in the 2nd column 1/3 down the page. In this case, the correct

[Desktop-packages] [Bug 33288]

2012-09-10 Thread Brian Ewins
It should be possible to improve this substantially. When I wrote the patch I was being very conservative with the existing poppler data structures, so essentially that method is traversing an unordered list. If the block list was in isBeforeByRule1 order most of those comparisons would go away. I

[Desktop-packages] [Bug 33288]

2012-09-10 Thread Brian Ewins
Created attachment 40061 improved patch Had another look and tidied the code a bit removing repeated page orientation checks, and a redundant test for overlap in rule(2). This is noticeably faster rendering the bus map. (down to ~14.8s) -- You received this bug notification because you are a

[Desktop-packages] [Bug 33288]

2012-09-10 Thread Brian Ewins
Created attachment 40056 patch to fix performance regression Here's what I've got so far. On my very slow VM, this renders the paris bus map reported on the mailing list in ~15.2s, compared to ~60s without the patch. YX-sorting alone got the time down to ~16.2s. Rendering on other documents is as

[Desktop-packages] [Bug 33288]

2012-09-10 Thread Brian Ewins
Created attachment 40124 patch without extraneous whitespace changes Oops! Ok, here's the patch without the whitespace changes. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to poppler in Ubuntu. https://bugs.launchpad.net/bugs/33288