[Desktop-packages] [Bug 597825]

2014-04-02 Thread Enn
The Windows api protion of this is already complete. What needs to be done here is: - update nsTextBoxFrame to only draw accelerators when its window says as much from nsGlobalWindow::GetKeyboardIndicators. - update the label-control binding - handle when the alt key is pressed/released (and any

[Desktop-packages] [Bug 107247]

2011-10-14 Thread Enn
Comment on attachment 565950 Fixed proof of concept Testing and debugging shows that this seems to work. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/107247 Title: Launchpad bug pa

[Desktop-packages] [Bug 107247]

2011-10-11 Thread Enn
Caret browsing doesn't work with this patch. The page scrolls when I try to move the caret up and down. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/107247 Title: Launchpad bug page

[Desktop-packages] [Bug 107247]

2011-10-11 Thread Enn
There seems to be some expectation that I respond here but I have nothing else to add. The patch creates an issue as described in comment 26. The same issue occurs with caret browsing enabled or disabled. -- You received this bug notification because you are a member of Desktop Packages, which is

[Desktop-packages] [Bug 602877]

2011-09-21 Thread Enn
Comment on attachment 561438 patch4 Not sure what you're asking me to review but the call to MoveFocus looks ok. The FLAG_BYMOVEFOCUS won't flag actually do anything here. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubunt

[Desktop-packages] [Bug 779581]

2011-08-29 Thread Enn
Comment on attachment 553868 stop making the close button focusable Is this reverting back 462289 or is that fixed in some other way? What effect does removing stopPropagation have here? -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to f

[Desktop-packages] [Bug 779581]

2011-08-29 Thread Enn
Where does the close button get -moz-user-focus set to normal, that we need to set it to 'ignore'? Can we remove the rule for '.tab-close-button:focus' from windows browser.css? -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in

[Desktop-packages] [Bug 107247]

2011-08-19 Thread Enn
I get the same whether caret browsing is enabled or not. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/107247 Title: Launchpad bug pages trigger caret browsing in Firefox and other G

[Desktop-packages] [Bug 107247]

2011-08-19 Thread Enn
Comment on attachment 548949 Proof of concept I'm not sure if something else is being asked of me here. With this patch: 1. Click in the editable area 2. Press cursor up/down Expected: The caret moves up/down a line Actual: Page scrolls, so keyboard users cannot edit other lines. -- You