[Desktop-packages] [Bug 263435]

2020-05-08 Thread Masayuki
Hey, I said, "If you think that it's not enough to reserve shortcut keys for some functions, please file a bug for each shortcut key". And Ctrl+N, Ctrl+W and Ctrl+T should work on Windows. They are reserved shortcut keys. -- You received this bug notification because you are a member of Desktop

[Desktop-packages] [Bug 263435]

2020-05-08 Thread Masayuki
This is now (Fx 48~), fixed by bug 1203059 only for "reserved" shortcut keys. If you think that it's not enough to reserve shortcut keys for some functions, please file a bug for each shortcut key. Our agreement is, we do NOT enable whole shortcut keys on plugins, e.g., Ctrl+C, etc. So, be carefu

[Desktop-packages] [Bug 263435]

2020-05-08 Thread Masayuki
And nobody shouldn't reopen this bug because I implemented a way to override shortcut keys even if a plugin has focus. So, if you find specific problem, please file a bug for each problem. This bug has too many CC list and a lot of comments. So, it doesn't make sense to keep discussing on this bug.

[Desktop-packages] [Bug 263435]

2020-05-08 Thread Masayuki
FYI: Windows specific fix: bug 1257759 Mac specific fix: bug 1257760 And note that this is WONTFIX on Linux due to event handling model limitation, technically. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to flashplugin-nonfree in Ubun

[Desktop-packages] [Bug 32891]

2020-03-30 Thread Masayuki
Moving all open keyboard/IME handling bugs to DOM: UI Events & Focus Handling component. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/32891 Title: Improve support for non-gnome Inpu

[Desktop-packages] [Bug 1228250]

2019-03-13 Thread Masayuki
2-3. Handle deltaX as horizontal scroll too (but may cause too fast or slow scroll with diagonal wheel operation). I like 1-1, 1-3 or 2-2. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs

[Desktop-packages] [Bug 1228250]

2019-03-13 Thread Masayuki
Comment on attachment 8915954 Bug 143038 Make users can scroll contents horizontally with vertical wheel operation with a modifier Review request updated; see interdiff: https://reviewboard.mozilla.org/r/186794/diff/1-2/ -- You received this bug notification because you are a member of Desktop

[Desktop-packages] [Bug 1228250]

2019-03-13 Thread Masayuki
Comment on attachment 8915954 Bug 143038 Make users can scroll contents horizontally with vertical wheel operation with a modifier https://reviewboard.mozilla.org/r/186794/#review192730 ::: commit-message-19b32:26 (Diff revision 1) > +restoring. > + > +So, this patch does NOT change any wheel ev

[Desktop-packages] [Bug 1228250]

2019-03-13 Thread Masayuki
(In reply to Olli Pettay [:smaug] from comment #111) > (In reply to Masayuki Nakano [:masayuki] (JST, +0900) from comment #108) > > > On macOS, we may receive diagonal wheel operation events. In such case, we > > should not respect the new pref because the new pref is for legac

[Desktop-packages] [Bug 1228250]

2019-03-13 Thread Masayuki
Comment on attachment 8915954 Bug 143038 Make users can scroll contents horizontally with vertical wheel operation with a modifier Review request updated; see interdiff: https://reviewboard.mozilla.org/r/186794/diff/3-4/ -- You received this bug notification because you are a member of Desktop

[Desktop-packages] [Bug 1228250]

2019-03-13 Thread Masayuki
https://treeherder.mozilla.org/#/jobs?repo=try&revision=57d5864711a2a2bd65130644c9da616017184b58 -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wh

[Desktop-packages] [Bug 1228250]

2019-03-13 Thread Masayuki
Comment on attachment 8915954 Bug 143038 Make users can scroll contents horizontally with vertical wheel operation with a modifier Review request updated; see interdiff: https://reviewboard.mozilla.org/r/186794/diff/4-5/ -- You received this bug notification because you are a member of Desktop

[Desktop-packages] [Bug 1228250]

2019-03-13 Thread Masayuki
Comment on attachment 8915954 Bug 143038 Make users can scroll contents horizontally with vertical wheel operation with a modifier https://reviewboard.mozilla.org/r/186794/#review193228 > Oh, modifier in the JS object isn't about the event but about the pref. Could you document that somewhere I

[Desktop-packages] [Bug 1228250]

2019-03-13 Thread Masayuki
Requesting ni? for the above reply from MozReview. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally Status in M

[Desktop-packages] [Bug 1228250]

2019-03-13 Thread Masayuki
Oops, I used wrong form to reply to the review comments :-( -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally St

[Desktop-packages] [Bug 1228250]

2019-03-13 Thread Masayuki
(In reply to Olli Pettay [:smaug] from comment #113) > (In reply to Masayuki Nakano [:masayuki] (JST, +0900) from comment #112) > > Anyway, I don't think that we should use this feature when the user's device > > is obviously non-legacy pointing device, i.e., it supports

[Desktop-packages] [Bug 1228250]

2019-03-13 Thread Masayuki
https://treeherder.mozilla.org/#/jobs?repo=try&revision=eedf1e99a374ea782be21bb64d707fa014c9b435 -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wh

[Desktop-packages] [Bug 1228250]

2019-03-13 Thread Masayuki
Okay, now, I think that 2-2 is the best here because: 1. if we ban diagonal wheel events with specific modifier key, horizontal scroll might be too slow if the device can cause diagonal scroll easily (even if user expects only vertical scroll). 2. if we also take deltaX as horizontal scroll, hor

[Desktop-packages] [Bug 1228250]

2019-03-13 Thread Masayuki
Comment on attachment 8915954 Bug 143038 Make users can scroll contents horizontally with vertical wheel operation with a modifier Review request updated; see interdiff: https://reviewboard.mozilla.org/r/186794/diff/2-3/ -- You received this bug notification because you are a member of Desktop

[Desktop-packages] [Bug 1228250]

2019-03-13 Thread Masayuki
Comment on attachment 8915954 Bug 143038 Make users can scroll contents horizontally with vertical wheel operation with a modifier https://reviewboard.mozilla.org/r/186794/#review192674 > Could you explain this. Currently shift+vertical wheel is back-forward. Does > this new behavior override t

[Desktop-packages] [Bug 1228250]

2019-03-13 Thread Masayuki
(In reply to public from comment #128) > This add-on can be used until Firefox 58 has been released: Shift + Scroll > (Horizontal Scrolling) - > https://addons.mozilla.org/en-US/firefox/addon/shift-scroll/ Firefox 56 and earlier, it can be implemented by XUL addons, but Gecko 58+ has this feature.

[Desktop-packages] [Bug 1228250]

2019-03-13 Thread Masayuki
Comment on attachment 8915954 Bug 143038 Make users can scroll contents horizontally with vertical wheel operation with a modifier https://reviewboard.mozilla.org/r/186794/#review193228 Because the tests set default action of both without any modifier and with shift to "scroll": > default: 1, w

[Desktop-packages] [Bug 1228250]

2019-03-13 Thread Masayuki
Comment on attachment 8915954 Bug 143038 Make users can scroll contents horizontally with vertical wheel operation with a modifier https://reviewboard.mozilla.org/r/186794/#review195394 > You change the ordering of whether action is first checked for plugin or apz, and delta is adjusted before t

[Desktop-packages] [Bug 1228250]

2019-03-13 Thread Masayuki
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c8a75e4e55f87b622341651c1ff95e097272cb0f -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wh

[Desktop-packages] [Bug 1228250]

2019-03-13 Thread Masayuki
Created attachment 8915954 Bug 143038 Make users can scroll contents horizontally with vertical wheel operation with a modifier This patch declares a new pref, "mousewheel.modifier_to_treat_vertical_wheel_as_horizontal_scroll", this takes a keycode of modifier keys as its value. The default valu

[Desktop-packages] [Bug 1228250]

2019-03-13 Thread Masayuki
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f517c8a2bdf5265c785e60f2b9d125285869c42f -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wh

[Desktop-packages] [Bug 1228250]

2019-03-13 Thread Masayuki
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e15a3bcb3fcc3f8288e6f6ffdc31e28d042542ea -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wh

[Desktop-packages] [Bug 1228250]

2019-03-13 Thread Masayuki
I realized that due to e10s mochitests disabled, we won't test the default actions of wheel events without APZ. I manually ran the test without non-e10s mochitests. Then, I confirmed that it's all green. On the other hand, there is a known bug in the patch. The multiplier pref for X axis is appli

[Desktop-packages] [Bug 1228250]

2019-03-13 Thread Masayuki
(In reply to Olli Pettay [:smaug] from comment #85) > (In reply to Masayuki Nakano (:masayuki) (Mozilla Japan) from comment #82) > > > That sounds like a minor problem that could be fixed in this bug or a > > > follow-up. > > > > I think that we should decide

[Desktop-packages] [Bug 1228250]

2019-03-13 Thread Masayuki
https://treeherder.mozilla.org/#/jobs?repo=try&revision=554cd7fe7479c2cad7a3e246280eaf611a8c59f1 -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wh

[Desktop-packages] [Bug 1228250]

2014-02-04 Thread Masayuki
(In reply to nandhp from comment #75) > First, my desktop still has a 1-dimensional wheel. After all, mice aren't > the kind of gadget that have compelling reasons for people to upgrade them > every six months. Well, but horizontal scroll is supported on Vista or later with native message. So, all

[Desktop-packages] [Bug 1228250]

2014-02-04 Thread Masayuki
(In reply to Masayuki Nakano (:masayuki) (Mozilla Japan) from comment #76) > (In reply to nandhp from comment #75) > > I still think this feature is useful, even if I don't need it myself. > > If so, why don't you change the default settings? Oops, you're not janx.

[Desktop-packages] [Bug 1228250]

2014-02-04 Thread Masayuki
(In reply to Jan Keromnes [:janx] from comment #80) > > 2. If it's not enabled in default settings, how many people would use > > (realize) this feature? > > Giving frustrated users no option to enable this is bad. Currently, > searching for how to enable this feature in firefox gives a lot of "n

[Desktop-packages] [Bug 1228250]

2014-02-04 Thread Masayuki
And I'd like to know if other browsers have this feature? -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally Stat

[Desktop-packages] [Bug 1228250]

2014-02-04 Thread Masayuki
Sorting out my concern: 1. Many people still want this in these days? 2. If it's not enabled in default settings, how many people would use (realize) this feature? 3. If it doesn't swap DOM wheel event's delta values, users won't scroll custom scrollable elements implemented with JS horizontally

[Desktop-packages] [Bug 1228250]

2014-02-04 Thread Masayuki
Comment on attachment 8369358 Horizontal Scrolling with Mouse wheel+ modifier key I believe that you want to swap the scroll direction completely. However, your patch just swap the scroll direction of default action of wheel event. E.g., scrollable element implemented with JS is scroll normally wi

[Desktop-packages] [Bug 1228250]

2014-02-04 Thread Masayuki
Oh, Shift + Wheel is now navigating history on non-Mac platforms... http://mxr.mozilla.org/mozilla-central/source/browser/app/profile/firefox.js#604 -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad

[Desktop-packages] [Bug 744580]

2012-02-29 Thread Masayuki
No. There are some issues which must be fixed before landing. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/744580 Title: Firefox doesn't auto scroll when selecting content downwards