glib2.0 memleak patch moved over to bug 1750741
** No longer affects: glib2.0 (Ubuntu)
** No longer affects: glib2.0 (Ubuntu Trusty)
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to glib2.0 in Ubuntu.
** Description changed:
[Impact]
lrmd daemon with upstart resource has memory leak in Trusty
affected to pacemaker 1.1.10.
- affected to glib2.0 2.40.2-0ubuntu1
+ affected to glib2.0 2.40.2-0ubuntu1 >> for glib2.0 created new lp [3]
Please note that patch for pacemaker is created
Seyeong,
can you check this updated debdiff to verify it still fixes the mem
leak?
I reverted the free->g_free changes that I previously suggested, as you
were correct - the existing code uses chars and normal free() so we
should stick with that, i was wrong to suggest using g_free().
Also I
Ok, in that case, can you open a separate lp bug for the glib2.0 memory
leak? I think it will be easier to track just fixing the pacemaker mem
leaks in this bug, and track fixing the glib2.0 mem leak in a separate
bug.
--
You received this bug notification because you are a member of Desktop
Hello ddstreet
I confirmed that glib2.0 patch is needed.
I installed patched_pacemaker only on my system and running just 1 hour.
it started with 4700(RES) but now it is 8000(RES).
after installing glib2.0
it started with 4612, now is is 4688
Thanks
[1] is script to reproduce this issue.
the glib change seems buggy, the upstream bug corresponding to the first
patch https://bugzilla.gnome.org/show_bug.cgi?id=758641 states that the
issue was in code commited in 2.45 or trusty has 2.40 so it seems wrong
to try to use it on that codebase (unsure about the other ones)
** Bug watch
Seyeong, can you also clarify - are the glib2.0 patches also needed to
fix memory leaks?
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to glib2.0 in Ubuntu.
https://bugs.launchpad.net/bugs/1316970
Title:
g_dbus memory leak in lrmd
sure, no problem
Thanks eric
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to glib2.0 in Ubuntu.
https://bugs.launchpad.net/bugs/1316970
Title:
g_dbus memory leak in lrmd
Status in glib2.0 package in Ubuntu:
New
Status in pacemaker
Seyeong,
The SRU for LP: #1740892 is not started yet, but base on nacc's comment, It
should start soon :
https://bugs.launchpad.net/charm-hacluster/+bug/1740892/comments/47
I would suggest to wait for LP: #1740892 SRU to be completed first since
it affects package upgrade (corosync/pacemaker
Hello Eric, ddstreet
#1740892 seems starting to fix
Could you guys can sponsor this issue as well?
Thanks a lot
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to glib2.0 in Ubuntu.
https://bugs.launchpad.net/bugs/1316970
Title:
Seyeong/ddstreet,
As long as this critical bug (LP: #1740892) affecting corosync/pacemaker
relation is not fix, I would be reluctant to sponsor this bug for the
following reasons :
- To make sure it won't block potential pacemaker sru to fix this critical bug
by start this one here.
- To make
@ddstreet
Could you please review V3 again?
Thanks in advance!
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to glib2.0 in Ubuntu.
https://bugs.launchpad.net/bugs/1316970
Title:
g_dbus memory leak in lrmd
Status in glib2.0 package
For V3.
It seems that g_variant_unref(value); part is needed.
Added it again and no memory leaks.
in g_variant_lookup_value, it calls g_variant_get_child_value
so as you said. it need to be unref value as well i think.
Thanks.
--
You received this bug notification because you are a member
** Patch added: "lp1316970_trusty_pacemaker_v3.debdiff"
https://bugs.launchpad.net/ubuntu/+source/pacemaker/+bug/1316970/+attachment/5048947/+files/lp1316970_trusty_pacemaker_v3.debdiff
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to
hmm, this has leak more than before..
testing..
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to glib2.0 in Ubuntu.
https://bugs.launchpad.net/bugs/1316970
Title:
g_dbus memory leak in lrmd
Status in glib2.0 package in Ubuntu:
New
** Patch added: "lp1316970_trusty_pacemaker_v2.debdiff"
https://bugs.launchpad.net/ubuntu/+source/pacemaker/+bug/1316970/+attachment/5047782/+files/lp1316970_trusty_pacemaker_v2.debdiff
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to
Hello ddstreet
Thanks for the review.
I changed some code for pacemaker. ( char -> gchar for matching type,
with g_free)
and glib2.0 patch is needed in my test.
without it, memory leak is there. 4kB leak every 10 second at least.
Thanks.
--
You received this bug notification because you are
Hi Seyeong,
first, I commend you for going to the trouble of fixing tests in
lp1316970_trusty_glib2.0.debdiff, but I think those are unrelated to
this actual bug and so the patch is not required for this. I'll focus
only on the first patch.
In that patch, I did a quick review of the changes,
** Description changed:
[Impact]
lrmd daemon with upstart resource has memory leak in Trusty
affected to pacemaker 1.1.10.
+ affected to glib2.0 2.40.2-0ubuntu1
+
+ Please note that patch for pacemaker is created myself.
[Test Case]
1. deploy 3 trusty instance.
2. install
** Patch added: "lp1316970_trusty_glib2.0.debdiff"
https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1316970/+attachment/5047147/+files/lp1316970_trusty_glib2.0.debdiff
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to glib2.0 in
** Attachment added: "valgrind-afterpatch"
https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1316970/+attachment/5047145/+files/valgrind-afterpatch
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to glib2.0 in Ubuntu.
** Attachment added: "valgrind-beforepatch"
https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1316970/+attachment/5047144/+files/valgrind-beforepatch
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to glib2.0 in Ubuntu.
** Patch added: "lp1316970_trusty_pacemaker.debdiff"
https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1316970/+attachment/5047146/+files/lp1316970_trusty_pacemaker.debdiff
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to glib2.0
** Also affects: glib2.0 (Ubuntu)
Importance: Undecided
Status: New
** Patch removed: "lp1316970_trusty.debdiff"
https://bugs.launchpad.net/ubuntu/+source/glib2.0/+bug/1316970/+attachment/5031302/+files/lp1316970_trusty.debdiff
--
You received this bug notification because you are
24 matches
Mail list logo
