[Desktop-packages] [Bug 1756006] Re: FFe: Support suspend-to-hibernate

2018-03-15 Thread Kai-Heng Feng
Out of curiosity - do we have firmware-based hibernate [1] enabled out of the box? [1] https://mjg59.dreamwidth.org/26022.html -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to gnome-settings-daemon in Ubuntu. https://bugs.launchpad.net/bu

[Desktop-packages] [Bug 1756006] Re: FFe: Support suspend-to-hibernate

2018-03-15 Thread Mario Limonciello
No, not on modern system. We haven't used that technology for a while. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to gnome-settings-daemon in Ubuntu. https://bugs.launchpad.net/bugs/1756006 Title: FFe: Support suspend-to-hibernate

[Desktop-packages] [Bug 1756006] Re: FFe: Support suspend-to-hibernate

2018-03-24 Thread Jeremy Bicha
** Tags added: bionic rls-bb-incoming -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to gnome-settings-daemon in Ubuntu. https://bugs.launchpad.net/bugs/1756006 Title: FFe: Support suspend-to-hibernate Status in gnome-settings-daemon pa

[Desktop-packages] [Bug 1756006] Re: FFe: Support suspend-to-hibernate

2018-03-25 Thread Dimitri John Ledkov
>From systemd point of view, the patches are relatively straight forward, and simply add "one more way to sleep/suspend/hybernate/etc" without affecting any other code paths or any other functionality. Thus i see little risk for landing the systemd patches. If this turns out to be bad, only the po

[Desktop-packages] [Bug 1756006] Re: FFe: Support suspend-to-hibernate

2018-03-26 Thread Łukasz Zemczak
Actually, I guess an UIFe will anyway be required as for the gnome- settings-manager? I can't reach the Gnome gitlab today so I don't know for sure. If it does affect some user visible strings, please proceed as per my earlier comment and if the respective teams go +1 on it, we'll formally switch t

[Desktop-packages] [Bug 1756006] Re: FFe: Support suspend-to-hibernate

2018-03-26 Thread Łukasz Zemczak
I am generally fine with this feature, especially after Dimitri's input. So formally I approve of this FFe. But since this will also be changing user-visible strings in systemd, I *think* you will also need to have an UIFe, e.g. you will have to inform the doc and translation teams [1]. I'm not sur

[Desktop-packages] [Bug 1756006] Re: FFe: Support suspend-to-hibernate

2018-03-27 Thread Sebastien Bacher
(rls-bb-notfixing from a desktop perspective, it doesn't need to be milestoned but we want to review/comment on the change anyway) ** Tags removed: rls-bb-incoming ** Tags added: rls-bb-notfixing -- You received this bug notification because you are a member of Desktop Packages, which is subscri

[Desktop-packages] [Bug 1756006] Re: FFe: Support suspend-to-hibernate

2018-03-28 Thread Sebastien Bacher
upstream g-s-d asked for a name change but otherwise it seems fine in principle -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to gnome-settings-daemon in Ubuntu. https://bugs.launchpad.net/bugs/1756006 Title: FFe: Support suspend-to-hib

[Desktop-packages] [Bug 1756006] Re: FFe: Support suspend-to-hibernate

2018-03-28 Thread Gunnar Hjalmarsson
This is an important improvement, so I have no objections from a docs and/or translators POV. One plea, though: To the extent this introduces new or changed translatable strings, please notify the translators on the ubuntu- translators list once those strings have been made available for translati

[Desktop-packages] [Bug 1756006] Re: FFe: Support suspend-to-hibernate

2018-03-28 Thread Iain Lane
The systemd part is OK since it's cherry-picks - +1 for uploading that. For g-s-d I would prefer to wait for it to be more firm upstream, especially with regard to the naming. So I vote for waiting until it's committed there. It might be helpful/useful/necessary for that to hang out on #control-ce

[Desktop-packages] [Bug 1756006] Re: FFe: Support suspend-to-hibernate

2018-04-02 Thread Mario Limonciello
The rename is done upstream, it's now suspend-then-hibernate. I'm uploading systemd with these patches. As for G-S-D, I've adjusted it for the rename too but it's still waiting to be merged. ** Changed in: systemd (Ubuntu) Status: New => Fix Committed ** Summary changed: - FFe: Support

Re: [Desktop-packages] [Bug 1756006] Re: FFe: Support suspend-to-hibernate

2018-03-28 Thread Mario Limonciello
Gsd is pushing for the name change in systemd, so I'm going to get that upstreamed before bringing this into Ubuntu. (Suspend to hibernate to suspend then hibernate). In terms of UI where would it Land? I figure it should be a policy setting on systems that ship with it, but you're probably right