I have posted a bug #1744496 in which I explain that on elementary OS
6.0 Odin the corners are still square. It seems on elementary OS `-moz-
window-titlebar` doesn't work. `-moz-gtk-csd-titlebar-radius` does work,
as you can see when the dark theme is enabled. Can anyone look at this
bug?
--
Bug 1745419 will fix that.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1871644
Title:
Top corners of Firefox windows have weird black protrusions from the
rounded edges
Status
Thanks! Then I will set the flags accordingly.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1871644
Title:
Top corners of Firefox windows have weird black protrusions from the
Created attachment 9254735
dim corners.png
Verified on 96.0a1 and 97.0a1 that the top side is rounded and look good
on Wayland session under Ubuntu 20.04. Although while getting the
notification to make Firefox as default, a dim effect is active and the
rounded parts have corners because of that
== Change summary for alert #32637 (as of Mon, 06 Dec 2021 09:45:12 GMT) ==
### Improvements:
| **Ratio** | **Test** | **Platform** | **Options** | **Absolute values (old vs
new)**|
|--|--|--|--|--|
| 5% |
[tresize](https://firefox-source-docs.mozilla.org/testing/perfdocs/talos.html#tresize)
** Changed in: firefox
Status: Confirmed => Fix Released
** Bug watch added: Mozilla Bugzilla #1743981
https://bugzilla.mozilla.org/show_bug.cgi?id=1743981
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://hg.mozilla.org/mozilla-central/rev/eb8c23dda78d
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1871644
Title:
Top corners of Firefox windows have weird black protrusions from
(In reply to Emilio Cobos Álvarez (:emilio) from comment #49)
> (In reply to gschram from comment #47)
> > I understand that this is an edge case currently (with the patched mutter)
> > but I foresee this becoming a "problem" when in a year or two all other
> > apps also have rounded bottom
(In reply to gschram from comment #47)
> I understand that this is an edge case currently (with the patched mutter)
> but I foresee this becoming a "problem" when in a year or two all other apps
> also have rounded bottom corners and Firefox is the odd one out, I think
> fixing this now is a
Pushed by ealva...@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/eb8c23dda78d
Use titlebar radius on Linux and make titlebar set-up work for lightweight
themes. r=stransky,dao
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed
I have just tested the latest nightly on Fedora 35 and it works
perfectly for XWayland, however, when running Wayland the bottom corners
are still not rounded and the top corners are rounded but still have a
weird (barely noticeable unless you know) transparent sharp corner. Note
that I am running
*** Bug 1673079 has been marked as a duplicate of this bug. ***
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1871644
Title:
Top corners of Firefox windows have weird black
So, querying the individual border-radius properties doesn't work. I
get:
> (firefox:17330): Gtk-WARNING **: 00:39:54.651: Style property "border-
top-left-radius" is not gettable
And same for the other corners of course. However, my patch works,
because of [this
Created attachment 9246335
titlebar CSS rounded borders properties
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1871644
Title:
Top corners of Firefox windows have weird black
https://hg.mozilla.org/mozilla-central/rev/257c4f510cfd
https://hg.mozilla.org/mozilla-central/rev/a1e159fd2136
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1871644
Title:
Top
https://hg.mozilla.org/mozilla-central/rev/81ca2d28c253
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1871644
Title:
Top corners of Firefox windows have weird black protrusions from
(In reply to Emilio Cobos Álvarez (:emilio) from comment #30)
> So given there's no way to access the other border corners, and that this
> works for our purposes, I think we should probably just roll with it,
> thoughts?
I'd agree - should work well for almost everyone.
One question I had to
btw. It would be great to get border-radius from menu elements (Adwaita
uses it) and use it in gecko too, for context menus for instance. But
that may be a different bug.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
Pushed by ealva...@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/257c4f510cfd
Add support for chrome-only environment variables. r=stransky
https://hg.mozilla.org/integration/autoland/rev/a1e159fd2136
Expose titlebar radius as a chrome-only CSS environment variable. r=stransky
--
Okay, fair enough.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1871644
Title:
Top corners of Firefox windows have weird black protrusions from the
rounded edges
Status in
Well, perhaps, but that seems tangential to this bug, isn't it? We don't
use XShapeCombineMask for the titlebar and this patch stack doesn't
start doing that.
If we do want to do the cleanup described above, we might need a new
media query which determines this (but it should definitely not have
Pushed by ealva...@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c9399923df7b
Remove -moz-gtk-csd-transparent-background.
r=stransky,desktop-theme-reviewers,dao
https://hg.mozilla.org/integration/autoland/rev/bcdfe3daf980
Use a more precise toolbar radius. r=stransky
--
You
(In reply to Emilio Cobos Álvarez (:emilio) from comment #26)
> If we do want to do the cleanup described above, we might need a new media
> query which determines this (but it should definitely not have `csd` in the
> name, since it is not about csd at all). So I'd rather clean up the existing
Emilio, I tested the patches and it looks great!
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1871644
Title:
Top corners of Firefox windows have weird black protrusions from the
Yeah, so `nsWindow::GetTitlebarRadius` can be called off the main thread
which seems unfortunate. We can fix this easily by moving the titlebar
radius to a member or such.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in
We have a technical debt here as we don't use titlebar rendering in
testsuite - I'll look at it.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1871644
Title:
Top corners of Firefox
Oh, great, let me know if I can help. Probably a static atomic integer
in nsLookAndFeelGtk is slightly easier to invalidate in practice.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://hg.mozilla.org/mozilla-central/rev/c9399923df7b
https://hg.mozilla.org/mozilla-central/rev/bcdfe3daf980
https://hg.mozilla.org/mozilla-central/rev/2be88317a6c0
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
(In reply to Emilio Cobos Álvarez (:emilio) from comment #43)
> Yeah, so `nsWindow::GetTitlebarRadius` can be called off the main thread
> which seems unfortunate. We can fix this easily by moving the titlebar radius
> to a member or such.
I can fix that as a part of Bug 1736518.
--
You
Emilio, when running testsuite with the patch (locally) I'm getting this
crash:
2:05.41 GECKO(53217) Assertion failure: sInServoTraversal || NS_IsMainThread(),
at /home/komat/src/objdir-opt/dist/include/mozilla/ServoUtils.h:33
2:05.41 GECKO(53217) #01:
May nsWindow::GetTitlebarRadius() be called from render thread? (this is
sw-wr).
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1871644
Title:
Top corners of Firefox windows have
Pushed by emi...@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/2be88317a6c0
Fix rebase mistake.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1871644
Title:
Top corners
I fixed the wayland overdraw and the X11 artifacts, so I think this is
ready to go. I've tested this stack on KWin and GNOME, both X11 and
Wayland. Will test i3 and such asap.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in
(In reply to Darkspirit from comment #19)
> KDE with disabled compositor, i3, etc. use alpha visual, but it's not
> transparent.
WDYM, just that the background wouldn't be transparent?
> Could -moz-gtk-csd-transparent-background be defined with
> gdk_screen_is_composited()
> and be used to
(In reply to Emilio Cobos Álvarez (:emilio) from comment #20)
Non-composited X11 (the legacy variant of X11: i3, KDE with manually disabled
compositor, etc.) does not support transparency. Everything that would usually
be transparent/alpha is just black/opaque. Menus and window corners had
Created attachment 9246314
Bug 1509931 - Use a more precise toolbar radius. r=stransky
This seemed possible/maybe worth doing, but let me know if you'd rather
keep the 10 hard-coded.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to
Pushed by ealva...@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/81ca2d28c253
Simplify titlebar buttons CSS. r=desktop-theme-reviewers,dao
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
(In reply to Emilio Cobos Álvarez (:emilio) from comment #17)
> Created attachment 9246290
> Bug 1509931 - Remove -moz-gtk-csd-transparent-background. r=stransky
>
>
> We always use alpha visual for WebRender
KDE with disabled compositor, i3, etc. use alpha visual, but it's not
transparent.
Ah, I think I know why that might be...
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1871644
Title:
Top corners of Firefox windows have weird black protrusions from the
rounded
Created attachment 9246291
Bug 1509931 - Simplify titlebar buttons CSS. r=stransky
There's no need to use the media query to set the default styles of the
buttons, we only need to hide them if appropriate.
Depends on D128682
--
You received this bug notification because you are a member of
Created attachment 9246288
Bug 1509931 - Expose titlebar radius as a chrome-only CSS environment variable.
r=stransky
Mostly plumbing.
Depends on D128679
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
Created attachment 9246290
Bug 1509931 - Remove -moz-gtk-csd-transparent-background. r=stransky
We always use alpha visual for WebRender, and appearance: none is
unnecessary (root element has no intrinsic appearance).
Depends on D128681
--
You received this bug notification because you are a
(In reply to Martin Stránský [:stransky] (ni? me) from comment #11)
> Emilio, how is the best way how to do it? We can introduce a new appearance
> (-moz-window-titlebar-alpha for instance) which contains only alpha component
> from titlebar and paint it over theme color or use existing one
>
Created attachment 9246289
Bug 1509931 - Use titlebar radius on Linux and make titlebar set-up work for
lightweight themes. r=stransky!,dao!
Depends on D128680
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
Created attachment 9246287
Bug 1509931 - Add support for chrome-only environment variables. r=stransky
This bit is taken straight from D73454 (I reviewed it but I guess
another pair of eyes is ok, it's really straight-forward).
Co-authored-by: Nicklas Boman
--
You received this bug
*** Bug 1706752 has been marked as a duplicate of this bug. ***
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1871644
Title:
Top corners of Firefox windows have weird black
Emilio, you're absolutely right :) There's original Bug 1408360 for it.
For custom themes we need to apply alpha component only and keep
original color from theme (i.e. paint over alpha from theme).
Emilio, how is the best way how to do it? We can introduce a new
appearance
Wayland case seems to be a bit special as it produces gray corner even with Gtk
theme (which works OK on X11/Alpha).
We may want to draw alpha over corners when custom theme is used and main
window is not maximized or tiled.
--
You received this bug notification because you are a member of
Thanks emilio, that's a good hint. The comment says
> It may cause performance issues so let's put it under a preference and enable
> it for desktop environment which do that by default.
This is clearly outdated and from a pre Webrender time.
--
You received this bug notification because you
I'm not quite familiar with how this works, I think Martin is the right
person to ask about it.
I can dig if you want but I'd guess that this kind of stuff (the
`:not(:-moz-lwtheme)` bits and such) is related:
https://searchfox.org/mozilla-
This just became even more prominent in 95 with colorways. We need a way
to support this with alpha visuals as XShape is neither available on
Wayland nor on X11 with HW Webrender - i.e. it's only available in
legacy fallback paths. As the default theme supports this (even though
with a grey
I can confirm this issue still exists in Fedora 34, Firefox 89, Wayland.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1871644
Title:
Top corners of Firefox windows have weird black
** Changed in: firefox
Status: New => Confirmed
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1871644
Title:
Top corners of Firefox windows have weird black protrusions from
Thanks but it's a minor cosmetic issue and not impacting our default
session so we don't consider it as a release issue, tagging rls-ff-
notfixing
** Tags removed: champagne
** Tags added: rls-ff-notfixing
--
You received this bug notification because you are a member of Desktop
Packages, which
Launchpad has imported 6 comments from the remote bug at
https://bugzilla.mozilla.org/show_bug.cgi?id=1509931.
If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
** Attachment added: "with separate menu bar"
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1871644/+attachment/5349702/+files/firefox-csdbug-separate-menubar.png
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in
This is specific to the unification of the menu-bar into the title-bar
through client-side decorations. I am about to attach two more
screenshots that show the difference when the unification is disabled vs
the default.
** Attachment added: "with menubar in title bar"
I'm seeing a similar artifact in top corners of firefox windows under
wayland, although it looks more transparent in my focal VM. But it's not
present under X11.
** Changed in: firefox (Ubuntu)
Status: New => Confirmed
** Bug watch added: Mozilla Bugzilla #1509931
I'm also seeing the pattern when logged-into X11 (note there is a
difference in the image because in Wayland I have the monitor set to
200% scaling while in X11 it is set to 100%, so the images have
different numbers of pixies for the bug)
** Attachment added: "top-right corner of a Firefox
Public bug reported:
Image to illustrate the problem is attached. All firefox windows on
Wayland have a weird black protrusion from the top-left and top-right
corners where yaru has curved the window corners, but something from
Firefox appears to not be being clipped by the theme. I need to
60 matches
Mail list logo
