** Description changed: - > If the upload is a new upstream microrelease, the relevant part of the - upstream changelog and/or release notes + [ Impact ] - Upstream commit: https://github.com/tseliot/ubuntu-drivers- - common/commit/a7d2d39805e995ed0e655de123b4bb6cff4e6434 + * In NVIDIA new GPU release cycle, NVIDIA ships their new GPUs to + OEM/ODM for production. - > An explanation of the testing which has been performed on the new - version in Ubuntu, including verification that the new package: + In the meantime, NVIDIA usually notify OEM/ODM/Canonical (under NDA) to + use a specific nvidia version to development/production. - For this feature which only impact if the target system has a custom + NVIDIA and OEN/ODM will announce the next generation combination at the + same time usually when the factory ready to ship the product. + + We made Ubuntu as a leading distribution supports many cutting edge + devices, it's time to have an official way to make the nvidia + installation consistent in unannounced (yet) nvidia devices to support + OEM/ODM factory shipment for our growing counterparts. + + [ Test Plan ] + + * For this feature which only impact if the target system has a custom file "/etc/custom_supported_gpus.json" If the file presents, it will effect packages_for_modalias() and _is_runtimepm_supported(). Both functions are important when "ubuntu- driver install" a nvidia driver. For installing nvidia driver, u-d-c has several test in autopkgtest which contains: * different branch type: LTS/PB/NFB/Legacy.. - * different version type: 390/470/495/510.. + * different version type: 390/470/495/510/520/525.. * For this particular feature, we created a new autopkgtest test_system_driver_packages_force_install_nvidia() which not only secure this FFE but each version bump. which contains: - 1. Normal case (Stock ubuntu), without /etc/customized_supported_gpus.json in the system. + 1. Normal case (Stock ubuntu), without /etc/custom_supported_gpus.json in the system. 2. If /etc/custom_supported_gpus.json contains incorrect json field / format. 3. /etc/custom_supported_gpus.json point to the older version than candidate. 4. /etc/custom_supported_gpus.json point to the same version than candidate. 5. /etc/custom_supported_gpus.json point to a non-exist version of ubuntu-archive (source list). and you can see from "buildlog" attachment, all passed as well as "test_system_driver_packages_force_install_nvidia()" Refer https://github.com/tseliot/ubuntu-drivers-common/pull/71 for more details. - > state the reason why you feel it is necessary (other bugs it fixes, - etc.) - - related bug: https://bugs.launchpad.net/ubuntu/+bug/1 - - In NVIDIA new GPU release cycle, NVIDIA ships their new GPUs to OEM/ODM for production. - In the meantime, NVIDIA usually notify OEM/ODM/Canonical (under NDA) to use a specific nvidia version to development/production. - - NVIDIA and OEN/ODM will announce the next generation combination at the - same time usually when the factory ready to ship the product. - - We made Ubuntu as a leading distribution supports many cutting edge - devices, it's time to have an official way to make the nvidia - installation consistent in unannounced (yet) nvidia devices to support - OEM/ODM factory shipment for our growing counterparts. - - > attach (as files) - > diff of the Upstream ChangeLog (not debian/changelog) - > diff -u <package>-{old-version,new-version}/ChangeLog > changelog.diff - note that the ChangeLog sometimes is called CHANGES, is missing or the tarball merely has a NEWS file. - > the NEWS file, if you think that this information helps reviewing your request (true for most gnome packages) - - N/A, FWIK, u-d-c hasn't an official release note something like "NEWS" - - > build log (as file) - - Please refer the attachment "buildlog" - - > install log - - Please refer the attachment "installlog" - - > mention what testing you've done to see that it works + * Steps to make sure it works: 1. pick a cutting edge nvidia graphic. 2. remove nv-525 from the pool. 3. add ppa, apt update and reboot. 4. check the nv support status: ``` $ ubuntu-drivers list oem-fix-gfx-nvidia-ondemandmode libfprint-2-tod1-broadcom oem-somerville-cinccino-meta ``` 5. modify custom file ``` $ cat /etc/custom_supported_gpus.json { "chips": [ { "devid": "0x24BA", "name": "TEST 24BA", "branch": "580.1234", "features": [ "runtimepm" ] }, { "devid": "0x25BC", "name": "TEST 25BC", "branch": "510", "features": [ "runtimepm" ] } ] } ``` 6. make sure the hook works ``` $ ubuntu-drivers list nvidia-driver-510, (kernel modules provided by nvidia-dkms-510) oem-fix-gfx-nvidia-ondemandmode libfprint-2-tod1-broadcom oem-somerville-cinccino-meta - ``` - P.S. also tried: - 1. wrong json format and it shows "DEBUG:root:package_get_nv_allowing_driver(): unexpected json detected." when enables the verbose. - 2. try non exist nv driver (e.g. 525, has been remove from the pool) and it shows "DEBUG:root:nvidia-driver-525 is not in the package pool." - The instruction won't return failed but just do nothing from the hook. + [ Where problems could occur ] - > subscribe (do not assign to) the 'ubuntu-release' team. + * Think about what the upload changes in the software. Imagine the change is + wrong or breaks something else: how would this show up? - Done + * It is assumed that any SRU candidate patch is well-tested before + upload and has a low overall risk of regression, but it's important + to make the effort to think about what ''could'' happen in the + event of a regression. - --- + * This must '''never''' be "None" or "Low", or entirely an argument as to why + your upload is low risk. - [Additional information] - * Jammy MP: https://github.com/tseliot/ubuntu-drivers-common/pull/81 - * Test PPA: https://launchpad.net/~os369510/+archive/ubuntu/lp1990341 + * This both shows the SRU team that the risks have been considered, + and provides guidance to testers in regression-testing the SRU. + + [ Other Info ] + + * Upstream commit: https://github.com/tseliot/ubuntu-drivers-common/commit/a7d2d39805e995ed0e655de123b4bb6cff4e6434 + + * Jammy MP: https://github.com/tseliot/ubuntu-drivers-common/pull/81 + + * Test PPA: https://launchpad.net/~os369510/+archive/ubuntu/lp1990341 + + * build log (as file) + Please refer the attachment "buildlog" + + * install log + Please refer the attachment "installlog"
** Summary changed: - [Draft][SRU] Support to install nvidia driver by allowing list + [SRU] Support to install nvidia driver by allowing list -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to ubuntu-drivers-common in Ubuntu. https://bugs.launchpad.net/bugs/1990341 Title: [SRU] Support to install nvidia driver by allowing list Status in OEM Priority Project: Confirmed Status in ubuntu-drivers-common package in Ubuntu: Incomplete Bug description: [ Impact ] * In NVIDIA new GPU release cycle, NVIDIA ships their new GPUs to OEM/ODM for production. In the meantime, NVIDIA usually notify OEM/ODM/Canonical (under NDA) to use a specific nvidia version to development/production. NVIDIA and OEN/ODM will announce the next generation combination at the same time usually when the factory ready to ship the product. We made Ubuntu as a leading distribution supports many cutting edge devices, it's time to have an official way to make the nvidia installation consistent in unannounced (yet) nvidia devices to support OEM/ODM factory shipment for our growing counterparts. [ Test Plan ] * For this feature which only impact if the target system has a custom file "/etc/custom_supported_gpus.json" If the file presents, it will effect packages_for_modalias() and _is_runtimepm_supported(). Both functions are important when "ubuntu- driver install" a nvidia driver. For installing nvidia driver, u-d-c has several test in autopkgtest which contains: * different branch type: LTS/PB/NFB/Legacy.. * different version type: 390/470/495/510/520/525.. * For this particular feature, we created a new autopkgtest test_system_driver_packages_force_install_nvidia() which not only secure this FFE but each version bump. which contains: 1. Normal case (Stock ubuntu), without /etc/custom_supported_gpus.json in the system. 2. If /etc/custom_supported_gpus.json contains incorrect json field / format. 3. /etc/custom_supported_gpus.json point to the older version than candidate. 4. /etc/custom_supported_gpus.json point to the same version than candidate. 5. /etc/custom_supported_gpus.json point to a non-exist version of ubuntu-archive (source list). and you can see from "buildlog" attachment, all passed as well as "test_system_driver_packages_force_install_nvidia()" Refer https://github.com/tseliot/ubuntu-drivers-common/pull/71 for more details. * Steps to make sure it works: 1. pick a cutting edge nvidia graphic. 2. remove nv-525 from the pool. 3. add ppa, apt update and reboot. 4. check the nv support status: ``` $ ubuntu-drivers list oem-fix-gfx-nvidia-ondemandmode libfprint-2-tod1-broadcom oem-somerville-cinccino-meta ``` 5. modify custom file ``` $ cat /etc/custom_supported_gpus.json { "chips": [ { "devid": "0x24BA", "name": "TEST 24BA", "branch": "580.1234", "features": [ "runtimepm" ] }, { "devid": "0x25BC", "name": "TEST 25BC", "branch": "510", "features": [ "runtimepm" ] } ] } ``` 6. make sure the hook works ``` $ ubuntu-drivers list nvidia-driver-510, (kernel modules provided by nvidia-dkms-510) oem-fix-gfx-nvidia-ondemandmode libfprint-2-tod1-broadcom oem-somerville-cinccino-meta [ Where problems could occur ] * Think about what the upload changes in the software. Imagine the change is wrong or breaks something else: how would this show up? * It is assumed that any SRU candidate patch is well-tested before upload and has a low overall risk of regression, but it's important to make the effort to think about what ''could'' happen in the event of a regression. * This must '''never''' be "None" or "Low", or entirely an argument as to why your upload is low risk. * This both shows the SRU team that the risks have been considered, and provides guidance to testers in regression-testing the SRU. [ Other Info ] * Upstream commit: https://github.com/tseliot/ubuntu-drivers-common/commit/a7d2d39805e995ed0e655de123b4bb6cff4e6434 * Jammy MP: https://github.com/tseliot/ubuntu-drivers-common/pull/81 * Test PPA: https://launchpad.net/~os369510/+archive/ubuntu/lp1990341 * build log (as file) Please refer the attachment "buildlog" * install log Please refer the attachment "installlog" To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1990341/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
