Upstream bug closed "RESOLVED FIXED" on 2016-09-09
Display periods changed. "Last week" removed.
Fix targetted for Thunderbird 51
Tested ok using Ubuntu 18.04 and Thunderbird 60.2.1
Closing by marking "Fix released"
** Changed in: thunderbird (Ubuntu)
Status: Triaged => Fix Released
--
** Changed in: thunderbird
Status: Confirmed => Fix Released
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/237341
Title:
mozilla-thunderbird locates 2/6/2008 as last week
What we are seeing with TB 31.4.0 is this:
Today is Friday but Last week starts 7 days ago. That label should be This
Week.
Today is Friday but Last 2 week starts 14 days ago. That label should be
Last Week.
Willing to test fix when a fix is available.
--
You received this bug notification
Can this be pushed to upstream repository? I'm quite surprised to learn
that it has not been addressed for almost 5 years.
(In reply to Jim Porter (:squib) from comment #35)
Comment on attachment 8355581
lastWeek2.diff
r- for now since we want to use a pref to handle the start-of-week.
--
Yeah, let's do the pref. That should be a reasonable workaround, and
when bug 333938 is fixed, we can just switch over to that and everyone's
happy.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
Comment on attachment 8355581
lastWeek2.diff
r- for now since we want to use a pref to handle the start-of-week.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/237341
Title:
This bug has stalled because, I seem not to be able to get any real direct
help, without infinite referrals, for 333938.
So, I'll opt for and take a stab at moving the pref, and hopefully make some
headway.
--
You received this bug notification because you are a member of Desktop
Packages,
I think before we do much with this bug, we either need to fix bug
333938 or at least move the calendar.week.start pref to Thunderbird.
If we do the latter, we should write some migration code so that we copy
over the old pref value to the new pref.
--
You received this bug notification because
Created attachment 8355581
lastWeek2.diff
fix bucket groups to be based off of a calendar week concept.
pull firstDayOfWeek bias from lightning prefs if available.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
Comment on attachment 8337339
fix bucket groups to be based off of a calendar week concept
Sorry for the delay. The code seems reasonable but this needs to have
ui-review before I can review it properly.
+// TODO - in the calculation for thisWeek, the + 0 should be based of off
+// the
Indeed, there is bug 164495 for calendar. What you want to fix first is
bug 333938 though. This will allow Lightning/Thunderbird to access the
locale info. I'm not sure the first day of the week is available on all
platforms, but from skimming that bug it seems windows has an API call
for it and
(In reply to Jim Porter (:squib) from comment #26)
It might be useful to add
support to Gecko to pull this in from the OS; that could be useful for HTML5
forms as well.
Absolutely! It's increasingly annoying to get wrong start of week. Bug
164495 for calendar.
--
You received this bug
Comment on attachment 8337301
fix bucket groups to be based off of a calendar week concept
Review of attachment 8337301:
-
This isn't a full review; just a quick pass. David Bienvenu is unlikely
to be super-response, since I believe
Oh, I should explain more about localization: you're not responsible for
updating any of the strings except for en-US. Dedicated localizers will
come in and update them for all the other locales. However, if we change
the meaning of any string in the code, we generally need to change the
name of
Created attachment 8337339
fix bucket groups to be based off of a calendar week concept
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/237341
Title:
mozilla-thunderbird locates
Ok, I looked into the issue of how to determine the first day of the
week. There's a localization file here, used for the datepicker[1] and
there's also a pref in Lightning[2]. I'm pretty sure most OSes also
specify this somewhere, but we don't detect that. I'm CCing one of the
Lightning devs so
ha, that is funny!
I've been hunting through the UI and code base to find this info, and I
literally just finished a build with preliminary support to pull in the
calendar.week.start preference, after which I started it up to find a new email
with your last comment.
I do think that getting
Comment on attachment 8337301
fix bucket groups to be based off of a calendar week concept
I'm attaching an updated patch to address review comments by :squib
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
Yeah, uncle, after further testing, the time zone adjustments go back
in...
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/237341
Title:
mozilla-thunderbird locates 2/6/2008 as
Created attachment 8337301
fix bucket groups to be based off of a calendar week concept
Attached is a first attempt patch to address this bug.
It aligns the buckets yesterday to week boundaries, and adds a lastWeek
bucket.
I need information on where to get the beginning of calendar week
Thanks for the comments.
(In reply to Jim Porter (:squib) from comment #20)
Comment on attachment 8337301
fix bucket groups to be based off of a calendar week concept
Review of attachment 8337301:
-
This isn't a full review;
*** Bug 941197 has been marked as a duplicate of this bug. ***
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/237341
Title:
mozilla-thunderbird locates 2/6/2008 as last week in
22 matches
Mail list logo
