Upstream bug closed "RESOLVED FIXED" on 2014-06-24
Target release - Firefox 33
Seems ok here using Ubuntu 18.04 and Firefox 63
Marking "Fix Released" to close
** Changed in: firefox (Ubuntu)
Status: Confirmed => Fix Released
--
You received this bug notification because you are a member
I don't understand how it is a bug. This is what screensaver is meant to
do: Hide your programs and Firefox is a program. I don't see why I can't
have video running and screensaver working at the same time. Please
respect what I have manually set in the system (screensaver after one
hour) and
(In reply to electrovalent from comment #88)
Hi, i can see this is marked as fixed but i can confirm that on latest
xubuntu and latest debian testing, firefox 35.01 is not able to disable
screensaver or screen power management.
Ditto. I just reinstalled Ubuntu Studio 14.04 and installed Unity,
Hi, i can see this is marked as fixed but i can confirm that on latest
xubuntu and latest debian testing, firefox 35.01 is not able to disable
screensaver or screen power management.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to
** No longer affects: firefox-3.5 (Ubuntu)
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/434476
Title:
screensaver starts while playing HTML5 videos
Status in The Mozilla Firefox
(In reply to Sergey Kondakov from comment #86)
2) GNOME screensaver requires the core GNOME framework to go with it, not
just GTK. Kinda overkill for a screensaver.
Scratch that ! I just read up on:
http://www.jwz.org/blog/2011/10/has-gnome-3-decided-that-people-shouldnt-want-screen-savers/
(In reply to Milan Bouchet-Valat from comment #84)
Is that supposed to work when watching a fullscreen Flash video, like
Youtube? It doesn't here on Fedora 20 with Firefox 33 (and the D-Bus
interface is present).
No.
--
You received this bug notification because you are a member of Desktop
(In reply to Bastien Nocera from comment #83)
I'll add that xdg-screensaver is an unmitigated piece of . It
reimplements the bugs that using D-Bus for inhibition is supposed to fix
(namely that if the app disappears, the screensaver shouldn't be left
inhibited).
Mh, yeah, it's odd that it
(In reply to Bastien Nocera from comment #80)
It's not dbus xscreensaver interface support. It has nothing to do with
XScreensaver.
Ah, just noticed ancient https://bugs.debian.org/cgi-
bin/bugreport.cgi?bug=377056
XScreensaver implements no D-Bus interface. The D-Bus interface should work
(In reply to Sergey Kondakov from comment #81)
So now one has to use those abominations just to have a screensaver ? Then
`xdg-screensaver` abstraction should have, probably, been used instead of
direct dbus calls. It supports both dbus and console commands.
Otherwise
I'll add that xdg-screensaver is an unmitigated piece of crap. It
reimplements the bugs that using D-Bus for inhibition is supposed to fix
(namely that if the app disappears, the screensaver shouldn't be left
inhibited).
You could add D-Bus support to xscreensaver without linking to a D-Bus
Is that supposed to work when watching a fullscreen Flash video, like
Youtube? It doesn't here on Fedora 20 with Firefox 33 (and the D-Bus
interface is present).
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
** Bug watch added: Debian Bug tracker #377056
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=377056
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/434476
Title:
screensaver
Sergey, could you check whether with the S3 add-on disabled the
screensaver is still not inhibited?
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/434476
Title:
screensaver starts
Doesn't seem to be fixed in Firefox 33 on OpenSuse 13.1 with KDE4
XScreenSaver-5.29 (not KDE's one): xscreensaver still sprungs up while
playing fullscreen video on Youtube. May be a result of using Download
Manager (S3) addon which draws a bar at the bottom that disappear
slightly after video
(In reply to Sergey Kondakov from comment #79)
(In reply to Milan Bouchet-Valat from comment #78)
Sergey, could you check whether with the S3 add-on disabled the screensaver
is still not inhibited?
It's that way even with almost empty profile and safe mode. I also noticed
that VLC-2.1.5
(In reply to Milan Bouchet-Valat from comment #78)
Sergey, could you check whether with the S3 add-on disabled the screensaver
is still not inhibited?
It's that way even with almost empty profile and safe mode. I also
noticed that VLC-2.1.5 doesn't inhibit it also even thought it
supposedly got
** Bug watch added: VLC Trac #4739
http://trac.videolan.org/vlc/ticket/4739
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/434476
Title:
screensaver starts while playing HTML5
Removing qe-verify+ since it seems we cannot verify this.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/434476
Title:
screensaver starts while playing HTML5 videos
Status in The
On Ubuntu 14.04 I have org.gnome.SessionManager but the screensaver still
enters.
Based on previous comments it appears that the fix is working for
gnome-screensaver 2.30 but that version of gnome-screensaver is pretty old(
from September 2010). It appears that the fix is not working for Gnome
For instance I see only org.mate.ScreenSaver interface on
Fedora20/MATE desktop. So the problem may be here.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/434476
Title:
screensaver
It works for me with gnome-screensaver 2.30, firefox nightly 2014-08-30,
both with and without fullscreen. Sometimes screensaver stiil appears
after ~ 25 minutes of video (but it's configured to get activated after
2 minutes), so it's another problem.
--
You received this bug notification
The patch utilizes the org.freedesktop.ScreenSaver or
org.gnome.SessionManager D-BUS interfaces so it depends if you have such
services enabled or not and if your screen saver listen here.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to
Check d-feet (#yum install d-feet.noarch in Fedora) to inspect your
active dbus interfaces.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/434476
Title:
screensaver starts while
So this does not appear to work on Ubuntu and Fedora. Can anyone shed
some light on the test results from comment 69 and what is actually
expected here? Otherwise we'll just have to reopen this as it does not
seem to do anything.
--
You received this bug notification because you are a member of
I've tested this using Ubuntu 14.04 x64 and FF 33d.0b1(BUild Id:
20140903133924).
The turn screen off enters on the set time(Ubuntu 14.04 doesn’t ship
with any screen savers, just a black screen that appears when your
system is idle) when playing a youtube video on fullscreen. The same is
Great!
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/434476
Title:
screensaver starts while playing HTML5 videos
Status in The Mozilla Firefox Browser:
Fix Released
Status in
https://hg.mozilla.org/mozilla-central/rev/38476bd45285
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/434476
Title:
screensaver starts while playing HTML5 videos
Status in The
** Changed in: firefox
Status: Confirmed = Fix Released
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/434476
Title:
screensaver starts while playing HTML5 videos
Status in
https://hg.mozilla.org/integration/mozilla-inbound/rev/38476bd45285
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/434476
Title:
screensaver starts while playing HTML5 videos
Status
Comment on attachment 8442071
patch v.5
Try: https://tbpl.mozilla.org/?tree=Tryrev=ae11997b18f8
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/434476
Title:
screensaver starts while
We want to inhibit the screensaver when video is playing, not when
*fullscreen* video is playing. It looks like the patch above is trying
to only inhibit the screensaver for fullscreen video.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed
(In reply to Chris Pearce (:cpearce) from comment #58)
We want to inhibit the screensaver when video is playing,
I assume the screen wake lock is meant to take care of that.
http://hg.mozilla.org/mozilla-central/annotate/37f08ddaea48/content/html/content/src/HTMLVideoElement.cpp#l312
--
You
I think you want the screen topic, and the locked-foreground state
to denote when to disable the screen saver.
HTMLMediaElement should already manage only disabling the screen saver
when media is playing and in a foreground tab, and bug 1022669 is being
worked on right now to ensure that we don't
This can be simplified considerably given we need only listen for the screen
lock.
The hash table is not necessary, and classes can probably be merged.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
(In reply to Martin Stránský from comment #53)
The screensaver should not be inhibited by cpu and high-priority wake
locks. It looks like those are used to inhibit GC or disable power save (see
Bug 872430).
This isn't an issue with wake lock code, it's an issue with wake locks
being used
Comment on attachment 8441363
patch v.4
The screen wake lock sounds good.
I suspect we shouldn't need DOM_Fullscreen, but I'm happy to let that by
because other platforms treat that similarly.
However, we now know that the Screensaver is already inhibited
assertion can fail, so that needs to be
(In reply to Edwin Flores [:eflores] [:edwin] from comment #57)
(In reply to Martin Stránský from comment #53)
The screensaver should not be inhibited by cpu and high-priority wake
locks. It looks like those are used to inhibit GC or disable power save (see
Bug 872430).
This isn't an
Comment on attachment 8442071
patch v.5
This could be much simpler, but let's not hold off this feature any longer.
Tidying up can be a followup.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
Created attachment 8442071
patch v.5
Something like that? It listens to screen locks only and returns when
screensaver is already inhibited.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
The screensaver should not be inhibited by cpu and high-priority
wake locks. It looks like those are used to inhibit GC or disable power
save (see Bug 872430).
I've found two screen related wake locks - DOM_Fullscreen (Bug 805017)
and screen (Bug 868325). I think any element which wants to
Created attachment 8441363
patch v.4
I watches DOM_Fullscreen and screen wakelocks only.
Passes the broken test:
./mach mochitest-plain dom/browser-element/mochitest/priority
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in
Comment on attachment 8441363
patch v.4
Try build: https://tbpl.mozilla.org/?tree=Tryrev=e2e2ba6d85b8
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/434476
Title:
screensaver starts
Because opinions differ. ;)
We also want non-fullscreen video and webrtc chats to disable the
screensaver. I, for one, find it very annoying when I'm watching a non-
fullscreen video and the screensaver kicks in.
FYI, there's code in HTMLMediaElement to ensure the screensaver is only
disabled
IMHO we should only listen the DOM_Fullscreen wake lock topic. See
http://mxr.mozilla.org/mozilla-central/source/dom/base/nsGlobalWindow.cpp#6024
Why has it been removed from the original patch?
--
You received this bug notification because you are a member of Desktop
Packages, which is
The assertions are due to changes from bug 870480.
I don't understand why they should have been necessary, but similarly with most
of the WakeLock behavior, so I guess widget code can deal with duplicate
notifications.
--
You received this bug notification because you are a member of Desktop
Are they cpu and high-priority wake locks inhibiting the screensaver?
That doesn't sound right.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/434476
Title:
screensaver starts while
Created attachment 8424975
Implement WakeLockListener on Linux to disable screensaver while video is
playing
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/434476
Title:
screensaver
Comment on attachment 8424975
Implement WakeLockListener on Linux to disable screensaver while video is
playing
Addressed One. Last. Review. Comment.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
Backed out in https://hg.mozilla.org/integration/mozilla-
inbound/rev/e2d6d80b8644 four four unexpected assertion failures in dom
/browser-element/mochitest/priority/test_HighPriority.html, e.g.
https://tbpl.mozilla.org/php/getParsedLog.php?id=39985786full=1branch
=mozilla-inbound#error0
--
You
https://hg.mozilla.org/integration/mozilla-inbound/rev/a5885f4bebdb
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/434476
Title:
screensaver starts while playing HTML5 videos
Status
Created attachment 8424521
Implement WakeLockListener on Linux to disable screensaver while video is
playing
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/434476
Title:
screensaver
Comment on attachment 8424521
Implement WakeLockListener on Linux to disable screensaver while video is
playing
+nsCOMPtrnsIDOMMozWakeLockListener WakeLockListener::sSingleton =
nullptr;
AFAIK compilers are not clever enough to avoid running a constructor for this
at startup, and so this should
(In reply to Karl Tomlinson (needinfo?:karlt) from comment #41)
+WakeLockTopic::UninhibitScreensaver()
+{
+ if (!mShouldInhibit) {
+// Screensaver isn't inhibited. Nothing to do here.
+return NS_OK;
Could this instead assert that this path is not reached, as in
Comment on attachment 8419908
Implement WakeLockListener on Linux to disable screensaver while video is
playing
+NS_IMPL_ISUPPORTS1(WakeLockListener, nsIDOMMozWakeLockListener)
Will need to remove the '1' here now.
+ dbus_pending_call_set_notify(reply, ReceiveInhibitReply, this,
NULL);
Created attachment 8419908
Implement WakeLockListener on Linux to disable screensaver while video is
playing
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/434476
Title:
screensaver
Comment on attachment 8419908
Implement WakeLockListener on Linux to disable screensaver while video is
playing
Addressed review comments.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
Comment on attachment 8415668
Implement WakeLockListener on Linux to disable screensaver while video is
playing
All the DBus callbacks should be happening on the main thread unless someone
calls dbus_connection_setup_with_g_main() with an off-main-thread
context, which would be scary. This
Comment on attachment 8415668
Implement WakeLockListener on Linux to disable screensaver while video is
playing
Review of attachment 8415668:
-
::: widget/gtk/WakeLockListener.cpp
@@ +154,5 @@
+}
+ case Unsupported:
+
Created attachment 8415668
Implement WakeLockListener on Linux to disable screensaver while video is
playing
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/434476
Title:
screensaver
Comment on attachment 8404230
Implement WakeLockListener on Linux to disable screensaver while video is
playing
The main thing missing here is appropriate handling of this situation:
After a InhibitScreenSaver() call, WakeLockListener::Callback() is called with
a non-locked-foreground state
(In reply to Karl Tomlinson (:karlt) from comment #30)
+LOCAL_INCLUDES += $(MOZ_DBUS_CFLAGS)
+CFLAGS += $(MOZ_DBUS_GLIB_CFLAGS)
+CXXFLAGS+= $(MOZ_DBUS_GLIB_CFLAGS) -DHAVE_PTHREADS
Which parts of previous reviews have not been addressed and why not?
Oops, totally missed
Created attachment 8404228
Implement WakeLockListener on Linux to disable screensaver while video is
playing
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/434476
Title:
screensaver
(In reply to Chris Pearce (:cpearce) from comment #29)
@@ +391,1 @@
return nsBaseAppShell::Init();
You should probably remove the listener during shutdown too.
Shouldn't be neccessary. The WakeLockListener doesn't depend on anything
else being alive, and as jlebar noted, it will be
Created attachment 8404230
Implement WakeLockListener on Linux to disable screensaver while video is
playing
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/434476
Title:
screensaver
Comment on attachment 8401684
Implement WakeLockListener on Linux to disable screensaver while video is
playing
Review of attachment 8401684:
-
This is the behaviour we want (locking video irrespective of whether
we're fullscreen
Comment on attachment 8401684
Implement WakeLockListener on Linux to disable screensaver while video is
playing
# User Edwin Flores eflo...@mozilla.com
I assume you built on Martin's patch here. Please include him as an
author.
+LOCAL_INCLUDES += $(MOZ_DBUS_CFLAGS)
+CFLAGS +=
Created attachment 8401684
Implement WakeLockListener on Linux to disable screensaver while video is
playing
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/434476
Title:
screensaver
** Bug watch added: Mozilla Bugzilla #811261
https://bugzilla.mozilla.org/show_bug.cgi?id=811261
** Changed in: firefox
Importance: Wishlist = Unknown
** Changed in: firefox
Status: Confirmed = Unknown
** Changed in: firefox
Remote watch: Mozilla Bugzilla #517870 = Mozilla
Launchpad has imported 28 comments from the remote bug at
https://bugzilla.mozilla.org/show_bug.cgi?id=811261.
If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
Status changed to 'Confirmed' because the bug affects multiple users.
** Changed in: firefox (Ubuntu)
Status: New = Confirmed
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
(In reply to Lawrence Mandel [:lmandel] from comment #40)
I discussed this issue with the desktop team (Chad, Madhava, Gavin). This is
not a high priority for them right now. As such, dropping the tracking flag.
From comment 36 I take it that this has already been fixed on Windows in
another
I discussed this issue with the desktop team (Chad, Madhava, Gavin).
This is not a high priority for them right now. As such, dropping the
tracking flag.
From comment 36 I take it that this has already been fixed on Windows in
another bug. (Bug ref?) If that is correct, are there other follow up
meanwhile, workaround:
media.ogg.enabled;false
media.opus.enabled;false
media.raw.enabled;false
media.webm.enabled;false
media.windows-media-foundation.enabled;false
media.directshow.enabled;false
media.navigator.enabled;false
media.autoplay.enabled;false
I agree with the importance of landing this fix since and so lets go
ahead and track this.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/434476
Title:
screensaver starts while
*** Bug 969796 has been marked as a duplicate of this bug. ***
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/434476
Title:
screensaver starts while playing HTML5 videos
Status in
The fix for this will ship on Windows in Firefox 30. Other platforms
hopefully will make by Firefox 30 or soon after.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/434476
Title:
There is workaround for people trying to find a permanent fix (like I
do). The program called HOT CORNERS works on both WinXP and Win7 (I
guess nobody is using Win8, at least the ones that know anything). You
set lower left corner (for example) as screensaver disabled and it
doesn't start.
--
(In reply to comment #31)
(In reply to :Ehsan Akhgari (needinfo? me!) (slow responsiveness,
emailacopolypse) from comment #29)
(In reply to comment #28)
We should disable the screen save for non-fullscreen playback too.
Why? Some websites use video as an element in their design these
We should disable the screen save for non-fullscreen playback too.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/434476
Title:
screensaver starts while playing HTML5 videos
Status
(In reply to :Ehsan Akhgari (needinfo? me!) (slow responsiveness,
emailacopolypse) from comment #29)
(In reply to comment #28)
We should disable the screen save for non-fullscreen playback too.
Why? Some websites use video as an element in their design these days
(for example, as the page
(In reply to comment #28)
We should disable the screen save for non-fullscreen playback too.
Why? Some websites use video as an element in their design these days
(for example, as the page background.) It seems counter intuitive for
such a website to disable the screen saver!
--
You received
Can we at least do that for videos which have started playback as a result
of a user action?
Agreed. I logged on to suggest just that but you beat me to it.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
(In reply to :Ehsan Akhgari (needinfo? me!) (slow responsiveness,
emailacopolypse) from comment #32)
Can we at least do that for videos which have started playback as a result
of a user action?
Sure, that sounds like a good idea. Reasonable even.
We may need to wait for bug 966493 to be fixed
We already use the power manager service to create a screen wake lock
to disable the screen saver in HTMLVideoElement::WakeLockUpdate(), but
the wake lock listener that actually disables the screen saver is only
implemented for B2G and I think Android, but not on other platforms.
I have a patch
More and more video playback is now HTML5-based, and with all the effort
to get rid of 3rd party plugins (also Flash), this would be a serious UX
improvement. I uninstalled Flash and the screensaver is sometimes
driving me nuts on YouTube.
Dummy keystrokes every 55s (see comment #10) sounds like
(In reply to Carsten from comment #26)
Dummy keystrokes every 55s (see comment #10) sounds like an elegant
cross-platform solution, no?
As this is open since 2009... time to take action? :-) Could any1 take this
up?
I think this is too much of a ad-hoc solution. It is easy to implement
I linked it to the current firefox package. maybe drop the bug for 3.5
as it is not supported anymore?
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/434476
Title:
screensaver starts
Still happens in saucy! Is this so hard to fix?
** Tags added: firefox saucy
** Also affects: firefox (Ubuntu)
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
89 matches
Mail list logo
