[Desktop-packages] [Bug 948788] Re: thunderbird crashed on launch

2013-04-18 Thread Bug Watch Updater
** Changed in: firefox Status: In Progress => Fix Released -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/948788 Title: thunderbird crashed on launch Status in The Mozilla Fir

[Desktop-packages] [Bug 948788]

2013-04-18 Thread Ryanvm
https://hg.mozilla.org/mozilla-central/rev/a5aa0a654611 -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/948788 Title: thunderbird crashed on launch Status in The Mozilla Firefox Brows

[Desktop-packages] [Bug 948788]

2013-04-17 Thread Vd-4
No problem, thank you! -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/948788 Title: thunderbird crashed on launch Status in The Mozilla Firefox Browser: In Progress Status in “atk1

[Desktop-packages] [Bug 948788]

2013-04-17 Thread Trevor Saunders
Comment on attachment 738132 Implement a replacement of atk_object_set_name() which mimics the behavior without calling atk_object_get_name() landed again, but forgot to qref -u sorry :( -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to

[Desktop-packages] [Bug 948788]

2013-04-17 Thread Trevor Saunders
remote: https://hg.mozilla.org/integration/mozilla- inbound/rev/a5aa0a654611 -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/948788 Title: thunderbird crashed on launch Status in Th

[Desktop-packages] [Bug 948788]

2013-04-17 Thread Vd-4
Created attachment 738132 Implement a replacement of atk_object_set_name() which mimics the behavior without calling atk_object_get_name() This is an updated patch that should fix the assertion failure. The only change compared to the pushed patch [1] is this: -+ if (newNameUTF8.Equals(aAtkObj-

[Desktop-packages] [Bug 948788]

2013-04-16 Thread Trevor Saunders
Comment on attachment 729066 Implement a replacement of atk_object_set_name() which mimics the behavior without calling atk_object_get_name() sorry it took me so long, but I finally got to test your patch today. It seems good so I checked it in for you ask you just saw :-) -- You received this

[Desktop-packages] [Bug 948788]

2013-04-16 Thread Trevor Saunders
remote: https://hg.mozilla.org/integration/mozilla- inbound/rev/ecd327272240 -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/948788 Title: thunderbird crashed on launch Status in Th

[Desktop-packages] [Bug 948788]

2013-04-16 Thread Philringnalda
Backed out in https://hg.mozilla.org/integration/mozilla- inbound/rev/369df88bbdbb for assertions like https://tbpl.mozilla.org/php/getParsedLog.php?id=21826076&tree=Mozilla- Inbound -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox

[Desktop-packages] [Bug 948788]

2013-03-26 Thread Vd-4
Created attachment 729066 Implement a replacement of atk_object_set_name() which mimics the behavior without calling atk_object_get_name() -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs

[Desktop-packages] [Bug 948788]

2013-03-26 Thread Vd-4
(In reply to Trevor Saunders (:tbsaunde) from comment #43) > Comment on attachment 728261 > Implement a replacement of atk_object_set_name() which mimics the behavior > without calling atk_object_get_name() > > >diff --git i/accessible/src/atk/AccessibleWrap.cpp > >w/accessible/src/atk/Accessible

[Desktop-packages] [Bug 948788]

2013-03-26 Thread Trevor Saunders
Comment on attachment 728261 Implement a replacement of atk_object_set_name() which mimics the behavior without calling atk_object_get_name() >diff --git i/accessible/src/atk/AccessibleWrap.cpp >w/accessible/src/atk/AccessibleWrap.cpp >index e35da5d..208e955 100644 >--- i/accessible/src/atk/Acce

[Desktop-packages] [Bug 948788]

2013-03-23 Thread Vd-4
Created attachment 728261 Implement a replacement of atk_object_set_name() which mimics the behavior without calling atk_object_get_name() -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs

[Desktop-packages] [Bug 948788]

2013-03-21 Thread Alexander Surkov
(In reply to Trevor Saunders (:tbsaunde) from comment #40) > > > I think the only thing we try to fix here is the infinite recurssion. > > > > and code madnness :) > > why? the reason for the bug was crashes with a change to atk, so just fixing > the way we interact with atk should be fine. the

[Desktop-packages] [Bug 948788]

2013-03-21 Thread Trevor Saunders
(In reply to alexander :surkov from comment #39) > (In reply to Trevor Saunders (:tbsaunde) from comment #38) > > (In reply to alexander :surkov from comment #37) > > > atk_object_set_name() called inside get_name is a wrong thing we try to > > > > I think the only thing we try to fix here is the

[Desktop-packages] [Bug 948788]

2013-03-20 Thread Alexander Surkov
(In reply to Trevor Saunders (:tbsaunde) from comment #38) > (In reply to alexander :surkov from comment #37) > > atk_object_set_name() called inside get_name is a wrong thing we try to > > I think the only thing we try to fix here is the infinite recurssion. and code madnness :) > > remove here

[Desktop-packages] [Bug 948788]

2013-03-20 Thread Trevor Saunders
(In reply to alexander :surkov from comment #37) > atk_object_set_name() called inside get_name is a wrong thing we try to I think the only thing we try to fix here is the infinite recurssion. > remove here. It made us fire name change events which is ridiculous I think. > If I get right then ATK

[Desktop-packages] [Bug 948788]

2013-03-20 Thread Alexander Surkov
atk_object_set_name() called inside get_name is a wrong thing we try to remove here. It made us fire name change events which is ridiculous I think. If I get right then ATK implementation internals don't need that event as long as we override get_name. On the another hand I don't understand why the

[Desktop-packages] [Bug 948788]

2013-03-20 Thread Trevor Saunders
(In reply to alexander :surkov from comment #35) > (In reply to Trevor Saunders (:tbsaunde) from comment #34) > > Comment on attachment 726580 > > Implement a replacement of atk_object_set_name() which mimics the behavior > > without calling atk_object_get_name() > > > > >+static void > > >+AtkObj

[Desktop-packages] [Bug 948788]

2013-03-20 Thread Alexander Surkov
(In reply to Trevor Saunders (:tbsaunde) from comment #34) > Comment on attachment 726580 > Implement a replacement of atk_object_set_name() which mimics the behavior > without calling atk_object_get_name() > > >+static void > >+AtkObjectSetName(AtkObject *aAtkObj, const gchar *name) > > so, both

[Desktop-packages] [Bug 948788]

2013-03-20 Thread Trevor Saunders
Comment on attachment 726580 Implement a replacement of atk_object_set_name() which mimics the behavior without calling atk_object_get_name() >+static void >+AtkObjectSetName(AtkObject *aAtkObj, const gchar *name) so, both of the times this is called we have to check if we actually want to fire

[Desktop-packages] [Bug 948788]

2013-03-20 Thread Alexander Surkov
Comment on attachment 726580 Implement a replacement of atk_object_set_name() which mimics the behavior without calling atk_object_get_name() Review of attachment 726580: - ::: i/accessible/src/atk/AccessibleWrap.cpp @@ +147,5 @@ >

[Desktop-packages] [Bug 948788]

2013-03-20 Thread Vd-4
Created attachment 726580 Implement a replacement of atk_object_set_name() which mimics the behavior without calling atk_object_get_name() Do not call our replacement setNameCB() and do not register it as a callback by assigning it to AtkObjectClass::set_name. Also use it in the other place where

[Desktop-packages] [Bug 948788] Re: thunderbird crashed on launch

2013-03-16 Thread Bug Watch Updater
** Changed in: firefox Status: Confirmed => In Progress -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/948788 Title: thunderbird crashed on launch Status in The Mozilla Firefo

[Desktop-packages] [Bug 948788]

2013-03-16 Thread Vd-4
Created attachment 725350 Implement setNameCB() in AccessibleWrap.cpp and use it in getNameCB() instead of atk_object_set_name() Beware - I am not very familiar with this code, I may have screwed it up! -- You received this bug notification because you are a member of Desktop Packages, which is

[Desktop-packages] [Bug 948788]

2013-03-16 Thread Trevor Saunders
Comment on attachment 725350 Implement setNameCB() in AccessibleWrap.cpp and use it in getNameCB() instead of atk_object_set_name() >@@ -644,11 +644,40 @@ getNameCB(AtkObject* aAtkObj) > > NS_ConvertUTF8toUTF16 objName(aAtkObj->name); > if (!uniName.Equals(objName)) >-atk_object_set_name

[Desktop-packages] [Bug 948788]

2013-03-16 Thread Vd-4
Hello, First of all, this bug does not exist currently because the following commit was reverted from ATK source: https://git.gnome.org/browse/atk/commit/?id=7ebaa51b17fbca385d9d1f3dd026bd4770852d9b So in order to close this bug, either 1. Leave the code as is and put a comment in ATK source not

[Desktop-packages] [Bug 948788] Re: thunderbird crashed on launch

2012-08-09 Thread Launchpad Bug Tracker
** Branch linked: lp:ubuntu/atk1.0 -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/948788 Title: thunderbird crashed on launch Status in The Mozilla Firefox Browser: Confirmed Statu

[Desktop-packages] [Bug 948788] Re: thunderbird crashed on launch

2012-05-08 Thread Brett Alton
This has been occuring for me since I wiped 10.10 and installed the 12.04 release. Let me know what I need to add to be useful for this bug. sheehan@ubuntu:~$ lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description:Ubuntu 12.04 LTS Release:12.04 Codename:

[Desktop-packages] [Bug 948788]

2012-04-10 Thread Deckerjeffreyr
Just as clarification I need to first write getName and setName and then replace the instances of atk_object_get_name and atk_object_set_name with the new function. Just want to make sure before I get started. Thank you. -- You received this bug notification because you are a member of Desktop P

[Desktop-packages] [Bug 948788]

2012-04-10 Thread Ginn-chen-r
(In reply to JeffreyDecker from comment #27) > Just as clarification I need to first write getName and setName and then > replace the instances of atk_object_get_name and atk_object_set_name with > the new function. Just want to make sure before I get started. > > Thank you. No, I don't think yo

[Desktop-packages] [Bug 948788]

2012-04-06 Thread Trevor Saunders
(In reply to alexander :surkov from comment #25) > (In reply to JeffreyDecker from comment #24) > > I would like to take on this bug if that's alright. > > done, thank you btw. > > > Just reading through the > > comments though it looks like it's a little unclear as to how we want to > > refactor

[Desktop-packages] [Bug 948788]

2012-04-05 Thread Alexander Surkov
(In reply to JeffreyDecker from comment #24) > I would like to take on this bug if that's alright. done, thank you btw. > Just reading through the > comments though it looks like it's a little unclear as to how we want to > refactor to fix the bug. I think go with solution from comment #21. > H

[Desktop-packages] [Bug 948788]

2012-04-05 Thread Deckerjeffreyr
I would like to take on this bug if that's alright. Just reading through the comments though it looks like it's a little unclear as to how we want to refactor to fix the bug. Has there been any decision made? I think this would be an iterating bug to work on as I am still a relative newbie to makin

[Desktop-packages] [Bug 948788]

2012-03-16 Thread Alexander Surkov
(In reply to Trevor Saunders (:tbsaunde) from comment #22) > or we could do what we do for a bunch of other atk methods reutrning const > gchar* nd use nsAccessibleWrap::ReturnString() which keeps a static > nsCString and returns a pointer into its buffer, and so requires caller of > atk method to

[Desktop-packages] [Bug 948788]

2012-03-16 Thread Alexander Surkov
(In reply to Ginn Chen from comment #20) > > > We need to copy the string to gchar* anyway. > > > > yep, just copy the string every time when we were asked. Doesn't sound good? > > Actually it's not possible. > atk_object_get_name() returns const gchar*, caller will not free the return > value.

[Desktop-packages] [Bug 948788]

2012-03-16 Thread Trevor Saunders
(In reply to alexander :surkov from comment #21) > (In reply to Ginn Chen from comment #20) > > > > > We need to copy the string to gchar* anyway. > > > > > > yep, just copy the string every time when we were asked. Doesn't sound > > > good? > > > > Actually it's not possible. > > atk_object_ge

[Desktop-packages] [Bug 948788] Re: thunderbird crashed on launch

2012-03-12 Thread Bug Watch Updater
Launchpad has imported 21 comments from the remote bug at https://bugzilla.mozilla.org/show_bug.cgi?id=733712. If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://he

[Desktop-packages] [Bug 948788] Re: thunderbird crashed on launch

2012-03-08 Thread Matthias Klose
fixed for firefox as mentioned by Xerxes in bug #948788. ** Changed in: firefox (Ubuntu Precise) Status: Confirmed => Fix Released -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/

[Desktop-packages] [Bug 948788] Re: thunderbird crashed on launch

2012-03-07 Thread Alejandro Piñeiro
BTW, a new upstream ATK release was done, reverting this change: https://mail.gnome.org/archives/gnome-accessibility- devel/2012-March/msg4.html Thanks for the testing and for pinging me. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed

[Desktop-packages] [Bug 948788] Re: thunderbird crashed on launch

2012-03-07 Thread JrZabott
Sorry everybody, updated right now, problem solved, YOU ARE GREAT guys... :D -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/948788 Title: thunderbird crashed on launch Status in The

[Desktop-packages] [Bug 948788] Re: thunderbird crashed on launch

2012-03-07 Thread JrZabott
I've tried... sudo apt-get install atk1.0, and it downloaded some libraries, and the problem persists... -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/948788 Title: thunderbird crash

[Desktop-packages] [Bug 948788] Re: thunderbird crashed on launch

2012-03-07 Thread JrZabott
After upgrading every hour, my problem persists, can anyone give a tip? -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/948788 Title: thunderbird crashed on launch Status in The Mozil

[Desktop-packages] [Bug 948788] Re: thunderbird crashed on launch

2012-03-07 Thread Chris Coulson
** Bug watch added: Mozilla Bugzilla #733712 https://bugzilla.mozilla.org/show_bug.cgi?id=733712 ** Also affects: firefox via https://bugzilla.mozilla.org/show_bug.cgi?id=733712 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member of

[Desktop-packages] [Bug 948788] Re: thunderbird crashed on launch

2012-03-07 Thread Launchpad Bug Tracker
This bug was fixed in the package atk1.0 - 2.3.91-0ubuntu2 --- atk1.0 (2.3.91-0ubuntu2) precise; urgency=low * revert_set_name_change.patch: revert upstream change leading to get_name, set_name loops in firefox code (lp: #948788) -- Sebastien BacherWed, 07 Mar 2012 12:34:25

[Desktop-packages] [Bug 948788] Re: thunderbird crashed on launch

2012-03-07 Thread Chris Coulson
** Package changed: thunderbird (Ubuntu Precise) => atk1.0 (Ubuntu Precise) -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/948788 Title: thunderbird crashed on launch Status in “atk1

[Desktop-packages] [Bug 948788] Re: thunderbird crashed on launch

2012-03-07 Thread Launchpad Bug Tracker
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: firefox (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/9487

[Desktop-packages] [Bug 948788] Re: thunderbird crashed on launch

2012-03-07 Thread Chris Coulson
** Also affects: thunderbird (Ubuntu Precise) Importance: Undecided Status: Confirmed ** Changed in: thunderbird (Ubuntu Precise) Importance: Undecided => Critical ** Also affects: firefox (Ubuntu) Importance: Undecided Status: New -- You received this bug notification be

[Desktop-packages] [Bug 948788] Re: thunderbird crashed on launch

2012-03-07 Thread Launchpad Bug Tracker
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: thunderbird (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/b

[Desktop-packages] [Bug 948788] Re: thunderbird crashed on launch

2012-03-07 Thread Nick Barcet
Backtrace enclosed. Could be related to libatk having been updated prior to this. ** Attachment added: "backtrace generated with gdb" https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/948788/+attachment/2828253/+files/gdb-thunderbird.txt -- You received this bug notification becaus

[Desktop-packages] [Bug 948788] Re: thunderbird crashed on launch

2012-03-07 Thread Nick Barcet
-- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/948788 Title: thunderbird crashed on launch Status in “thunderbird” package in Ubuntu: New Bug description: Lauching thunderbir

[Desktop-packages] [Bug 948788] [NEW] thunderbird crashed on launch

2012-03-07 Thread Nick Barcet
Public bug reported: Lauching thunderbird directly results in a core-dump ProblemType: Bug DistroRelease: Ubuntu 12.04 Package: thunderbird 11.0~b4+build1-0ubuntu1 ProcVersionSignature: Ubuntu 3.2.0-18.28-generic 3.2.9 Uname: Linux 3.2.0-18-generic x86_64 AddonCompatCheckDisabled: False AlsaVersi