RE: Use pre-integration-test to start instamo, run tests in integration-test, then stop instamo in post-integration-test?

2013-03-21 Thread Corey Nolet
Would it also help to define the integration tests in a maven profile that hudson runs by default? I just added some tests that use the mini cluster to verify that proper exceptions are being thrown and it slows down the build as well. Sent from my Verizon Wireless 4G LTE Smartphone

Re: Use pre-integration-test to start instamo, run tests in integration-test, then stop instamo in post-integration-test?

2013-03-21 Thread Keith Turner
On Thu, Mar 21, 2013 at 6:31 AM, David Medinets david.medin...@gmail.com wrote: Running org.apache.accumulo.proxy.SimpleTest Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 37.844 sec FAILURE! I am continued to be concerned by this unit test in the proxy module. And a few

RE: Using powermock-api-mockito in tests?

2013-03-21 Thread Dave Marion
Out of curiosity, why do you say that System.getenv() which breaks the tests in AccumuloVFSClassLoaderTest? It's worked fine for a while. What is different now? -- Dave -Original Message- From: dlmar...@comcast.net [mailto:dlmar...@comcast.net] Sent: Thursday, March 21, 2013 5:12 PM

Re: Using powermock-api-mockito in tests?

2013-03-21 Thread David Medinets
The AccumuloVFSClassLoaderTest tests require ACCUMULO_HOME to be defined. It is not defined on my Windows computer. Therefore, the tests failed. I argue that a unit test should be independent of the underlying system otherwise it is some kind of integration or functional test. And in this case,

Re: Using powermock-api-mockito in tests?

2013-03-21 Thread dlmarion
I'm not seeing where. Do you have a stack trace? - Original Message - From: David Medinets david.medin...@gmail.com To: dev@accumulo.apache.org Sent: Thursday, March 21, 2013 9:26:25 PM Subject: Re: Using powermock-api-mockito in tests? The AccumuloVFSClassLoaderTest tests require

Re: Using powermock-api-mockito in tests?

2013-03-21 Thread dlmarion
I do think that the tests that use the MiniDFSCluster (anything that uses AccumuloDFSBase) will fail on Windows. I had to use the following profile in the commons vfs package. Of course the test names will be different here... profile idhdfs/id activation

Re: Using powermock-api-mockito in tests?

2013-03-21 Thread dlmarion
Take a look at my other email on this subject, it might be better to just add the profile that I mentioned and add this to the list of ignored tests for now. I know that there is a ticket for removing ACCUMULO_HOME in all places. - Original Message - From: David Medinets

Re: Using powermock-api-mockito in tests?

2013-03-21 Thread David Medinets
I hate ignoring things. It makes me uneasy. I'm looking at the other tests as well. For example, the AccumuloDFSBase class depends on running /bin/sh to find a umask. No reason that dependency can't be mocked out during testing... If nothing else, this research will form my own set of Accumulo Zen

Re: Using powermock-api-mockito in tests?

2013-03-21 Thread dlmarion
So we are getting into an area where you want to compile the software on a platform that is not supported. If you want to compile on an unsupported platform, then I would suggest just ignoring the tests that won't work on that system. I don't think that this needs to be changed now as Hadoop