Re: Review Request 19546: ACCUMULO-2520 made GC validate data read from !METADATA table

2014-03-21 Thread Sean Busbey
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19546/#review38231 --- Ship it! Ship It! - Sean Busbey On March 21, 2014, 10:34 p.m., k

Re: Review Request 19546: ACCUMULO-2520 made GC validate data read from !METADATA table

2014-03-21 Thread keith
> On March 21, 2014, 10:51 p.m., Sean Busbey wrote: > > test/system/auto/simple/gc.py, lines 87-91 > > > > > > Is it possible for the GC to delete all the files in HDFS under > > ACCUMULO-2520, but still have this veri

Re: Review Request 19546: ACCUMULO-2520 made GC validate data read from !METADATA table

2014-03-21 Thread Sean Busbey
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19546/#review38227 --- src/server/src/main/java/org/apache/accumulo/server/gc/SimpleGarbag

Re: Review Request 19546: ACCUMULO-2520 made GC validate data read from !METADATA table

2014-03-21 Thread keith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19546/ --- (Updated March 21, 2014, 10:34 p.m.) Review request for accumulo. Changes ---

Re: Review Request 19546: ACCUMULO-2520 made GC validate data read from !METADATA table

2014-03-21 Thread Sean Busbey
> On March 21, 2014, 7:46 p.m., Sean Busbey wrote: > > Can you include a functional test that replicates the catastrophic failure > > that prompted ACCUMULO-2520 to verify that this change stops it? > > kturner wrote: > Like a functional test? Changes in the unit test cover this case, but

Re: Review Request 19546: ACCUMULO-2520 made GC validate data read from !METADATA table

2014-03-21 Thread keith
> On March 21, 2014, 7:46 p.m., Sean Busbey wrote: > > Can you include a functional test that replicates the catastrophic failure > > that prompted ACCUMULO-2520 to verify that this change stops it? Like a functional test? Changes in the unit test cover this case, but not in an end to end way

Re: Review Request 19496: ACCUMULO-2487 match Value implementation to javadocs. check for null args.

2014-03-21 Thread keith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19496/#review38177 --- Ship it! Ship It! - kturner On March 20, 2014, 9:32 p.m., Sean B

Re: Review Request 19546: ACCUMULO-2520 made GC validate data read from !METADATA table

2014-03-21 Thread Sean Busbey
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19546/#review38173 --- Can you include a functional test that replicates the catastrophic f

Re: [DISCUSS] clarification of release guide

2014-03-21 Thread Josh Elser
(repeating from IRC) this was also my interpretation. On 3/21/14, 1:03 PM, Keith Turner wrote: I think the intention is 1 24h w/ agitation AND 1 24h w/o agitation On Fri, Mar 21, 2014 at 12:54 PM, Sean Busbey wrote: Hi! Our release guide[1] has some lines that I'd like to clarify. 1

Re: Review Request 19496: ACCUMULO-2487 match Value implementation to javadocs. check for null args.

2014-03-21 Thread Bill Slacum
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19496/#review38175 --- Ship it! We could consider use of one of the many @NotNull annotati

Review Request 19546: ACCUMULO-2520 made GC validate data read from !METADATA table

2014-03-21 Thread keith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19546/ --- Review request for accumulo. Bugs: ACCUMULO-2520 https://issues.apache.org/

Re: [DISCUSS] clarification of release guide

2014-03-21 Thread William Slacum
I agree with Chief Keith. Clarity in the docs would be good. On Fri, Mar 21, 2014 at 1:03 PM, Keith Turner wrote: > I think the intention is 1 24h w/ agitation AND 1 24h w/o agitation > > > > > On Fri, Mar 21, 2014 at 12:54 PM, Sean Busbey >wrote: > > > Hi! > > > > Our release guide[1] has som

Re: [DISCUSS] clarification of release guide

2014-03-21 Thread Keith Turner
I think the intention is 1 24h w/ agitation AND 1 24h w/o agitation On Fri, Mar 21, 2014 at 12:54 PM, Sean Busbey wrote: > Hi! > > Our release guide[1] has some lines that I'd like to clarify. > > >1. Two 24-hour periods of the randomwalk LongClean test with and without >agitation need

[DISCUSS] clarification of release guide

2014-03-21 Thread Sean Busbey
Hi! Our release guide[1] has some lines that I'd like to clarify. 1. Two 24-hour periods of the randomwalk LongClean test with and without agitation need to be run successfully. 2. Two 24-hour periods of continuous ingest with and without agitation need to be validated successfully.

Re: CMS diff: Apache Accumulo Git WIP

2014-03-21 Thread Josh Elser
Committed. Thanks, Al! On 3/20/14, 10:54 PM, Al Krinker wrote: Clone URL (Committers only): https://cms.apache.org/redirect?new=anonymous;action=diff;uri=http://accumulo.apache.org/git.mdtext Al Krinker Index: trunk/content/git.mdtext ===

Re: Review Request 18625: ACCUMULO-2145 Create upgrade test framework

2014-03-21 Thread John McNamee
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18625/ --- (Updated March 21, 2014, 3:15 p.m.) Review request for accumulo. Changes