Re: Review Request 24741: Bug fix for ACCUMULO-1628

2014-08-19 Thread keith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24741/ --- (Updated Aug. 19, 2014, 2:42 p.m.) Review request for accumulo. Changes

Re: Review Request 24741: Bug fix for ACCUMULO-1628

2014-08-19 Thread Josh Elser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24741/#review50973 --- Ship it! Ship It! - Josh Elser On Aug. 19, 2014, 2:42 p.m.,

Review Request 24855: ACCUMULO-1454 design doc

2014-08-19 Thread keith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24855/ --- Review request for accumulo. Bugs: ACCUMULO-1454

Re: Review Request 24855: ACCUMULO-1454 design doc

2014-08-19 Thread keith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24855/ --- (Updated Aug. 19, 2014, 5:50 p.m.) Review request for accumulo. Bugs:

Re: Review Request 24855: ACCUMULO-1454 design doc

2014-08-19 Thread keith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24855/#review50999 --- docs/src/main/asciidoc/design/ACCUMULO-1454-proposal-01.adoc

Re: Review Request 24855: ACCUMULO-1454 design doc

2014-08-19 Thread keith
On Aug. 19, 2014, 5:54 p.m., kturner wrote: docs/src/main/asciidoc/design/ACCUMULO-1454-proposal-01.adoc, line 15 https://reviews.apache.org/r/24855/diff/1/?file=664453#file664453line15 Should also mention live bug fix upgrade use case. For example upgrading from 1.7.0. to 1.7.1

Re: Review Request 24855: ACCUMULO-1454 design doc

2014-08-19 Thread Josh Elser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24855/#review50998 --- docs/src/main/asciidoc/design/ACCUMULO-1454-proposal-01.adoc

Re: Review Request 24855: ACCUMULO-1454 design doc

2014-08-19 Thread keith
On Aug. 19, 2014, 6:21 p.m., Josh Elser wrote: docs/src/main/asciidoc/design/ACCUMULO-1454-proposal-01.adoc, line 20 https://reviews.apache.org/r/24855/diff/1/?file=664453#file664453line20 More specifics on have a new config and run on a different port would be desirable.

Re: Review Request 24855: ACCUMULO-1454 design doc

2014-08-19 Thread Josh Elser
On Aug. 19, 2014, 6:21 p.m., Josh Elser wrote: docs/src/main/asciidoc/design/ACCUMULO-1454-proposal-01.adoc, line 88 https://reviews.apache.org/r/24855/diff/1/?file=664453#file664453line88 If a user is programming to this API, how do they know what tservers are available?

Re: Review Request 24855: ACCUMULO-1454 design doc

2014-08-19 Thread Josh Elser
On Aug. 19, 2014, 6:31 p.m., Josh Elser wrote: One big design concern I have is what gains the final solution would actually have over what is currently possible with Accumulo as it stands. Right now, you can force tablets to migrate by stopping a tserver. This goes back through

Re: Review Request 24855: ACCUMULO-1454 design doc

2014-08-19 Thread keith
On Aug. 19, 2014, 6:31 p.m., Josh Elser wrote: One big design concern I have is what gains the final solution would actually have over what is currently possible with Accumulo as it stands. Right now, you can force tablets to migrate by stopping a tserver. This goes back through

Review Request 24862: Accumulo-3021 Limit size of split rows

2014-08-19 Thread Jenna Huston
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24862/ --- Review request for accumulo. Bugs: Accumulo-3021

Re: Review Request 24855: ACCUMULO-1454 design doc

2014-08-19 Thread keith
On Aug. 19, 2014, 6:31 p.m., Josh Elser wrote: One big design concern I have is what gains the final solution would actually have over what is currently possible with Accumulo as it stands. Right now, you can force tablets to migrate by stopping a tserver. This goes back through

Re: Review Request 24855: ACCUMULO-1454 design doc

2014-08-19 Thread Adam Fuchs
On Tue, Aug 19, 2014 at 4:17 PM, ke...@deenlo.com wrote: ... Eric looked into locality once when running continuous ingest and found that ~50% of tablets had local data.This matches expectations as the default balancer will try to migrate one child after a split. I thought he found it

Re: Review Request 24855: ACCUMULO-1454 design doc

2014-08-19 Thread Josh Elser
On Aug. 19, 2014, 6:31 p.m., Josh Elser wrote: One big design concern I have is what gains the final solution would actually have over what is currently possible with Accumulo as it stands. Right now, you can force tablets to migrate by stopping a tserver. This goes back through

Re: Review Request 24862: Accumulo-3021 Limit size of split rows

2014-08-19 Thread Christopher Tubbs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24862/#review51034 --- core/src/main/java/org/apache/accumulo/core/conf/Property.java

Re: Review Request 24862: Accumulo-3021 Limit size of split rows

2014-08-19 Thread Christopher Tubbs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24862/#review51035 --- This RB says branch 1.6.1-SNAPSHOT, but I think the diff is for

Re: Review Request 24862: Accumulo-3021 Limit size of split rows

2014-08-19 Thread Jenna Huston
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24862/ --- (Updated Aug. 19, 2014, 5:13 p.m.) Review request for accumulo and kturner.

Re: Compaction Code Path(s)

2014-08-19 Thread Christopher
Most of the magic happens in **/Tablet.java. You can see how these are triggered by examining their callers (usually, if not exclusively, **/TabletServer.java). shopt -s globstar # FTW -- Christopher L Tubbs II http://gravatar.com/ctubbsii On Tue, Aug 19, 2014 at 8:58 PM, Joe Stein

Re: Compaction Code Path(s)

2014-08-19 Thread Josh Elser
You're probably better off looking at the master branch for this, too. Eric has done a bit of cleanup lately that makes it easier to follow than 1.5 (and 1.6, I think). On 8/19/14, 9:16 PM, Christopher wrote: Most of the magic happens in **/Tablet.java. You can see how these are triggered by