Re: Review Request 26530: ACCUMULO-1798 Add compaction strategy to user compactions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26530/#review56431 --- Looks pretty good overall. Only major concern is the use of null, th

Re: Review Request 26507: ACCUMULO-3177 Create a per table volume chooser and ACCUMULO-3178 Create example preferred volumes chooser

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26507/#review56419 --- Noticed some extra things that I didn't on Github. I also tried to n

Re: Review Request 26514: ACCUMULO-3181 VolumeChooser usage doesn't always comply with implied API contract

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26514/#review56418 --- I didn't comment on all of the occurrences, but we shouldn't have an

Re: Review Request 26572: ACCUMULO-898

> On Oct. 10, 2014, 8:33 p.m., Eric Newton wrote: > > minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloClusterImpl.java, > > line 269 > > > > > > Why add the IPv4Stack change? Is this relate

Re: Review Request 26572: ACCUMULO-898

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26572/#review56410 --- I'll echo a lot of the stuff Eric already said about preserving some

Re: Review Request 26572: ACCUMULO-898

> On Oct. 10, 2014, 8:33 p.m., Eric Newton wrote: > > minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloClusterImpl.java, > > line 269 > > > > > > Why add the IPv4Stack change? Is this relate

Re: Review Request 26572: ACCUMULO-898

> On Oct. 10, 2014, 8:42 p.m., Eric Newton wrote: > > Missed updating the instructions in > > docs/src/main/resources/distributedTracing.html Also administration.txt in the user manual. Documentation is forthcoming. - Billie --- This