On Nov. 21, 2014, 3:19 a.m., kturner wrote:
test/src/test/java/org/apache/accumulo/test/ConditionalWriterIT.java, line
98
https://reviews.apache.org/r/28214/diff/5/?file=770707#file770707line98
SimpleMacIT [starts one MAC][1] per class. It seems like
AccumuloClusterIT starts
On Nov. 21, 2014, 11:06 p.m., Mike Drob wrote:
core/src/main/java/org/apache/accumulo/core/client/impl/ClientContext.java,
lines 57-64
https://reviews.apache.org/r/28312/diff/1/?file=771856#file771856line57
Is this class meant to be thread-safe? These two methods are
On Nov. 21, 2014, 3:19 a.m., kturner wrote:
test/src/test/java/org/apache/accumulo/test/ConditionalWriterIT.java, line
98
https://reviews.apache.org/r/28214/diff/5/?file=770707#file770707line98
SimpleMacIT [starts one MAC][1] per class. It seems like
AccumuloClusterIT starts
On Nov. 21, 2014, 11:06 p.m., Mike Drob wrote:
core/src/main/java/org/apache/accumulo/core/client/impl/ClientContext.java,
lines 86-91
https://reviews.apache.org/r/28312/diff/1/?file=771856#file771856line86
We could make this a utility method somewhere else. I'd really rather
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28312/#review62775
---
On Nov. 21, 2014, 6:06 p.m., Mike Drob wrote:
core/src/main/java/org/apache/accumulo/core/client/impl/ClientContext.java,
lines 57-64
https://reviews.apache.org/r/28312/diff/1/?file=771856#file771856line57
Is this class meant to be thread-safe? These two methods are
On Nov. 21, 2014, 11:06 p.m., Mike Drob wrote:
core/src/main/java/org/apache/accumulo/core/client/impl/ReplicationOperationsImpl.java,
lines 91-99
https://reviews.apache.org/r/28312/diff/1/?file=771864#file771864line91
Are these doing the same thing? This looks like a big change.
Looks good to me. Another option would be to put multiple links under
one entry. That might be a bit cleaner.
Adam
On Sun, Nov 23, 2014 at 10:15 PM, Josh Elser josh.el...@gmail.com wrote:
+1 publish that sucker. Thanks for updating the site with the new paper.
Drew Farris wrote:
Ok,
On Nov. 24, 2014, 10:45 a.m., Mike Drob wrote:
core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchReaderIterator.java,
line 110
https://reviews.apache.org/r/28312/diff/2/?file=773257#file773257line110
In some places you make the ClientContext argument final,
On Nov. 21, 2014, 6:06 p.m., Mike Drob wrote:
core/src/main/java/org/apache/accumulo/core/client/impl/ReplicationOperationsImpl.java,
lines 91-99
https://reviews.apache.org/r/28312/diff/1/?file=771864#file771864line91
Are these doing the same thing? This looks like a big change.
On Nov. 21, 2014, 6:06 p.m., Mike Drob wrote:
core/src/main/java/org/apache/accumulo/core/client/impl/ClientContext.java,
lines 57-64
https://reviews.apache.org/r/28312/diff/1/?file=771856#file771856line57
Is this class meant to be thread-safe? These two methods are
Did we make a decision on this?
--
Christopher L Tubbs II
http://gravatar.com/ctubbsii
On Sun, Nov 16, 2014 at 11:16 PM, Christopher ctubb...@apache.org wrote:
On Sun, Nov 16, 2014 at 8:21 PM, Josh Elser josh.el...@gmail.com wrote:
Have we already decided to drop Hadoop 1 for 1.7.0? I can't
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21826/
---
(Updated Nov. 24, 2014, 1:26 p.m.)
Review request for accumulo.
Changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15846/
---
(Updated Nov. 24, 2014, 1:31 p.m.)
Review request for accumulo, Adam Fuchs,
I think a little over a week is a fair window and AFAICT we have lazy
consensus to drop it.
-Sean
On Mon, Nov 24, 2014 at 12:07 PM, Christopher ctubb...@apache.org wrote:
Did we make a decision on this?
--
Christopher L Tubbs II
http://gravatar.com/ctubbsii
On Sun, Nov 16, 2014 at
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26572/
---
(Updated Nov. 24, 2014, 1:48 p.m.)
Review request for accumulo.
Changes
Ya -- I've been holding this in my back pocket.
I'll open up an issue on JIRA later today if we don't already have one.
Sean Busbey wrote:
I think a little over a week is a fair window and AFAICT we have lazy
consensus to drop it.
-Sean
On Mon, Nov 24, 2014 at 12:07 PM, Christopher
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27829/
---
(Updated Nov. 24, 2014, 1:53 p.m.)
Review request for accumulo.
Changes
Okay.
--
Christopher L Tubbs II
http://gravatar.com/ctubbsii
On Mon, Nov 24, 2014 at 1:40 PM, Josh Elser josh.el...@gmail.com wrote:
Ya -- I've been holding this in my back pocket.
I'll open up an issue on JIRA later today if we don't already have one.
Sean Busbey wrote:
I think a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27829/
---
(Updated Nov. 24, 2014, 8:15 p.m.)
Review request for accumulo.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27829/
---
(Updated Nov. 24, 2014, 8:33 p.m.)
Review request for accumulo.
Bugs:
On Nov. 24, 2014, 10:45 a.m., Christopher Tubbs wrote:
Got through page 4. In general, I think we need more developer oriented
documentation about when you should be passing a context and when it is
safe to use a raw instance/connector/configuration.
Context replaces the need to pass
On Nov. 19, 2014, 5 p.m., Josh Elser wrote:
test/src/test/java/org/apache/accumulo/test/Accumulo3047IT.java, line 77
https://reviews.apache.org/r/28214/diff/3/?file=769778#file769778line77
This turns out to be a really common pattern that cropped up across the
test code.
On Nov. 21, 2014, 2 a.m., kturner wrote:
minicluster/src/main/java/org/apache/accumulo/cluster/RemoteShell.java,
line 34
https://reviews.apache.org/r/28214/diff/5/?file=770677#file770677line34
Took a quick look at ShellCommandExecutor, its marked unstable and
private to hadoop
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28214/
---
(Updated Nov. 24, 2014, 11:23 p.m.)
Review request for accumulo.
Changes
25 matches
Mail list logo
