Re: Review Request 29176: ACCUMULO-3420 Get Visibility Metrics from PrintInfo

2015-01-08 Thread Jenna Huston
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29176/ --- (Updated Jan. 8, 2015, 9:24 p.m.) Review request for accumulo. Changes --

Re: Review Request 29176: ACCUMULO-3420 Get Visibility Metrics from PrintInfo

2015-01-08 Thread Josh Elser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29176/#review67318 --- Ship it! LGTM -- I'll leave some time for other reviewers to add mo

Re: Review Request 29386: ACCUMULO-2815 Client authentication via Kerberos

2015-01-08 Thread Josh Elser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29386/ --- (Updated Jan. 8, 2015, 11:52 p.m.) Review request for accumulo. Changes -

Re: Review Request 29386: ACCUMULO-2815 Client authentication via Kerberos

2015-01-08 Thread Josh Elser
> On Jan. 5, 2015, 8:46 p.m., Christopher Tubbs wrote: > > server/base/src/main/java/org/apache/accumulo/server/security/handler/KerberosAuthenticator.java, > > lines 68-75 > > > > > > This makes the assumption that th

Re: Review Request 29386: ACCUMULO-2815 Client authentication via Kerberos

2015-01-08 Thread Josh Elser
> On Dec. 30, 2014, 10:46 p.m., Christopher Tubbs wrote: > > server/base/src/main/java/org/apache/accumulo/server/security/handler/KerberosAuthenticator.java, > > line 41 > > > > > > I don't think this should be so tig

Re: Review Request 29386: ACCUMULO-2815 Client authentication via Kerberos

2015-01-08 Thread Josh Elser
> On Dec. 30, 2014, 7:39 p.m., kturner wrote: > > core/src/main/java/org/apache/accumulo/core/client/security/tokens/KerberosToken.java, > > line 46 > > > > > > This is adding UserGroupInformation to Accumulo API. Is

Re: Review Request 29386: ACCUMULO-2815 Client authentication via Kerberos

2015-01-08 Thread Josh Elser
> On Dec. 29, 2014, 4:39 p.m., Josh Elser wrote: > > server/base/src/main/java/org/apache/accumulo/server/AccumuloServerContext.java, > > line 72 > > > > > > Touched on this earlier, the client and server configs are e

Kerberos client auth review getting close

2015-01-08 Thread Josh Elser
For any of you who may have wanted to look at the changes I've been working on to get kerberos authentication throughout all of Accumulo, but might have been dissuaded by the amount of chatter, now is a good time to come back. Things have been stabilized a bit (thanks to a lot of good feedback

Re: Review Request 29502: ACCUMULO-3458 Adding scan authorizations to IteratorEnvironment

2015-01-08 Thread Corey Nolet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29502/ --- (Updated Jan. 9, 2015, 3:11 a.m.) Review request for accumulo, Christopher Tubb