Re: 1.7.0 status

Thanks to everyone helping triage these tickets. Big thanks to Christopher, as well, as he's been knocking a bunch of the trivial ones out. Christopher wrote: +1, my thanks as well. -- Christopher L Tubbs II http://gravatar.com/ctubbsii On Mon, Apr 6, 2015 at 12:34 AM, Sean Busbey wrote:

Re: Review Request 32986: ACCUMULO-3715 Decrease sampling percentage for tracing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32986/#review79472 --- core/src/main/java/org/apache/accumulo/core/conf/Property.java

[GitHub] accumulo pull request: ACCUMULO-3645 Run iterators at major compac...

Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/22#discussion_r28030423 --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java --- @@ -1860,9 +1860,14 @@ private CompactionStats _majorCompact(Maj

[GitHub] accumulo pull request: ACCUMULO-3645 Run iterators at major compac...

Github user denine99 commented on a diff in the pull request: https://github.com/apache/accumulo/pull/22#discussion_r28030298 --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java --- @@ -1860,9 +1860,14 @@ private CompactionStats _majorCompact(Majo

[GitHub] accumulo pull request: ACCUMULO-3645 Run iterators at major compac...

Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/22#discussion_r28030148 --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java --- @@ -1860,9 +1860,14 @@ private CompactionStats _majorCompact(Maj

[GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...

Github user keith-turner commented on the pull request: https://github.com/apache/accumulo/pull/25#issuecomment-91069467 I was discussing the use case I mentioned offline w/ @ctubbsii. This use case was a large number of ranges that can not be generated by a function. We determined

[GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...

Github user joshelser commented on the pull request: https://github.com/apache/accumulo/pull/25#issuecomment-91054685 > isn't that the purpose of a code review Not trying to insinuate there was any ill-will, but this discussion has not been centered around encouragement and ha

[GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...

Github user keith-turner commented on the pull request: https://github.com/apache/accumulo/pull/25#issuecomment-91054546 > Eugene has done a lot of work here as a first contribution. I think the work @echeipesh has done for this is spectacular. I hope my discussion does n

[GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...

Github user ctubbsii commented on the pull request: https://github.com/apache/accumulo/pull/25#issuecomment-91053729 > Gentle reminder that you're looking a gift horse in the mouth with this. Perhaps, but isn't that the purpose of a code review? To my knowledge, nobody has exp

[GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...

Github user joshelser commented on the pull request: https://github.com/apache/accumulo/pull/25#issuecomment-91053066 > then only we only implement it and have less code to maintain. Gentle reminder that you're looking a gift horse in the mouth with this. Eugene has done a lot

[GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...

Github user keith-turner commented on the pull request: https://github.com/apache/accumulo/pull/25#issuecomment-91052076 > That's orthogonal to accepting arbitrary ranges I suppose the worst case for the function approach, would be that the configuration for the function is th

[GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...

Github user wjsl commented on the pull request: https://github.com/apache/accumulo/pull/25#issuecomment-91049930 > True in some cases. I was thinking in many cases that a user provided function could deterministically generate a large number of ranges from a small amount of configurat

[GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...

Github user keith-turner commented on the pull request: https://github.com/apache/accumulo/pull/25#issuecomment-91049787 > How do these changes preclude you from later adding in your proposed split generation code? They do not. I am just thinking about maintenance over time.

[GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...

Github user joshelser commented on the pull request: https://github.com/apache/accumulo/pull/25#issuecomment-91049205 > If its not discussed now, then it will likely not be later. 1.7.0 will be released, and we will be supporting these API changes for a long time How do these

[GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...

Github user keith-turner commented on the pull request: https://github.com/apache/accumulo/pull/25#issuecomment-91047735 > I'm happy to continue the discussion for dealing with large numbers of ranges efficiently, I'm just not convinced this is the place to do it. I think it i

[GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...

Github user keith-turner commented on the pull request: https://github.com/apache/accumulo/pull/25#issuecomment-91046228 > Also, you have to stuff the input information in the Configuration any ways so that the client can create all of the input splits (and thus store them in memory)

[GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...

Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/25#discussion_r28016992 --- Diff: core/src/main/java/org/apache/accumulo/core/client/mapred/AbstractInputFormat.java --- @@ -384,7 +387,21 @@ public static InputTableConfig getI

[GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...

Github user wjsl commented on the pull request: https://github.com/apache/accumulo/pull/25#issuecomment-91043317 > It seems like this change could encourage users to pass many ranges as configuration for the map reduce job. The current InputFormat already does this, so I don't

[GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...

Github user joshelser commented on the pull request: https://github.com/apache/accumulo/pull/25#issuecomment-91041003 > > Agreed, but is this a new issue? > I think the intent of this PR is new. I think the intent is to efficiently support a map reduce job that reads from many

[GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...

Github user ctubbsii commented on the pull request: https://github.com/apache/accumulo/pull/25#issuecomment-91038876 > Agreed, but is this a new issue? I wouldn't think so. I think it highlights a better implementation to satisfy the underlying use case than the one currently

[GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...

Github user keith-turner commented on the pull request: https://github.com/apache/accumulo/pull/25#issuecomment-91038638 > Agreed, but is this a new issue? I think the intent of this PR is new. I think the intent is to efficiently support a map reduce job that reads from many

[GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...

Github user ctubbsii commented on the pull request: https://github.com/apache/accumulo/pull/25#issuecomment-91037784 In JIRA, I [mentioned][1] "sometimes it's better to query a larger range and let an iterator filter out non-matching results". I think the createRanges method @

[GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...

Github user joshelser commented on the pull request: https://github.com/apache/accumulo/pull/25#issuecomment-91035731 > It seems like this change could encourage users to pass many ranges as configuration for the map reduce job. This could cause memory exhaustion for the job tracker.

[GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...

Github user keith-turner commented on the pull request: https://github.com/apache/accumulo/pull/25#issuecomment-91033820 I was discussing the big picture behind this PR w/ @ctubbsii . It seems like this change could encourage users to pass many ranges as configuration for the map re

Re: Scan-time iterators returning out-of-order rows

Thanks Christopher and David. It sounds like the right way to go is to encode the data KV pairs in either the CQ or the Value of the index KV pairs. I can probably make that work. I really just wanted to get an opinion re. whether out-of-order rows was behaviour that would probably be preserved ac

Review Request 32986: ACCUMULO-3715 Decrease sampling percentage for tracing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32986/ --- Review request for accumulo, Eric Newton and Josh Elser. Repository: accumulo

[GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...

Github user keith-turner commented on a diff in the pull request: https://github.com/apache/accumulo/pull/25#discussion_r27989335 --- Diff: core/src/main/java/org/apache/accumulo/core/client/mapred/AbstractInputFormat.java --- @@ -384,7 +387,21 @@ public static InputTableConfig g

[GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...

Github user echeipesh commented on a diff in the pull request: https://github.com/apache/accumulo/pull/25#discussion_r27988729 --- Diff: core/src/main/java/org/apache/accumulo/core/client/mapred/AbstractInputFormat.java --- @@ -384,7 +387,21 @@ public static InputTableConfig getI

[GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...

Github user keith-turner commented on a diff in the pull request: https://github.com/apache/accumulo/pull/25#discussion_r27986006 --- Diff: core/src/main/java/org/apache/accumulo/core/client/mapred/AbstractInputFormat.java --- @@ -384,7 +387,21 @@ public static InputTableConfig g

[GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...

Github user echeipesh commented on a diff in the pull request: https://github.com/apache/accumulo/pull/25#discussion_r27983742 --- Diff: core/src/main/java/org/apache/accumulo/core/client/mapred/AbstractInputFormat.java --- @@ -384,7 +387,21 @@ public static InputTableConfig getI

[GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...

Github user echeipesh commented on a diff in the pull request: https://github.com/apache/accumulo/pull/25#discussion_r27981389 --- Diff: core/src/main/java/org/apache/accumulo/core/client/mapred/AbstractInputFormat.java --- @@ -629,32 +676,37 @@ public float getProgress() throws I

[GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...

Github user keith-turner commented on a diff in the pull request: https://github.com/apache/accumulo/pull/25#discussion_r27979336 --- Diff: core/src/main/java/org/apache/accumulo/core/client/mapred/InputFormatBase.java --- @@ -315,7 +317,11 @@ protected static TabletLocator getTa

[GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...

Github user keith-turner commented on a diff in the pull request: https://github.com/apache/accumulo/pull/25#discussion_r27978633 --- Diff: core/src/main/java/org/apache/accumulo/core/client/mapred/AbstractInputFormat.java --- @@ -397,15 +414,17 @@ public static InputTableConfig

[GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...

Github user keith-turner commented on a diff in the pull request: https://github.com/apache/accumulo/pull/25#discussion_r27976594 --- Diff: test/src/test/java/org/apache/accumulo/test/functional/AccumuloInputFormatIT.java --- @@ -146,6 +146,41 @@ public void testGetSplits() throws

[GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...

Github user keith-turner commented on a diff in the pull request: https://github.com/apache/accumulo/pull/25#discussion_r27976100 --- Diff: test/src/test/java/org/apache/accumulo/test/functional/AccumuloInputFormatIT.java --- @@ -146,6 +146,41 @@ public void testGetSplits() throws

[GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...

Github user keith-turner commented on a diff in the pull request: https://github.com/apache/accumulo/pull/25#discussion_r27974998 --- Diff: core/src/main/java/org/apache/accumulo/core/client/mapred/AbstractInputFormat.java --- @@ -397,15 +414,17 @@ public static InputTableConfig

[GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...

Github user keith-turner commented on a diff in the pull request: https://github.com/apache/accumulo/pull/25#discussion_r27974261 --- Diff: core/src/main/java/org/apache/accumulo/core/client/mapreduce/InputFormatBase.java --- @@ -313,11 +374,34 @@ protected static TabletLocator g

[GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...

Github user keith-turner commented on a diff in the pull request: https://github.com/apache/accumulo/pull/25#discussion_r27974211 --- Diff: core/src/main/java/org/apache/accumulo/core/client/mapreduce/InputFormatBase.java --- @@ -313,11 +374,34 @@ protected static TabletLocator g

[GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...

Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/25#discussion_r27974024 --- Diff: core/src/main/java/org/apache/accumulo/core/client/mapred/InputFormatBase.java --- @@ -315,7 +317,11 @@ protected static TabletLocator getTable

[GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...

Github user keith-turner commented on a diff in the pull request: https://github.com/apache/accumulo/pull/25#discussion_r27973658 --- Diff: core/src/main/java/org/apache/accumulo/core/client/mapred/InputFormatBase.java --- @@ -315,7 +317,11 @@ protected static TabletLocator getTa

[GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...

Github user keith-turner commented on a diff in the pull request: https://github.com/apache/accumulo/pull/25#discussion_r27973707 --- Diff: core/src/main/java/org/apache/accumulo/core/client/mapred/InputFormatBase.java --- @@ -315,7 +317,11 @@ protected static TabletLocator getTa

[GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...

Github user keith-turner commented on a diff in the pull request: https://github.com/apache/accumulo/pull/25#discussion_r27973581 --- Diff: core/src/main/java/org/apache/accumulo/core/client/mapred/InputFormatBase.java --- @@ -315,7 +317,11 @@ protected static TabletLocator getTa