[GitHub] accumulo pull request: ACCUMULO-3714 Replace PropertyFilter

2015-04-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/accumulo/pull/26 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

Re: Review Request 32986: ACCUMULO-3715 Decrease sampling percentage for tracing

2015-04-09 Thread Josh Elser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32986/#review79519 --- Ship it! LGTM core/src/main/java/org/apache/accumulo/core/trace/P

Re: Review Request 32986: ACCUMULO-3715 Decrease sampling percentage for tracing

2015-04-09 Thread Billie Rinaldi
> On April 9, 2015, 3 a.m., Mike Drob wrote: > > core/src/main/java/org/apache/accumulo/core/conf/Property.java, line 385 > > > > > > If this property name changes, should we provide some level of support > > for the

Re: Review Request 32986: ACCUMULO-3715 Decrease sampling percentage for tracing

2015-04-09 Thread Billie Rinaldi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32986/ --- (Updated April 9, 2015, 3:57 p.m.) Review request for accumulo, Eric Newton and

[GitHub] accumulo pull request: ACCUMULO-3602 BatchScanner optimization for...

2015-04-09 Thread keith-turner
Github user keith-turner commented on the pull request: https://github.com/apache/accumulo/pull/25#issuecomment-91240448 Another possible option for supporting a large number of ranges is to add a method called `setRangesFile(conf, hdfsRangesFile)`. A method like this could be added

Re: Review Request 32986: ACCUMULO-3715 Decrease sampling percentage for tracing

2015-04-09 Thread Billie Rinaldi
I am going to experiment with leaving out the sampling and only dropping 0ms spans to see if that is a sufficient solution. Feel free to hold off on further review until I post the results. On Wed, Apr 8, 2015 at 8:00 PM, Mike Drob wrote: > >