It's actually even more annoying than I had previously thought...
individual users can't select which kinds of notifications they'd like to
subscribe to. It's a push model based on the project... rather than
subscription model based on user preferences. With all JIRA's features,
you'd think that us
Okay, so after all that work I did on
https://issues.apache.org/jira/browse/INFRA-11675 , we were able to get the
duplicate messages on the notifications list to stop, which came from
comments on GitHub pull requests which also triggered emails about comments
from JIRA.
However, it now appears tha
Github user joshelser commented on the pull request:
https://github.com/apache/accumulo/pull/100#issuecomment-221162021
Left some nit-picky comments on `KeyShortener`, but overall it looks good.
I assume you didn't see any performance degradation with this change?
:+1:
---
I
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/100#discussion_r64325850
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/rfile/KeyShortener.java ---
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software F
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/100#discussion_r64325773
--- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java
---
@@ -89,6 +90,10 @@ private RFile() {}
static final int RINDEX_VER_8
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/100#discussion_r64325460
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/rfile/KeyShortener.java ---
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software F
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/100#discussion_r64325038
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/rfile/KeyShortener.java ---
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software F
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/100#discussion_r64324981
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/rfile/KeyShortener.java ---
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software F
I'll try to take a look at this one tonight to have another set of eyes
on it.
Keith Turner wrote:
I just opened a PR for ACCUMULO-1124, thats one change I wanted to get in
for 1.8. The other change I would like to get in is ACCUMULO-4165. I will
try my best to get a PR for that in tomorrow.
I just opened a PR for ACCUMULO-1124, thats one change I wanted to get in
for 1.8. The other change I would like to get in is ACCUMULO-4165. I will
try my best to get a PR for that in tomorrow.
https://issues.apache.org/jira/browse/ACCUMULO-1124
https://issues.apache.org/jira/browse/ACCUMULO-416
GitHub user keith-turner opened a pull request:
https://github.com/apache/accumulo/pull/100
ACCUMULO-1124 Shorten keys in index and uses statistics to choose betâ¦
â¦ter keys
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/keith
You can always feel free to move them all out to a 1.9 and people who care
about certain ones can move them back into the release and make them
blockers. Less work for you :)
Thanks for volunteering to be RM!
On May 22, 2016 9:42 PM, "Michael Wall" wrote:
> After last weeks discussion with Josh,
12 matches
Mail list logo