Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/106#discussion_r65483843
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/Compression.java
---
@@ -81,38 +89,60 @@ public void flush() throws IOException
Github user joshelser commented on the issue:
https://github.com/apache/accumulo/pull/103
This looks great, @keith-turner :+1:. Really happy to see a stable API
around RFile, I think this is a great improvement
---
If your project is set up for it, you can reply to this email and
Perhaps. But the tests pass with 2.6.1, I think. Shouldn't be that much
different in terms of support, so I figured go with the minimum we can test
with. FWIW, this affects 1.7.2 also, but i figured a bump there would be
more controversial.
On Wed, Jun 1, 2016, 19:22 Josh Elser
For that reasoning, wouldn't bumping to 2.6.4 be better (as long as
Hadoop didn't do anything screwy that they shouldn't have in a
maintenance release...)
I have not looked at deltas between 2.6.1 and 2.6.4
Christopher wrote:
I was looking at the recently bumped tickets and noticed
Github user keith-turner commented on the issue:
https://github.com/apache/accumulo/pull/103
I am planning on squashing and pushing this in the morning. If anyone
still wants to review or if there is something I didn't address let me know.
Thanks @joshelser and @phrocker for the
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/106#discussion_r65439053
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/Compression.java
---
@@ -244,44 +361,58 @@ public synchronized OutputStream
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/106#discussion_r65435729
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/Compression.java
---
@@ -244,44 +361,58 @@ public synchronized OutputStream
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/106#discussion_r65432443
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/Compression.java
---
@@ -244,44 +361,58 @@ public synchronized OutputStream
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/106#discussion_r65431847
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/Compression.java
---
@@ -244,44 +361,58 @@ public synchronized OutputStream
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/106#discussion_r65431192
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/Compression.java
---
@@ -139,46 +168,82 @@ public synchronized OutputStream
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/106#discussion_r65431073
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/Compression.java
---
@@ -139,46 +168,82 @@ public synchronized OutputStream
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/106#discussion_r65430909
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/Compression.java
---
@@ -81,38 +89,60 @@ public void flush() throws
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/106#discussion_r65430832
--- Diff:
core/src/test/java/org/apache/accumulo/core/file/rfile/bcfile/CompressionTest.java
---
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/106#discussion_r65430644
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/Compression.java
---
@@ -244,44 +361,58 @@ public synchronized OutputStream
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/106#discussion_r65429962
--- Diff:
core/src/test/java/org/apache/accumulo/core/file/rfile/bcfile/CompressionTest.java
---
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/106#discussion_r65429423
--- Diff:
core/src/test/java/org/apache/accumulo/core/file/rfile/bcfile/CompressionTest.java
---
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the
I was looking at the recently bumped tickets and noticed
https://issues.apache.org/jira/browse/ACCUMULO-4150
It seems to me that we may want to make our minimum supported Hadoop
version 2.6.1, at least for the 1.8.0 release.
That's not to say it won't work with other versions... just that it's
Devs-
There's been a few issues with jar sealing that I've run into lately. Some
of which only occurred doing test RC builds. To make these issues more
prominent, I recently made the maven-jar-plugin always do jar sealing, so
we can catch these issues earlier, as part of a pom/build update to use
Github user phrocker commented on the issue:
https://github.com/apache/accumulo/pull/106
Made some change per Keith to avoid synchronization entirely. I initially
didn't notice those two functions causing issues; however, I agree that the
synchronization isn't necessary. Removing it
Github user phrocker commented on the issue:
https://github.com/apache/accumulo/pull/106
@madrob When are you cutting 1.7.2? I'd like to make an additional change
per @keith-turner and get this into 1.7.2, but don't wanna to slow you down.
---
If your project is set up for it, you
20 matches
Mail list logo
