[GitHub] accumulo issue #121: ACCUMULO-4353: Stabilize tablet assignment during trans...

2016-06-30 Thread keith-turner
Github user keith-turner commented on the issue: https://github.com/apache/accumulo/pull/121 > Did you have suggestions for additional tests (manual or automated) that you would like to see? No it sounds like you did the manual testing I would have done. The case where there

[GitHub] accumulo pull request #121: ACCUMULO-4353: Stabilize tablet assignment durin...

2016-06-30 Thread keith-turner
Github user keith-turner commented on a diff in the pull request: https://github.com/apache/accumulo/pull/121#discussion_r69235812 --- Diff: test/src/main/java/org/apache/accumulo/test/master/SuspendedTabletsIT.java --- @@ -0,0 +1,256 @@ +/* + * Licensed to the Apache Softw

[GitHub] accumulo pull request #121: ACCUMULO-4353: Stabilize tablet assignment durin...

2016-06-30 Thread keith-turner
Github user keith-turner commented on a diff in the pull request: https://github.com/apache/accumulo/pull/121#discussion_r69235802 --- Diff: test/src/main/java/org/apache/accumulo/test/master/SuspendedTabletsIT.java --- @@ -0,0 +1,256 @@ +/* + * Licensed to the Apache Softw

Re: [DISCUSS] Proposed binary packaging changes

2016-06-30 Thread Christopher
On Thu, Jun 30, 2016 at 8:13 PM Dylan Hutchison wrote: > Thanks for highlighting Chris. Some thoughts: > > There are steps defined in the README and INSTALL for setting up Accumulo > from the binary distribution. It sounds reasonable to add additional steps > for downloading dependencies into the

Re: [DISCUSS] Proposed binary packaging changes

2016-06-30 Thread Dylan Hutchison
Thanks for highlighting Chris. Some thoughts: There are steps defined in the README and INSTALL for setting up Accumulo from the binary distribution. It sounds reasonable to add additional steps for downloading dependencies into the lib/ folder to these documents, as long as the instructions are c

[GitHub] accumulo pull request #121: ACCUMULO-4353: Stabilize tablet assignment durin...

2016-06-30 Thread keith-turner
Github user keith-turner commented on a diff in the pull request: https://github.com/apache/accumulo/pull/121#discussion_r69229399 --- Diff: core/src/main/java/org/apache/accumulo/core/conf/Property.java --- @@ -543,6 +546,9 @@ TABLE_SAMPLER_OPTS("table.sampler.opt.", null, P

[GitHub] accumulo pull request #121: ACCUMULO-4353: Stabilize tablet assignment durin...

2016-06-30 Thread keith-turner
Github user keith-turner commented on a diff in the pull request: https://github.com/apache/accumulo/pull/121#discussion_r69227868 --- Diff: server/base/src/main/java/org/apache/accumulo/server/master/state/TabletLocationState.java --- @@ -93,6 +95,9 @@ public TServerInstance getS

[DISCUSS] Proposed binary packaging changes

2016-06-30 Thread Christopher
Hi all, I'd like to bring to your attention https://issues.apache.org/jira/browse/ACCUMULO-4356, for discussion. Feel free to comment here or on the issue.

Re: ClientConfiguration doesn't check classpath

2016-06-30 Thread Christopher
On Thu, Jun 30, 2016 at 11:13 AM Mike Drob wrote: > On Wed, Jun 29, 2016 at 5:24 PM, Christopher wrote: > > > To get rid of the warning, don't use ClientConfiguration.loadDefault(). > > Unit tests should be self-contained, and not use the user's environment. > > Instead, use "new ClientConfigura

Re: ClientConfiguration doesn't check classpath

2016-06-30 Thread Mike Drob
On Wed, Jun 29, 2016 at 5:24 PM, Christopher wrote: > To get rid of the warning, don't use ClientConfiguration.loadDefault(). > Unit tests should be self-contained, and not use the user's environment. > Instead, use "new ClientConfiguration()". If you're still getting that > warning, we need to f