[GitHub] accumulo pull request #123: ACCUMULO-4361 Configure ShellServerIT to run wit...

2016-07-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/accumulo/pull/123 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[GitHub] accumulo issue #122: ACCUMULO-1604: added check for negate option in ColumnA...

2016-07-10 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/accumulo/pull/122 Left some nit-picky suggestions, but :+1: from me as-is too. Thanks for the fix! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] accumulo pull request #122: ACCUMULO-1604: added check for negate option in ...

2016-07-10 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/122#discussion_r70193707 --- Diff: core/src/test/java/org/apache/accumulo/core/iterators/user/FilterTest.java --- @@ -208,9 +208,9 @@ public void test2() throws IOException {

[GitHub] accumulo pull request #122: ACCUMULO-1604: added check for negate option in ...

2016-07-10 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/122#discussion_r70193586 --- Diff: core/src/test/java/org/apache/accumulo/core/iterators/user/FilterTest.java --- @@ -234,20 +234,101 @@ public void test2a() throws IOException {