[GitHub] accumulo pull request #135: ACCUMULO-1787: created TwoTierCompactionStrategy...

2016-08-29 Thread keith-turner
Github user keith-turner commented on a diff in the pull request: https://github.com/apache/accumulo/pull/135#discussion_r76695415 --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/compaction/TwoTierCompactionStrategy.java --- @@ -61,6 +64,18 @@ public void verify

[GitHub] accumulo pull request #143: ACCUMULO-4428 Fix state of GC firstSeenDead map

2016-08-29 Thread mjwall
Github user mjwall commented on a diff in the pull request: https://github.com/apache/accumulo/pull/143#discussion_r76694377 --- Diff: server/gc/src/main/java/org/apache/accumulo/gc/GarbageCollectWriteAheadLogs.java --- @@ -80,10 +80,10 @@ public class GarbageCollectWri

[GitHub] accumulo pull request #143: ACCUMULO-4428 Fix state of GC firstSeenDead map

2016-08-29 Thread mjwall
Github user mjwall commented on a diff in the pull request: https://github.com/apache/accumulo/pull/143#discussion_r76693414 --- Diff: server/gc/src/main/java/org/apache/accumulo/gc/GarbageCollectWriteAheadLogs.java --- @@ -80,10 +80,10 @@ public class GarbageCollectWri

[GitHub] accumulo pull request #143: ACCUMULO-4428 Fix state of GC firstSeenDead map

2016-08-29 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/143#discussion_r76692450 --- Diff: server/gc/src/main/java/org/apache/accumulo/gc/GarbageCollectWriteAheadLogs.java --- @@ -80,10 +80,10 @@ public class GarbageCollect

[GitHub] accumulo issue #143: ACCUMULO-4428 Fix state of GC firstSeenDead map

2016-08-29 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/accumulo/pull/143 Thanks for the PR, Adam! > I'm open to other fixes like pulling the GCWAL out of the while (true) loop, but I wasn't sure if things like the return value of isUsingTrash or the FileSyste

[GitHub] accumulo pull request #143: ACCUMULO-4428 Fix state of GC firstSeenDead map

2016-08-29 Thread adamjshook
Github user adamjshook commented on a diff in the pull request: https://github.com/apache/accumulo/pull/143#discussion_r76690207 --- Diff: server/gc/src/main/java/org/apache/accumulo/gc/GarbageCollectWriteAheadLogs.java --- @@ -80,10 +80,10 @@ public class GarbageCollec

[GitHub] accumulo pull request #143: ACCUMULO-4428 Fix state of GC firstSeenDead map

2016-08-29 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/accumulo/pull/143#discussion_r76689634 --- Diff: server/gc/src/main/java/org/apache/accumulo/gc/GarbageCollectWriteAheadLogs.java --- @@ -80,10 +80,10 @@ public class GarbageCollectW

[GitHub] accumulo pull request #143: ACCUMULO-4428 Fix state of GC firstSeenDead map

2016-08-29 Thread adamjshook
GitHub user adamjshook opened a pull request: https://github.com/apache/accumulo/pull/143 ACCUMULO-4428 Fix state of GC firstSeenDead map The GC's map of host->timestamp is used to track when it has first seen a dead tserver, however a new instance of GarbageCollectWriteAheadLogs

Re: BatchWriter Improvements - An end user's perspective

2016-08-29 Thread Keith Turner
On Fri, Aug 26, 2016 at 12:21 PM, Michael Moss wrote: > Hello, Folks. > > As I look at the following tickets, I thought it might be useful to share > how we are using the BatchWriter, some of the challenges we've had, some > thoughts about it's redesign and how we might get involved. > > https://i

Re: 1.8.0 RC3

2016-08-29 Thread Michael Wall
Just to complete this thread, 4428 has been removed from 1.8.1 as the bug is not applicable. There is https://issues.apache.org/jira/browse/ACCUMULO-4333 for testing WAL GC in 1.8. I have created an RC3 and sent out a vote email On Mon, Aug 29, 2016 at 11:40 AM, Josh Elser wrote: > Err, strike

[VOTE] Accumulo 1.8.0-rc3

2016-08-29 Thread Michael Wall
Accumulo Developers, Please consider the following candidate for Accumulo 1.8.0. Git Commit: ad281753325b4d9d593aa02ba11a1041ded5296d Branch: 1.8.0-rc3 If this vote passes, a gpg-signed tag will be created using: git tag -f -m 'Apache Accumulo 1.8.0' -s rel/1.8.0 ad281753325b4d9d593a

Re: 1.8.0 RC3

2016-08-29 Thread Josh Elser
Err, strike that. Just saw https://issues.apache.org/jira/browse/ACCUMULO-4428 I'm pretty sure this is saying that we will never remove WALs for old TServers. We should be looking at this before cutting another release. Josh Elser wrote: +1 Michael Wall wrote: I am working on an RC3 right

Re: 1.8.0 RC3

2016-08-29 Thread Josh Elser
+1 Michael Wall wrote: I am working on an RC3 right now. If anyone thinks this needs to hold the RC, let me know soon. On Mon, Aug 29, 2016 at 11:08 AM, Josh Elser wrote: Timing out is new for me (although, I think Sean might have seen that on a different replication test?) https://issues.

Re: 1.8.0 RC3

2016-08-29 Thread Michael Wall
I am working on an RC3 right now. If anyone thinks this needs to hold the RC, let me know soon. On Mon, Aug 29, 2016 at 11:08 AM, Josh Elser wrote: > Timing out is new for me (although, I think Sean might have seen that on a > different replication test?) > > https://issues.apache.org/jira/brow

Re: 1.8.0 RC3

2016-08-29 Thread Josh Elser
Timing out is new for me (although, I think Sean might have seen that on a different replication test?) https://issues.apache.org/jira/browse/ACCUMULO-4389 is an open issue I need to find time to return to related to replication. If you can capture the minicluster directory and the failsafe-r