[GitHub] accumulo pull request #145: ACCUMULO-4376 add KeyBuilder

2016-09-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/accumulo/pull/145 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[GitHub] accumulo issue #145: ACCUMULO-4376 add KeyBuilder

2016-09-07 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/accumulo/pull/145 > I'll have to wait tomorrow but if you want to do it you are welcome :). Superb. I'm running the tests now, and will hopefully commit tonight. --- If your project is set up for it, you

[GitHub] accumulo pull request #134: ACCUMULO-4391 Source deepcopies cannot be used s...

2016-09-07 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/accumulo/pull/134#discussion_r77917975 --- Diff: core/src/test/java/org/apache/accumulo/core/file/rfile/MultiThreadedRFileTest.java --- @@ -0,0 +1,387 @@ +/* + * Licensed to the Apache

[GitHub] accumulo issue #145: ACCUMULO-4376 add KeyBuilder

2016-09-07 Thread melrief
Github user melrief commented on the issue: https://github.com/apache/accumulo/pull/145 I'll have to wait tomorrow but if you want to do it you are welcome :). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] accumulo issue #145: ACCUMULO-4376 add KeyBuilder

2016-09-07 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/accumulo/pull/145 > Good, done and also change since to 2.0. This looks good. One last thing is the `assertSame()` call. Want to fix that too? I am also ok fixing on that local commit. --- If your projec

[GitHub] accumulo issue #145: ACCUMULO-4376 add KeyBuilder

2016-09-07 Thread melrief
Github user melrief commented on the issue: https://github.com/apache/accumulo/pull/145 I also changed this so that it will be merged in `master` and not in `1.8`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] accumulo issue #145: ACCUMULO-4376 add KeyBuilder

2016-09-07 Thread melrief
Github user melrief commented on the issue: https://github.com/apache/accumulo/pull/145 Good, done and also change since to 2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] accumulo pull request #145: ACCUMULO-4376 add KeyBuilder

2016-09-07 Thread melrief
Github user melrief commented on a diff in the pull request: https://github.com/apache/accumulo/pull/145#discussion_r77915765 --- Diff: core/src/main/java/org/apache/accumulo/core/data/KeyBuilder.java --- @@ -0,0 +1,420 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] accumulo pull request #145: ACCUMULO-4376 add KeyBuilder

2016-09-07 Thread melrief
Github user melrief commented on a diff in the pull request: https://github.com/apache/accumulo/pull/145#discussion_r77915578 --- Diff: core/src/main/java/org/apache/accumulo/core/data/KeyBuilder.java --- @@ -0,0 +1,420 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] accumulo pull request #145: ACCUMULO-4376 add KeyBuilder

2016-09-07 Thread melrief
Github user melrief commented on a diff in the pull request: https://github.com/apache/accumulo/pull/145#discussion_r77915565 --- Diff: core/src/main/java/org/apache/accumulo/core/data/KeyBuilder.java --- @@ -0,0 +1,420 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] accumulo issue #145: ACCUMULO-4376 add KeyBuilder

2016-09-07 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/accumulo/pull/145 Fine by me. I just had the two comments (javadoc cleanup and the unnecessary string->text->bytes conversion). It's all recorded on JIRA for posterity. --- If your project is set up for it, you

[GitHub] accumulo issue #145: ACCUMULO-4376 add KeyBuilder

2016-09-07 Thread melrief
Github user melrief commented on the issue: https://github.com/apache/accumulo/pull/145 I did the rebase and started with the changes but I have to force push it and probably we are going to miss some comments after the push. Are you ok with force pushing the rebase with the changes r

Re: [DISCUSS] Official release dates / DOAP out-of-date

2016-09-07 Thread Christopher
Okay, I've updated the DOAP to match the SVN dist upload date (svn commit timestamp), and added the missing entries. I then manually updated all the entries in JIRA to reflect the same dates, and did a sync on reporter.apache.org (which is still a day-off... waiting for feedback on that from ComDev

Re: [DISCUSS] Release plan 1.6.6

2016-09-07 Thread Josh Elser
Christopher wrote: On Tue, Sep 6, 2016 at 9:08 PM Josh Elser wrote: Christopher wrote: Okay, so now that 1.8.0 is wrapping up, I'd like to push out a release of 1.6.6, and plan to cease active development on that branch. +1 This will allow us to focus our development and bugfixes on the la

[GitHub] accumulo pull request #135: ACCUMULO-1787: created TwoTierCompactionStrategy...

2016-09-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/accumulo/pull/135 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

Re: [DISCUSS] Release plan 1.6.6

2016-09-07 Thread Christopher
On Tue, Sep 6, 2016 at 9:08 PM Josh Elser wrote: > Christopher wrote: > > Okay, so now that 1.8.0 is wrapping up, I'd like to push out a release of > > 1.6.6, and plan to cease active development on that branch. > > +1 > > > This will allow us to focus our development and bugfixes on the latest >

[GitHub] accumulo issue #135: ACCUMULO-1787: created TwoTierCompactionStrategy and it...

2016-09-07 Thread keith-turner
Github user keith-turner commented on the issue: https://github.com/apache/accumulo/pull/135 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[ANNOUNCE] Apache Accumulo 1.8.0 Released

2016-09-07 Thread Michael Wall
The Accumulo team is proud to announce the release of Accumulo version 1.8.0 ! Accumulo 1.8.0 is a minor release that includes over 200 bug fixes, 71 improvements and 4 new features. This release is backwards-compatible with 1.7.x. This version is now available in Maven Central, and at: https://

Re: [DISCUSS] Official release dates / DOAP out-of-date

2016-09-07 Thread Sean Busbey
I agree with Billie that the technically-correct-ASF-policy-date is the SVN dist date. Similar to Josh I don't think this is a place where we need a lot of precision and anything within a week or two is good enough. On Tue, Sep 6, 2016 at 6:36 PM, Christopher wrote: > I noticed that there were a

Re: [DISCUSS] Official release dates / DOAP out-of-date

2016-09-07 Thread Christopher
Okay, SVN dist date is easy enough to check, based on SVN commit timestamps. I'll converge on those. I'm not so concerned about precision as I am about consistency, especially to inform the filling in of the gaps. On Wed, Sep 7, 2016 at 10:49 AM Sean Busbey wrote: > I agree with Billie that the

Re: [DISCUSS] Official release dates / DOAP out-of-date

2016-09-07 Thread Billie Rinaldi
I prefer SVN dist date, but I know that isn't the easiest to come by ... I recall approximating the date on a couple of occasions when i couldn't figure it out readily. Another possibility is to use the archive, https://archive.apache.org/dist/accumulo/, assuming that a release hits the archive on

Re: [VOTE] Accumulo 1.8.0-rc4

2016-09-07 Thread Michael Wall
We are almost ready to make the announcement of the 1.8.0 release. If anyone has a few minutes, please review http://apache.github.io/accumulo/ and especially http://apache.github.io/accumulo/release_notes/1.8.0. I pushed artifacts to dist.apache.org yesterday and the 5 mirrors I checked have a c