If anybody's interested, I also have the non-maven-only artifacts staged at
https://dist.apache.org/repos/dist/dev/accumulo/ (just the tarballs and
sigs/hashes, which will go to dist/release if vote passes). An extra thing
to check would be to ensure that they match byte-for-byte with their
corresp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51933/#review149160
---
core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51933/
---
(Updated Sept. 16, 2016, 1:15 a.m.)
Review request for accumulo, Josh Elser and
+1 (binding)
* Verified changes over 1.6.6-rc1
* Verified repo contains 2073a07460603ebdb2caec3f6b7b863293cbfadb
* `mvn package` && `mvn package -Dhadoop.profile=1` both pass
* xsums/sigs OK
- Josh
Christopher wrote:
Accumulo Developers,
Please consider the following candidate for Accumulo 1.
Github user asfgit closed the pull request at:
https://github.com/apache/accumulo/pull/152
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user joshelser commented on the issue:
https://github.com/apache/accumulo/pull/152
Thanks for the prompt review, Keith. Will go ahead and squash+merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user keith-turner commented on the issue:
https://github.com/apache/accumulo/pull/152
I think this looks good @joshelser
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/152#discussion_r79069134
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/rpc/NotActiveServiceException.java
---
@@ -19,7 +19,7 @@
/**
* An {@link Except
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/152#discussion_r79069091
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/rpc/NotActiveServiceException.java
---
@@ -19,7 +19,7 @@
/**
* An {@link Exc
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/152#discussion_r79067584
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/rpc/NotActiveServiceException.java
---
@@ -19,7 +19,7 @@
/**
* An {@link Exc
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/152#discussion_r79066218
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java
---
@@ -247,10 +252,14 @@ private void executeFateOperation
Accumulo Developers,
Please consider the following candidate for Accumulo 1.6.6.
Git Commit:
2073a07460603ebdb2caec3f6b7b863293cbfadb
Branch:
1.6.6-rc2
If this vote passes, a gpg-signed tag will be created using:
git tag -f -m 'Apache Accumulo 1.6.6' -s rel/1.6.6 \
2073a07460603e
> On Sept. 15, 2016, 8:48 p.m., Josh Elser wrote:
> > A couple of extremely minor things. In general, this looks really great.
Also, checked out your licensing on Caffeine and it doesn't look like we need
to anything else here in Accumulo to add it (yay).
- Josh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51933/#review149122
---
A couple of extremely minor things. In general, this looks really
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51933/
---
Review request for accumulo, Josh Elser and kturner.
Bugs: ACCUMULO-4177
ht
Canceling this vote due to the compilation on Hadoop 1 error. I'll be
creating an rc2 shortly.
On Thu, Sep 15, 2016 at 1:01 PM Josh Elser wrote:
> Switching my vote to -1 given Christopher's finding about Hadoop-1 being
> busted. I forgot to test this.
>
> Josh Elser wrote:
> > +1 (binding)
> >
GitHub user milleruntime opened a pull request:
https://github.com/apache/accumulo/pull/153
ACCUMULO-: added check for null token in ConnectorImpl
Added check to ConnectorImpl constructor to prevent NPE. Included
"password is missing" in the message to make it more helpful for
Switching my vote to -1 given Christopher's finding about Hadoop-1 being
busted. I forgot to test this.
Josh Elser wrote:
+1 (binding)
* xsums/sigs OK
* Observed that bin tarball built with JDK6 (can't verify with jdk6 as I
would have to rebuild hadoop too and I am lazy)
* Built from source
*
-1
:(
CONs:
* won't build with Hadoop 1 profile (Hadoop 1 support wasn't dropped until
1.7)
* kept seeing https://issues.apache.org/jira/browse/ACCUMULO-4457 (not
interested in fixing for 1.6, though)
PROs:
* Checked hashes/sigs
* checked license/notice files
* compared git commit/branch with src
Github user joshelser commented on the issue:
https://github.com/apache/accumulo/pull/152
Ok, turns out I had a bug :). I was able to reproduce this and it does
cause an AccumuloException to be thrown on the client side.
---
If your project is set up for it, you can reply to this ema
Policy-wise, no it's not needed. I did not do any distributed testing,
personally. This certainly wouldn't hurt if you have the cycles/resources.
Michael Wall wrote:
Thanks for the reminder Josh. I have been doing some testing and will vote
before the deadline. Haven't found any issues so far
Thanks for the reminder Josh. I have been doing some testing and will vote
before the deadline. Haven't found any issues so far.
I did not start any CI though. Has anyone else? Is CI needed?
On Thu, Sep 15, 2016 at 12:00 PM, Josh Elser wrote:
> Oops, more like ~25hrs (what are timezones...)
Oops, more like ~25hrs (what are timezones...)
Josh Elser wrote:
The vote closes in ~30hrs from the time I am sending this message.
Let's get this release out there so we can continue to push towards 2.0!
The vote closes in ~30hrs from the time I am sending this message.
Let's get this release out there so we can continue to push towards 2.0!
Github user joshelser commented on the issue:
https://github.com/apache/accumulo/pull/152
> This seems really hard to test. One way I can think to test is to write
some code for a one time test.
:) yeah, something like this is what I was trying to avoid but will
probably have
Github user keith-turner commented on the issue:
https://github.com/apache/accumulo/pull/152
> Sounds like we'd have to make it a TException then?
I don't think this will work. But this assertion is based on a fuzzy
memory of some code in the past doing that and it not worki
Github user keith-turner commented on the issue:
https://github.com/apache/accumulo/pull/152
>The testing I did was unable to force a failure, but I am not convinced if
this is because I didn't figure out how to test it good enough.
This seems really hard to test. One way I ca
Github user joshelser commented on the issue:
https://github.com/apache/accumulo/pull/152
> have you tested this? Does it cause a retry?
So, I tried to test this with via SIGSTOP'ing a client application,
flipping the active master, and then SIGCONT'ing the application and I w
Github user joshelser commented on the issue:
https://github.com/apache/accumulo/pull/152
> Reading the docs, we would have been throwing a RuntimeException anyways
(because the checked exception is not capable of being thrown by our thrift RPC
methods), so java would have wrapped it
Github user keith-turner commented on the issue:
https://github.com/apache/accumulo/pull/152
@joshelser have you tested this? Does it cause a retry? I suspect it will
not cause a retry, but not completely sure. I think the
NotActiveServiceException may cause the client to see a TA
30 matches
Mail list logo
