[GitHub] accumulo pull request #235: ACCUMULO-4612 - Simplify Accumulo memory configu...

2017-03-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/accumulo/pull/235 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] accumulo pull request #235: ACCUMULO-4612 - Simplify Accumulo memory configu...

2017-03-24 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/235#discussion_r107951433 --- Diff: core/src/test/java/org/apache/accumulo/core/conf/AccumuloConfigurationTest.java --- @@ -25,16 +25,17 @@ @Test public void

[GitHub] accumulo pull request #235: ACCUMULO-4612 - Simplify Accumulo memory configu...

2017-03-24 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/235#discussion_r107951460 --- Diff: core/src/test/java/org/apache/accumulo/core/conf/AccumuloConfigurationTest.java --- @@ -49,12 +50,12 @@ public void testGetTimeInMillis() {

[GitHub] accumulo pull request #235: ACCUMULO-4612 - Simplify Accumulo memory configu...

2017-03-24 Thread keith-turner
Github user keith-turner commented on a diff in the pull request: https://github.com/apache/accumulo/pull/235#discussion_r107944635 --- Diff: core/src/test/java/org/apache/accumulo/core/conf/AccumuloConfigurationTest.java --- @@ -49,12 +50,12 @@ public void testGetTimeInMillis()

[GitHub] accumulo pull request #235: ACCUMULO-4612 - Simplify Accumulo memory configu...

2017-03-24 Thread keith-turner
Github user keith-turner commented on a diff in the pull request: https://github.com/apache/accumulo/pull/235#discussion_r107944404 --- Diff: core/src/test/java/org/apache/accumulo/core/conf/AccumuloConfigurationTest.java --- @@ -25,16 +25,17 @@ @Test public

[GitHub] accumulo pull request #235: ACCUMULO-4612 - Simplify Accumulo memory configu...

2017-03-24 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/235#discussion_r107943447 --- Diff: INSTALL.md --- @@ -36,62 +36,49 @@ to manage Accumulo: These scripts will be used in the remaining instructions to configure and run

[GitHub] accumulo pull request #235: ACCUMULO-4612 - Simplify Accumulo memory configu...

2017-03-24 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/235#discussion_r107939700 --- Diff: INSTALL.md --- @@ -36,62 +36,49 @@ to manage Accumulo: These scripts will be used in the remaining instructions to configure and run

[GitHub] accumulo issue #235: ACCUMULO-4612 - Simplify Accumulo memory configuration

2017-03-24 Thread mikewalch
Github user mikewalch commented on the issue: https://github.com/apache/accumulo/pull/235 I would like to merge today if there are no objections. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] accumulo pull request #235: ACCUMULO-4612 - Simplify Accumulo memory configu...

2017-03-24 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/235#discussion_r107920669 --- Diff: assemble/bin/accumulo --- @@ -80,9 +65,6 @@ function main() { JAVA=($ACCUMULO_JAVA_PREFIX $JAVA) --- End diff -- I am ok