Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/236#discussion_r108553471
--- Diff:
start/src/main/java/org/apache/accumulo/start/classloader/AccumuloClassLoader.java
---
@@ -44,21 +44,21 @@
public class
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/236#discussion_r108550201
--- Diff:
start/src/main/java/org/apache/accumulo/start/classloader/AccumuloClassLoader.java
---
@@ -44,21 +44,21 @@
public class
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/236#discussion_r108544154
--- Diff:
start/src/main/java/org/apache/accumulo/start/classloader/AccumuloClassLoader.java
---
@@ -44,21 +44,21 @@
public class
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/236#discussion_r108543513
--- Diff:
start/src/main/java/org/apache/accumulo/start/classloader/AccumuloClassLoader.java
---
@@ -44,21 +44,21 @@
public class
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/236#discussion_r108535021
--- Diff:
start/src/main/java/org/apache/accumulo/start/classloader/AccumuloClassLoader.java
---
@@ -44,21 +44,21 @@
public class
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/236#discussion_r108534597
--- Diff:
start/src/main/java/org/apache/accumulo/start/classloader/AccumuloClassLoader.java
---
@@ -44,21 +44,21 @@
public class
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/236#discussion_r108533118
--- Diff:
start/src/main/java/org/apache/accumulo/start/classloader/AccumuloClassLoader.java
---
@@ -44,21 +44,21 @@
public class
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/236#discussion_r108531362
--- Diff:
start/src/main/java/org/apache/accumulo/start/classloader/AccumuloClassLoader.java
---
@@ -44,21 +44,21 @@
public class
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/236#discussion_r108527201
--- Diff:
start/src/main/java/org/apache/accumulo/start/classloader/AccumuloClassLoader.java
---
@@ -44,21 +44,21 @@
public class
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/236#discussion_r108526740
--- Diff:
start/src/main/java/org/apache/accumulo/start/classloader/AccumuloClassLoader.java
---
@@ -44,21 +44,21 @@
public class
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r108522828
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/ColumnFamilyCounter.java
---
@@ -89,4 +89,11 @@ public Value getTopValue() {
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/236#discussion_r108520921
--- Diff:
start/src/main/java/org/apache/accumulo/start/classloader/AccumuloClassLoader.java
---
@@ -44,21 +44,21 @@
public class
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/236#discussion_r108517849
--- Diff:
start/src/main/java/org/apache/accumulo/start/classloader/AccumuloClassLoader.java
---
@@ -44,21 +44,21 @@
public class
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/236#discussion_r108493580
--- Diff:
start/src/main/java/org/apache/accumulo/start/classloader/AccumuloClassLoader.java
---
@@ -44,21 +44,21 @@
public class
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/236#discussion_r108492848
--- Diff:
start/src/main/java/org/apache/accumulo/start/classloader/AccumuloClassLoader.java
---
@@ -44,21 +44,21 @@
public class
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/236#discussion_r108488065
--- Diff:
start/src/main/java/org/apache/accumulo/start/classloader/AccumuloClassLoader.java
---
@@ -44,21 +44,21 @@
public class
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/236#discussion_r108484735
--- Diff:
start/src/main/java/org/apache/accumulo/start/classloader/AccumuloClassLoader.java
---
@@ -44,21 +44,21 @@
public class
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/236#discussion_r108482950
--- Diff:
start/src/main/java/org/apache/accumulo/start/classloader/AccumuloClassLoader.java
---
@@ -44,21 +44,21 @@
public class
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r108479204
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/SortedKeyValueIterator.java
---
@@ -147,4 +147,21 @@
* if not
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/236#discussion_r108476988
--- Diff:
start/src/main/java/org/apache/accumulo/start/classloader/AccumuloClassLoader.java
---
@@ -44,21 +44,21 @@
public class
Github user joshelser commented on the issue:
https://github.com/apache/accumulo/pull/159
> > we decided to narrow the scope of the close implementation to only be
for User Iterators
>How are "user iterators" going to be defined?
Ping on this one as I think it got
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r108475855
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/SortedKeyValueIterator.java
---
@@ -147,4 +147,21 @@
* if not
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r108473678
--- Diff:
core/src/test/java/org/apache/accumulo/core/iterators/system/ColumnFamilySkippingIteratorTest.java
---
@@ -236,4 +237,45 @@ public void
GitHub user mikewalch opened a pull request:
https://github.com/apache/accumulo/pull/236
ACCUMULO-4614 AccumuloClassLoader should load accumulo-site.xml from â¦
â¦classpath
* Removed use of ACCUMULO_CONF_DIR env variable
* Updated accumulo command to no longer require
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r108471232
--- Diff:
core/src/test/java/org/apache/accumulo/core/iterators/system/ColumnFamilySkippingIteratorTest.java
---
@@ -236,4 +237,45 @@ public void
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r108464160
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java ---
@@ -163,22 +163,22 @@ private static Path
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r108463656
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/ColumnFamilyCounter.java
---
@@ -89,4 +89,11 @@ public Value getTopValue() {
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r108463479
--- Diff:
server/tserver/src/test/java/org/apache/accumulo/tserver/tablet/CompactorTest.java
---
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r108462721
--- Diff: docs/src/main/asciidoc/chapters/iterator_design.txt ---
@@ -182,6 +182,12 @@ early programming assignments which implement their
own tree data
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r108461701
--- Diff:
core/src/test/java/org/apache/accumulo/core/iterators/system/ColumnFamilySkippingIteratorTest.java
---
@@ -236,4 +237,45 @@ public void
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/159
Added entry to the Iterator design section of the user manual in 752c12e
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user joshelser commented on the issue:
https://github.com/apache/accumulo/pull/159
> If all goes well I will merge these changes soon.
I don't see any doc-related changes included...
---
If your project is set up for it, you can reply to this email and have your
32 matches
Mail list logo
