Github user ctubbsii commented on the issue:
https://github.com/apache/accumulo/pull/250
@joshelser That's not what I said at all. I didn't say I don't intend to
tell users how to use it. I said that I think I sufficiently *did* explain how
to use it.
I don't know what more y
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/244#discussion_r112592302
--- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java
---
@@ -746,50 +746,45 @@ public boolean hasTop() {
@Override
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/244#discussion_r112592181
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/ServerFilter.java ---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Fo
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/244#discussion_r112592112
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/ServerWrappingIterator.java
---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/244#discussion_r112591981
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/system/VisibilityFilter.java
---
@@ -16,63 +16,59 @@
*/
package org.apache.ac
Github user joshelser commented on the issue:
https://github.com/apache/accumulo/pull/250
> even if we did have a section in the user manual covering these
non-public modular API components in detail.
So we're adding support/features for things for the benefit of user
customi
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/244#discussion_r112580134
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/WrappingIterator.java ---
@@ -58,21 +58,21 @@ protected void
setSource(SortedKeyValue
Github user scubafuchs commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/244#discussion_r112574461
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/WrappingIterator.java ---
@@ -58,21 +58,21 @@ protected void
setSource(SortedKeyValueIt
Github user lstav commented on the issue:
https://github.com/apache/accumulo/pull/242
Gotcha, thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user ctubbsii commented on the issue:
https://github.com/apache/accumulo/pull/242
@lstav Sorry, not yet. I have the tests [running here][1], but have been
working on other tasks.
[1]: https://jenkins.revelc.net/job/Accumulo-monitor/
---
If your project is set up for i
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/244#discussion_r112568290
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/WrappingIterator.java ---
@@ -58,21 +58,21 @@ protected void
setSource(SortedKeyValue
Github user scubafuchs commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/244#discussion_r112561404
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/WrappingIterator.java ---
@@ -58,21 +58,21 @@ protected void
setSource(SortedKeyValueIt
Github user scubafuchs commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/244#discussion_r112560708
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/ServerSkippingIterator.java
---
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache
Github user lstav commented on the issue:
https://github.com/apache/accumulo/pull/242
@ctubbsii any updates on the ITs and on the merge for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user asfgit closed the pull request at:
https://github.com/apache/accumulo/pull/252
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/244#discussion_r112554325
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/ServerWrappingIterator.java
---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apac
Github user ctubbsii commented on the issue:
https://github.com/apache/accumulo/pull/252
I'm just going to merge this. It's pretty trivial internals-only change
that is relatively small. No review in 24+ hours and I need it for follow-on
changes. Can make updates if folks review later
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/244#discussion_r112552488
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/ServerSkippingIterator.java
---
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apac
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/244#discussion_r112552372
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/WrappingIterator.java ---
@@ -58,21 +58,21 @@ protected void
setSource(SortedKeyValue
Github user milleruntime commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/244#discussion_r112547894
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/ServerWrappingIterator.java
---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apac
Github user scubafuchs commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/244#discussion_r112535692
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/system/VisibilityFilter.java
---
@@ -16,63 +16,59 @@
*/
package org.apache.a
Github user scubafuchs commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/244#discussion_r112533546
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/ServerWrappingIterator.java
---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache
Github user scubafuchs commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/244#discussion_r112533329
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/ServerWrappingIterator.java
---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache
Github user scubafuchs commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/244#discussion_r112532252
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/ServerSkippingIterator.java
---
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache
Github user scubafuchs commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/244#discussion_r112532047
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/ServerWrappingIterator.java
---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache
Github user scubafuchs commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/244#discussion_r112530307
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/ServerFilter.java ---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software F
Github user scubafuchs commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/244#discussion_r112529455
--- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java
---
@@ -746,50 +746,45 @@ public boolean hasTop() {
@Override
Github user ctubbsii commented on the issue:
https://github.com/apache/accumulo/pull/252
This PR contains ACCUMULO-4085 also.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/244
Added performance benchmarks for my Ubuntu Laptop:
[testresults.txt](https://github.com/apache/accumulo/files/945068/testresults.txt)
---
If your project is set up for it, you can reply
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/244
> I'm quite astounded that the benchmarks showed these changes are faster
than previous (notably, the SynchronizedFilter).
It is possible some of the changes are not improvements and t
Github user ctubbsii commented on the issue:
https://github.com/apache/accumulo/pull/252
Rebased this. It's pretty trivial internal improvements, but another set of
eyes on it would be helpful just to make sure it doesn't do anything stupid.
---
If your project is set up for it, you
Github user ctubbsii commented on the issue:
https://github.com/apache/accumulo/pull/250
If you can think of something which will add value, by all means, I will
support you... I just don't think anything else that I could say about it would
be a valuable addition to the user manual.
Github user ctubbsii commented on the issue:
https://github.com/apache/accumulo/pull/250
I cannot think of anything to add the user-manual which would add any value
to what's already there. I think the user-manual is already too wordy, and
repeating the same information in multiple pl
Github user joshelser commented on the issue:
https://github.com/apache/accumulo/pull/250
> I didn't feel it needed a whole separate paragraph beyond that.
Wasn't suggesting its own paragraph, but I assume we have mention of
instructions/descriptions around the aforementioned
Github user ctubbsii commented on the issue:
https://github.com/apache/accumulo/pull/250
@joshelser The property's own documentation is included in the user-manual
appendix for properties. I didn't feel it needed a whole separate paragraph
beyond that.
---
If your project is set up
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/244#discussion_r112506233
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/ServerFilter.java ---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Fo
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/244#discussion_r112504148
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/ServerFilter.java ---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/244#discussion_r112503133
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/ServerFilter.java ---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Fo
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/244#discussion_r112502766
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/ServerFilter.java ---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software
Github user joshelser commented on the issue:
https://github.com/apache/accumulo/pull/244
> @scubafuchs Would you be able to provide feedback to Josh about your
original changes?
Sorry, I didn't realize these were copy-paste of Adam's old changes. Let me
go re-read history.
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/244#discussion_r112501639
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/ServerFilter.java ---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Fo
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/244#discussion_r112501284
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/ServerFilter.java ---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/244
@scubafuchs Would you be able to provide feedback to Josh about your
original changes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user joshelser commented on the issue:
https://github.com/apache/accumulo/pull/250
@ctubbsii no user-manual update?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user asfgit closed the pull request at:
https://github.com/apache/accumulo/pull/250
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/244#discussion_r112495202
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/ServerWrappingIterator.java
---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/244#discussion_r112494213
--- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java
---
@@ -746,50 +746,45 @@ public boolean hasTop() {
@Override
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/244#discussion_r112495854
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/ServerSkippingIterator.java
---
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/244#discussion_r112496258
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/system/VisibilityFilter.java
---
@@ -16,63 +16,59 @@
*/
package org.apache.ac
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/244#discussion_r112494944
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/ServerWrappingIterator.java
---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/244#discussion_r112495020
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/ServerWrappingIterator.java
---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/244#discussion_r112494665
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/ServerSkippingIterator.java
---
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/244#discussion_r112494632
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/ServerFilter.java ---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Fo
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/244
Aside from discussion of benchmark tests in Accumulo, any more input about
the actual code changes? I am currently running the tests again on my Ubuntu
laptop to get a set of Linux system com
54 matches
Mail list logo
