[GitHub] accumulo pull request #258: fixes ACCUMULO-4634 : Appropriately implement th...

2017-05-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/accumulo/pull/258 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[GitHub] accumulo issue #258: fixes ACCUMULO-4634 : Appropriately implement the mocke...

2017-05-15 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/accumulo/pull/258 > Will try to commit later today. I am also expanding the `*` import and squashing the commits together. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] accumulo issue #258: fixes ACCUMULO-4634 : Appropriately implement the mocke...

2017-05-15 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/accumulo/pull/258 Thanks for the revisions, @ivakegg! Will try to commit later today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] accumulo issue #258: fixes ACCUMULO-4634 : Appropriately implement the mocke...

2017-05-15 Thread ivakegg
Github user ivakegg commented on the issue: https://github.com/apache/accumulo/pull/258 tests added --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if t

[GitHub] accumulo issue #258: fixes ACCUMULO-4634 : Appropriately implement the mocke...

2017-05-15 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/accumulo/pull/258 bq. I will see what I can do to force the MockAccumulo through that path Oh, I don't think you need to do anything so high-level. Just instantiate the MockIteratorEnvironment and add test

[GitHub] accumulo issue #258: fixes ACCUMULO-4634 : Appropriately implement the mocke...

2017-05-15 Thread ivakegg
Github user ivakegg commented on the issue: https://github.com/apache/accumulo/pull/258 I will see what I can do to force the MockAccumulo through that path. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] accumulo issue #258: fixes ACCUMULO-4634 : Appropriately implement the mocke...

2017-05-15 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/accumulo/pull/258 LGTM -- nice to see the semantics clear on IteratorEnvironment. Any interest in adding a unit test? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] accumulo pull request #258: fixes ACCUMULO-4634 : Appropriately implement th...

2017-05-15 Thread ivakegg
GitHub user ivakegg opened a pull request: https://github.com/apache/accumulo/pull/258 fixes ACCUMULO-4634 : Appropriately implement the mocked out methods … …per the interface specifications. You can merge this pull request into a Git repository by running: $ git pull http