[GitHub] accumulo issue #260: ACCUMULO-4643 initial implementation

2017-05-25 Thread ivakegg
Github user ivakegg commented on the issue: https://github.com/apache/accumulo/pull/260 I shall rebase and rewrite the message. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] accumulo pull request #260: ACCUMULO-4643 initial implementation

2017-05-25 Thread ivakegg
Github user ivakegg commented on a diff in the pull request: https://github.com/apache/accumulo/pull/260#discussion_r118574720 --- Diff: test/src/main/java/org/apache/accumulo/test/YieldScannersIT.java --- @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] accumulo pull request #260: ACCUMULO-4643 initial implementation

2017-05-25 Thread ivakegg
Github user ivakegg commented on a diff in the pull request: https://github.com/apache/accumulo/pull/260#discussion_r118574368 --- Diff: test/src/main/java/org/apache/accumulo/test/YieldScannersIT.java --- @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] accumulo pull request #260: ACCUMULO-4643 initial implementation

2017-05-25 Thread ivakegg
Github user ivakegg commented on a diff in the pull request: https://github.com/apache/accumulo/pull/260#discussion_r118574263 --- Diff: core/src/main/java/org/apache/accumulo/core/iterators/user/ScanYieldException.java --- @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache S

[GitHub] accumulo pull request #260: ACCUMULO-4643 initial implementation

2017-05-25 Thread ivakegg
Github user ivakegg commented on a diff in the pull request: https://github.com/apache/accumulo/pull/260#discussion_r118574189 --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java --- @@ -548,11 +549,13 @@ private LookupResult lookup(SortedKeyValue

[GitHub] accumulo issue #260: ACCUMULO-4643 initial implementation

2017-05-25 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/accumulo/pull/260 I recommend improving the log message before this gets merged. "initial implementation" doesn't quite explain what it does. The message has a reference to a JIRA, but a brief description within th

[GitHub] accumulo pull request #260: ACCUMULO-4643 initial implementation

2017-05-25 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/260#discussion_r118569076 --- Diff: test/src/main/java/org/apache/accumulo/test/YieldScannersIT.java --- @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] accumulo pull request #260: ACCUMULO-4643 initial implementation

2017-05-25 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/260#discussion_r118568742 --- Diff: test/src/main/java/org/apache/accumulo/test/YieldScannersIT.java --- @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] accumulo pull request #260: ACCUMULO-4643 initial implementation

2017-05-25 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/260#discussion_r118567242 --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java --- @@ -548,11 +549,13 @@ private LookupResult lookup(SortedKeyVal

[GitHub] accumulo pull request #260: ACCUMULO-4643 initial implementation

2017-05-25 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/260#discussion_r118568041 --- Diff: test/src/main/java/org/apache/accumulo/test/YieldScannersIT.java --- @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] accumulo pull request #260: ACCUMULO-4643 initial implementation

2017-05-25 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/260#discussion_r118567373 --- Diff: core/src/main/java/org/apache/accumulo/core/iterators/user/ScanYieldException.java --- @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache

[GitHub] accumulo issue #260: ACCUMULO-4643 initial implementation

2017-05-25 Thread ivakegg
Github user ivakegg commented on the issue: https://github.com/apache/accumulo/pull/260 still working the test cases, but this code should show you the idea --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] accumulo pull request #260: ACCUMULO-4643 initial implementation

2017-05-25 Thread ivakegg
GitHub user ivakegg opened a pull request: https://github.com/apache/accumulo/pull/260 ACCUMULO-4643 initial implementation You can merge this pull request into a Git repository by running: $ git pull https://github.com/ivakegg/accumulo ACCUMULO-4643 Alternatively you can rev

[GitHub] accumulo issue #253: ACCUMULO-4086 Improve volume chooser fallback

2017-05-25 Thread ivakegg
Github user ivakegg commented on the issue: https://github.com/apache/accumulo/pull/253 As it turns out the VolumeChooserForNonTableScopeIT is no longer a valid test. It is explicitly configuring to use the PreferredVolumeChooser but is not setting the volumes leaving the system badl