[GitHub] accumulo pull request #279: ACCUMULO-3238 Table.ID Namespace.ID Refactor

2017-07-12 Thread milleruntime
Github user milleruntime commented on a diff in the pull request: https://github.com/apache/accumulo/pull/279#discussion_r127068208 --- Diff: server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java --- @@ -70,15 +70,15 @@ public abstract

[GitHub] accumulo pull request #279: ACCUMULO-3238 Table.ID Namespace.ID Refactor

2017-07-12 Thread milleruntime
Github user milleruntime commented on a diff in the pull request: https://github.com/apache/accumulo/pull/279#discussion_r127068016 --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/Table.java --- @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] accumulo pull request #279: ACCUMULO-3238 Table.ID Namespace.ID Refactor

2017-07-12 Thread milleruntime
Github user milleruntime commented on a diff in the pull request: https://github.com/apache/accumulo/pull/279#discussion_r127067656 --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/Table.java --- @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] accumulo pull request #279: ACCUMULO-3238 Table.ID Namespace.ID Refactor

2017-07-12 Thread milleruntime
Github user milleruntime commented on a diff in the pull request: https://github.com/apache/accumulo/pull/279#discussion_r127058627 --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/Namespace.java --- @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software

[GitHub] accumulo pull request #279: ACCUMULO-3238 Table.ID Namespace.ID Refactor

2017-07-12 Thread mikewalch
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/accumulo/pull/279#discussion_r127045543 --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/AbstractId.java --- @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] accumulo pull request #275: ACCUMULO-4667 Reworked the LocalityGroupIterator...

2017-07-12 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/275#discussion_r127019394 --- Diff: core/src/main/java/org/apache/accumulo/core/util/LocalityGroupUtil.java --- @@ -50,16 +52,16 @@ // private static final Logger log

[GitHub] accumulo pull request #275: ACCUMULO-4667 Reworked the LocalityGroupIterator...

2017-07-12 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/275#discussion_r127017065 --- Diff: core/src/main/java/org/apache/accumulo/core/iterators/system/LocalityGroupIterator.java --- @@ -16,23 +16,28 @@ */ package org.apac

[GitHub] accumulo pull request #275: ACCUMULO-4667 Reworked the LocalityGroupIterator...

2017-07-12 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/275#discussion_r127019184 --- Diff: core/src/main/java/org/apache/accumulo/core/iterators/system/LocalityGroupIterator.java --- @@ -97,75 +134,122 @@ public static final int seek

[GitHub] accumulo pull request #275: ACCUMULO-4667 Reworked the LocalityGroupIterator...

2017-07-12 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/275#discussion_r127019587 --- Diff: core/src/main/java/org/apache/accumulo/core/util/LocalityGroupUtil.java --- @@ -50,16 +52,16 @@ // private static final Logger log

[GitHub] accumulo pull request #275: ACCUMULO-4667 Reworked the LocalityGroupIterator...

2017-07-12 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/275#discussion_r127018155 --- Diff: core/src/main/java/org/apache/accumulo/core/iterators/system/LocalityGroupIterator.java --- @@ -97,75 +134,122 @@ public static final int seek

[GitHub] accumulo pull request #275: ACCUMULO-4667 Reworked the LocalityGroupIterator...

2017-07-12 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/275#discussion_r127017527 --- Diff: core/src/main/java/org/apache/accumulo/core/iterators/system/LocalityGroupIterator.java --- @@ -65,23 +70,55 @@ public InterruptibleIterator g