Github user joshelser commented on the issue:
https://github.com/apache/accumulo/pull/286
> >there is no obligation of review before commit.
> Right, that's why I was wondering why you bothered with the PR.
Personal preference. If someone wants to make time to revi
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/286
> there is no obligation of review before commit.
Right, that's why I was wondering why you bothered with the PR.
I see your comments on JIRA, thanks.
---
If your project i
Github user joshelser commented on the issue:
https://github.com/apache/accumulo/pull/286
Read the JIRA issue, please. And, for the record, there is no obligation of
review before commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user milleruntime commented on the issue:
https://github.com/apache/accumulo/pull/286
Just curious but why open a PR for only a few hours? Even if the change is
minor, seems like hardly enough time for review.
---
If your project is set up for it, you can reply to this email
GitHub user joshelser opened a pull request:
https://github.com/apache/accumulo/pull/287
ACCUMULO-4688 Turn off autocomplete for the ShellServlet's form passwâ¦
â¦ord field
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joshels
Github user joshelser closed the pull request at:
https://github.com/apache/accumulo/pull/286
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user joshelser opened a pull request:
https://github.com/apache/accumulo/pull/286
ACCUMULO-4689 Do not set empty SSL store types
Setting an empty type will override Jetty's implicit default value
of JKS (which is most likely what Accumulo users would use).
You can merge t
Github user joshelser commented on the issue:
https://github.com/apache/accumulo/pull/285
> Should we apply to previous branches, or just master? Is this biting you
in previous release lines?
I'd put it everywhere. What I'll do sometimes when I have to build upstream
componen
Github user ctubbsii commented on the issue:
https://github.com/apache/accumulo/pull/285
@joshelser Should we apply to previous branches, or just master? Is this
biting you in previous release lines?
---
If your project is set up for it, you can reply to this email and have your
repl
Github user joshelser commented on the issue:
https://github.com/apache/accumulo/pull/285
+1 on the change, this one just bit me the other day.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user glitch commented on the issue:
https://github.com/apache/accumulo/pull/285
Updated & rebased PR based on feedback from @ctubbsii
Local build passing using: mvn verify -Psunny
---
If your project is set up for it, you can reply to this email and have your
reply appea
Github user glitch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/285#discussion_r130347391
--- Diff: core/src/main/java/org/apache/accumulo/core/util/Version.java ---
@@ -53,74 +56,13 @@ public void execute(final String[] args) throws
Exception {
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/285#discussion_r130346697
--- Diff: core/src/main/java/org/apache/accumulo/core/util/Version.java ---
@@ -53,74 +56,13 @@ public void execute(final String[] args) throws
Exception
Github user glitch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/285#discussion_r130338251
--- Diff: core/src/main/java/org/apache/accumulo/core/util/Version.java ---
@@ -53,74 +56,13 @@ public void execute(final String[] args) throws
Exception {
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/285#discussion_r130330269
--- Diff: core/src/main/java/org/apache/accumulo/core/util/Version.java ---
@@ -53,74 +56,13 @@ public void execute(final String[] args) throws
Exception
15 matches
Mail list logo
