[GitHub] accumulo pull request #292: ACCUMULO-4681 Created Table & Namespace WeakRefe...

2017-08-14 Thread milleruntime
Github user milleruntime commented on a diff in the pull request: https://github.com/apache/accumulo/pull/292#discussion_r132972878 --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/Table.java --- @@ -16,24 +16,59 @@ */ package org.apache.accumulo.core.cl

[GitHub] accumulo pull request #292: ACCUMULO-4681 Created Table & Namespace WeakRefe...

2017-08-14 Thread milleruntime
Github user milleruntime commented on a diff in the pull request: https://github.com/apache/accumulo/pull/292#discussion_r132999867 --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/Table.java --- @@ -16,24 +16,59 @@ */ package org.apache.accumulo.core.cl

[GitHub] accumulo pull request #292: ACCUMULO-4681 Created Table & Namespace WeakRefe...

2017-08-14 Thread milleruntime
Github user milleruntime commented on a diff in the pull request: https://github.com/apache/accumulo/pull/292#discussion_r133002408 --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/Table.java --- @@ -16,24 +16,59 @@ */ package org.apache.accumulo.core.cl

[GitHub] accumulo pull request #292: ACCUMULO-4681 Created Table & Namespace WeakRefe...

2017-08-14 Thread milleruntime
Github user milleruntime commented on a diff in the pull request: https://github.com/apache/accumulo/pull/292#discussion_r133002554 --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/Table.java --- @@ -16,24 +16,59 @@ */ package org.apache.accumulo.core.cl

[GitHub] accumulo pull request #292: ACCUMULO-4681 Created Table & Namespace WeakRefe...

2017-08-14 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/292#discussion_r133059580 --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/Table.java --- @@ -16,24 +16,59 @@ */ package org.apache.accumulo.core.client

[GitHub] accumulo pull request #292: ACCUMULO-4681 Created Table & Namespace WeakRefe...

2017-08-14 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/292#discussion_r133068592 --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/Table.java --- @@ -16,24 +16,59 @@ */ package org.apache.accumulo.core.client

[GitHub] accumulo pull request #292: ACCUMULO-4681 Created Table & Namespace WeakRefe...

2017-08-14 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/292#discussion_r133070150 --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/Table.java --- @@ -16,24 +16,59 @@ */ package org.apache.accumulo.core.client

[GitHub] accumulo issue #292: ACCUMULO-4681 Created Table & Namespace WeakReference m...

2017-08-14 Thread ctubbsii
Github user ctubbsii commented on the issue: https://github.com/apache/accumulo/pull/292 This whole thing might be easier to implement with [`CacheBuilder.weakValues()`][1] from Guava. Eviction seems to occur if value disappears. I **think** this will do what we want, and it should au

[GitHub] accumulo pull request #291: ACCUMULO-4693: Add instance-specific ProcessName...

2017-08-14 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/291#discussion_r133086237 --- Diff: server/base/src/main/java/org/apache/accumulo/server/metrics/MetricsSystemHelper.java --- @@ -16,20 +16,65 @@ */ package org.apache.

[GitHub] accumulo pull request #291: ACCUMULO-4693: Add instance-specific ProcessName...

2017-08-14 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/291#discussion_r133086488 --- Diff: server/base/src/main/java/org/apache/accumulo/server/metrics/MetricsSystemHelper.java --- @@ -16,20 +16,65 @@ */ package org.apache.

[GitHub] accumulo pull request #291: ACCUMULO-4693: Add instance-specific ProcessName...

2017-08-14 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/accumulo/pull/291#discussion_r133086736 --- Diff: server/base/src/main/java/org/apache/accumulo/server/metrics/MetricsSystemHelper.java --- @@ -16,20 +16,65 @@ */ package org.apache.