Github user adamjshook commented on the issue:
https://github.com/apache/accumulo/pull/254
Alright, updated again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user adamjshook commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/254#discussion_r114607540
--- Diff:
server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java
---
@@ -161,7 +164,16 @@ public void
Github user adamjshook commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/254#discussion_r114605401
--- Diff:
server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java
---
@@ -161,7 +164,16 @@ public void
Github user adamjshook commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/254#discussion_r114604832
--- Diff:
server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java
---
@@ -161,7 +164,16 @@ public void
Github user adamjshook commented on the issue:
https://github.com/apache/accumulo/pull/254
@joshelser @keith-turner Updated using the new method. Let me know if
setting that config property isn't the best way to do it. Tested it on my pair
of VMs and the client timeout is thr
Github user adamjshook commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/254#discussion_r114594466
--- Diff:
server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java
---
@@ -536,8 +570,21 @@ public
Github user adamjshook commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/254#discussion_r114592878
--- Diff:
server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java
---
@@ -536,8 +570,21 @@ public
Github user adamjshook commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/254#discussion_r114576956
--- Diff:
server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java
---
@@ -536,8 +570,21 @@ public
Github user adamjshook commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/254#discussion_r114575625
--- Diff:
server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java
---
@@ -362,6 +400,7 @@ protected Status
Github user adamjshook commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/254#discussion_r114575478
--- Diff:
server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java
---
@@ -536,8 +570,21 @@ public
Github user adamjshook commented on the issue:
https://github.com/apache/accumulo/pull/254
Any chance this could be reviewed today? I'd like to get it blessed before
applying it on my end to address our production issue. Thank you!
---
If your project is set up for it, yo
Github user adamjshook commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/254#discussion_r114392548
--- Diff:
server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java
---
@@ -416,6 +444,12 @@ protected Status
Github user adamjshook commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/254#discussion_r114387702
--- Diff:
server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java
---
@@ -416,6 +444,12 @@ protected Status
Github user adamjshook commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/254#discussion_r114381575
--- Diff:
server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java
---
@@ -416,6 +444,12 @@ protected Status
Github user adamjshook commented on the issue:
https://github.com/apache/accumulo/pull/254
@joshelser Back at you. I think I managed to scrape together a test that I
am happy with.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user adamjshook commented on the issue:
https://github.com/apache/accumulo/pull/254
I've been reading up on `Executors#sameThreadExecutor`, and I don't think
we can use this here since it runs the task prior to getting any `Future`. The
timeout logic would not kic
Github user adamjshook commented on the issue:
https://github.com/apache/accumulo/pull/254
Thanks for the pointers. I'll head down this route and get back to you
soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user adamjshook commented on the issue:
https://github.com/apache/accumulo/pull/254
@joshelser I think so. I was taking a look at `AccumuloReplicaSystemTest`
and seeing how I could fit something in to try and trigger the timeout, but the
`replicate` call takes in the
Github user adamjshook commented on the issue:
https://github.com/apache/accumulo/pull/254
@joshelser Applied your feedback to the commit. I'll have to run it
through my test later, though -- away from my PC at the moment.
---
If your project is set up for it, you can reply to
Github user adamjshook commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/254#discussion_r113839773
--- Diff:
server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java
---
@@ -288,15 +295,36 @@ public String
Github user adamjshook commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/254#discussion_r113839731
--- Diff:
server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java
---
@@ -288,15 +295,36 @@ public String
Github user adamjshook commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/254#discussion_r113839682
--- Diff:
server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java
---
@@ -288,15 +295,36 @@ public String
Github user adamjshook commented on the issue:
https://github.com/apache/accumulo/pull/254
Not too sure how to go about adding a unit or integration test for this
timeout. I tested the timeout by launching two clusters and replicating data
with a short timeout. Replication was
GitHub user adamjshook opened a pull request:
https://github.com/apache/accumulo/pull/254
[ACCUMULO-4506] Add a timeout to the replication task
This addresses an issue where a replication task will get stuck for a
substantial amount of time. Adding a timeout will abandon the
Github user adamjshook commented on the issue:
https://github.com/apache/accumulo/pull/193
Thank you @dlmarion @joshelser! Appreciate it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user adamjshook commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/193#discussion_r94484914
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/master/balancer/HostRegexTableLoadBalancer.java
---
@@ -254,7 +255,7 @@ public int
Github user adamjshook commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/193#discussion_r94477792
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/master/balancer/HostRegexTableLoadBalancer.java
---
@@ -254,7 +255,7 @@ public int
Github user adamjshook commented on the issue:
https://github.com/apache/accumulo/pull/193
Not too urgent; it can wait another week or two before I'd want to proceed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user adamjshook commented on the issue:
https://github.com/apache/accumulo/pull/193
@dlmarion Any thoughts on getting this merged? I'd like to get this
blessed before applying it on our end.
---
If your project is set up for it, you can reply to this email and have
GitHub user adamjshook opened a pull request:
https://github.com/apache/accumulo/pull/193
[ACCUMULO-4535] Fix NPE in HostRegexTableLoadBalancer
An addition to this would be to remove
`TabletLoader#init(ServerConfiguration)` entirely. Would prevent future
errors, but may break
GitHub user adamjshook opened a pull request:
https://github.com/apache/accumulo/pull/167
[ACCUMULO-4499] Add Accumulo Connector for Presto documentation
Added a blurb for the Accumulo connector for Presto to projects.md
You can merge this pull request into a Git repository by
Github user adamjshook commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/143#discussion_r77057952
--- Diff:
test/src/test/java/org/apache/accumulo/test/functional/GarbageCollectorIT.java
---
@@ -139,6 +150,52 @@ public void gcTest() throws Exception
Github user adamjshook commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/143#discussion_r77055366
--- Diff:
test/src/test/java/org/apache/accumulo/test/functional/GarbageCollectorIT.java
---
@@ -139,6 +150,52 @@ public void gcTest() throws Exception
Github user adamjshook commented on the issue:
https://github.com/apache/accumulo/pull/143
@joshelser Added `final` to the map in `SimpleGarbageCollector`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user adamjshook commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/143#discussion_r77035374
--- Diff:
server/gc/src/main/java/org/apache/accumulo/gc/SimpleGarbageCollector.java ---
@@ -530,6 +531,9 @@ private void run
Github user adamjshook commented on the issue:
https://github.com/apache/accumulo/pull/143
@joshelser Took @keith-turner's approach and am now passing the state into
the GCWAL constructor. Managed to get an integration test case together with
the references you and @mjwall pro
Github user adamjshook commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/143#discussion_r76690207
--- Diff:
server/gc/src/main/java/org/apache/accumulo/gc/GarbageCollectWriteAheadLogs.java
---
@@ -80,10 +80,10 @@
public class
GitHub user adamjshook opened a pull request:
https://github.com/apache/accumulo/pull/143
ACCUMULO-4428 Fix state of GC firstSeenDead map
The GC's map of host->timestamp is used to track when it has first seen
a dead tserver, however a new ins
38 matches
Mail list logo
