Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/270#discussion_r123073391
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java
---
@@ -894,12 +895,19 @@ public static void
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/270#discussion_r123071638
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java
---
@@ -894,12 +894,19 @@ public static void
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/270#discussion_r123046678
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java
---
@@ -894,12 +894,19 @@ public static void
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/270#discussion_r123030301
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java
---
@@ -894,12 +894,19 @@ public static void
Github user phrocker commented on the issue:
https://github.com/apache/accumulo/pull/269
@matthpeterson I tend to agree with other commenters. In my opinion you may
want to add options to support showing all levels, lowest level, or an
arbitrary level of the index tree. I&#x
Github user phrocker commented on the issue:
https://github.com/apache/accumulo/pull/260
@ivakegg Yields are not aware of other yields and thus are completely
independent and thus cannot cooperate with any scheduling mechanism. My old
Operating System book calls this "uncooper
Github user phrocker commented on the issue:
https://github.com/apache/accumulo/pull/260
Have you addressed Josh's concern about RPC calls? Further if you profile
the context switching involved with the threads migrating is the net benefit
better than stopping the scan entirel
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/260#discussion_r119114193
--- Diff:
test/src/main/java/org/apache/accumulo/test/functional/YieldingIterator.java ---
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/260#discussion_r119114135
--- Diff:
test/src/main/java/org/apache/accumulo/test/functional/YieldingIterator.java ---
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/244#discussion_r112706307
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/system/VisibilityFilter.java
---
@@ -16,63 +16,59 @@
*/
package
Github user phrocker commented on the issue:
https://github.com/apache/accumulo/pull/250
@ctubbsii I see. It seems that ACCUMULO-4085 is a specific issue that can
be addressed with HDFS features. My comment was directed to the openness of
this. You're suggesting the need for thi
Github user phrocker commented on the issue:
https://github.com/apache/accumulo/pull/140
This one fell off of my radar. will be posting an update today some time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/247#discussion_r111037441
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/OrIterator.java ---
@@ -80,59 +128,103 @@ public int compareTo(TermSource o
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/247#discussion_r111037495
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/OrIterator.java ---
@@ -80,59 +128,103 @@ public int compareTo(TermSource o
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/247#discussion_r111038914
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/OrIterator.java ---
@@ -80,59 +128,103 @@ public int compareTo(TermSource o
Github user phrocker commented on the issue:
https://github.com/apache/accumulo/pull/241
@milleruntime Shouldn't a discussion of this nature come with profiler
output instead of making changes based on a ticket that's full of "Feels?"
---
If your project is se
Github user phrocker commented on the issue:
https://github.com/apache/accumulo/pull/237
@keith-turner I'll admit I'm still trying to wrap my head around the why.
I'm trying to reverse engineer it to figure out if there's something I'm
missing...
---
If y
Github user phrocker commented on the issue:
https://github.com/apache/accumulo/pull/237
@keith-turner I agree it seems to break the SKVI contract by trying to make
some optimization that likely isn't of great benefit.
---
If your project is set up for it, you can reply to
Github user phrocker commented on the issue:
https://github.com/apache/accumulo/pull/237
@keith-turner it remove sources that don't match the term or don't have any
values. Thus removing it from the TermSources. This seems reasonable based on
dealing with a source as a term
Github user phrocker closed the pull request at:
https://github.com/apache/accumulo/pull/199
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user phrocker commented on the issue:
https://github.com/apache/accumulo/pull/199
@keith-turner please have at it. After some initial tests I felt this
wasn't an arbitrary feature, but by all means have fun with it.
---
If your project is set up for it, you can rep
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/229#discussion_r104833952
--- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java
---
@@ -1015,14 +1018,23 @@ public void init(SortedKeyValueIterator
source
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/229#discussion_r104804673
--- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java
---
@@ -1015,14 +1018,23 @@ public void init(SortedKeyValueIterator
source
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/229#discussion_r104804870
--- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java
---
@@ -1015,14 +1018,23 @@ public void init(SortedKeyValueIterator
source
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/204#discussion_r97362683
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java
---
@@ -1209,6 +1209,15 @@ public void online(String tableName
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/204#discussion_r97363650
--- Diff:
test/src/test/java/org/apache/accumulo/test/functional/TableChangeStateIT.java
---
@@ -0,0 +1,549 @@
+/*
+ * Licensed to the Apache
Github user phrocker commented on the issue:
https://github.com/apache/accumulo/pull/201
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user phrocker commented on the issue:
https://github.com/apache/accumulo/pull/199
@dlmarion Some of these things aren't well defined in Property.java yet as
I was worried about going in a direction and it being all wrong. I take your
comment as a 'feature request&#x
Github user phrocker commented on the issue:
https://github.com/apache/accumulo/pull/199
Oh and tests will fail. Again, just a thought provoking PR. I like the idea
of submitting a PR to get ideas and if someone has ideas pointing to code this
is a great way for them to point it out
GitHub user phrocker opened a pull request:
https://github.com/apache/accumulo/pull/199
DO NOT MERGE: PROOF OF CONCEPT
Hello this is a proof of concept that will hopefully begin the discussion
of changing how we request resources.
First of all there are a lot of changes
Github user phrocker commented on the issue:
https://github.com/apache/accumulo/pull/182
Looks giggity giggity good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/161#discussion_r82305029
--- Diff:
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanDataSource.java
---
@@ -74,32 +74,26 @@
ScanDataSource(Tablet
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/134#discussion_r78074999
--- Diff:
core/src/test/java/org/apache/accumulo/core/file/rfile/MultiThreadedRFileTest.java
---
@@ -0,0 +1,387 @@
+/*
+ * Licensed to the Apache
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/134#discussion_r78048496
--- Diff:
core/src/test/java/org/apache/accumulo/core/file/rfile/MultiThreadedRFileTest.java
---
@@ -0,0 +1,387 @@
+/*
+ * Licensed to the Apache
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/134#discussion_r78042091
--- Diff:
core/src/test/java/org/apache/accumulo/core/file/rfile/MultiThreadedRFileTest.java
---
@@ -0,0 +1,387 @@
+/*
+ * Licensed to the Apache
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/134#discussion_r77917975
--- Diff:
core/src/test/java/org/apache/accumulo/core/file/rfile/MultiThreadedRFileTest.java
---
@@ -0,0 +1,387 @@
+/*
+ * Licensed to the Apache
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/140#discussion_r77165531
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/Compression.java
---
@@ -497,69 +513,66 @@ public CompressionCodec load(Entry
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/140#discussion_r77162956
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/Compression.java
---
@@ -497,69 +513,66 @@ public CompressionCodec load(Entry
Github user phrocker commented on the issue:
https://github.com/apache/accumulo/pull/143
Nice. Good catch. Looks good to me too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/140#discussion_r76883729
--- Diff: core/src/main/java/org/apache/accumulo/core/conf/Property.java ---
@@ -349,7 +349,18 @@
"Memory to provide to batchwriter to r
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/140#discussion_r76880451
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/Compression.java
---
@@ -497,69 +513,66 @@ public CompressionCodec load(Entry
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/140#discussion_r76880275
--- Diff: pom.xml ---
@@ -223,6 +223,11 @@
1.1.1
+commons-pool
+commons-pool
+1.6
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/143#discussion_r76689634
--- Diff:
server/gc/src/main/java/org/apache/accumulo/gc/GarbageCollectWriteAheadLogs.java
---
@@ -80,10 +80,10 @@
public class
Github user phrocker commented on the issue:
https://github.com/apache/accumulo/pull/140
I didn't build the java doc. there are errors. I'm going to correct and
re-submit. In the mean time please send along any comments.
---
If your project is set up for it, you can rep
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/140#discussion_r75718866
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/codec/CompressionUpdater.java
---
@@ -0,0 +1,84 @@
+/*
+ * Licensed to
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/140#discussion_r75715837
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/Compression.java
---
@@ -420,7 +439,7 @@ public InputStream
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/140#discussion_r75715696
--- Diff: core/src/main/java/org/apache/accumulo/core/conf/Property.java ---
@@ -349,7 +349,18 @@
"Memory to provide to batchwriter to r
GitHub user phrocker opened a pull request:
https://github.com/apache/accumulo/pull/140
ACCUMULO-4419: Change how compression delegation works
This commit includes A compression pool not based on CodecPool,
a default factory that does no pooling. Changes are also
in place
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/134#discussion_r72662901
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/BoundedRangeFileInputStream.java
---
@@ -62,12 +62,15 @@ public
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/134#discussion_r72543018
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/BoundedRangeFileInputStream.java
---
@@ -62,12 +62,15 @@ public
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/134#discussion_r72483649
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/BoundedRangeFileInputStream.java
---
@@ -62,12 +62,15 @@ public
Github user phrocker commented on the issue:
https://github.com/apache/accumulo/pull/134
What's the ticket number? ACCUMULO-4139 is ExistingMacIT doesn't wait long
enough for ZK locks to disappear
---
If your project is set up for it, you can reply to this email and have
GitHub user phrocker opened a pull request:
https://github.com/apache/accumulo/pull/133
ACCUMULO-4388: Move location to obtain zoo session.
Change the location of obtaining the zoo session. Tests within ZooCacheTest
appeared to cover these changes to ensure it did not break
Github user phrocker commented on the issue:
https://github.com/apache/accumulo/pull/133
Ran locally so it officially gets the "works on my machine". Will attempt
on a larger instance as soon as I can.
---
If your project is set up for it, you can reply to this email and
Github user phrocker commented on the issue:
https://github.com/apache/accumulo/pull/133
Ran mvn clean install -Psunny -Dassembly.tarLongFileMode=posix -DskipITs
per usual. Will await CI to see if any tests demonstrate failure.
---
If your project is set up for it, you can reply to
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/106#discussion_r66066164
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/Compression.java
---
@@ -78,41 +86,90 @@ public void flush() throws IOException
Github user phrocker commented on the issue:
https://github.com/apache/accumulo/pull/106
Would anyone be opposed to me squashing this into a single commit?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/106#discussion_r65571229
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/Compression.java
---
@@ -81,38 +89,60 @@ public void flush() throws IOException
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/106#discussion_r65523717
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/Compression.java
---
@@ -81,38 +89,60 @@ public void flush() throws IOException
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/106#discussion_r65432443
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/Compression.java
---
@@ -244,44 +361,58 @@ public synchronized OutputStream
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/106#discussion_r65431324
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/Compression.java
---
@@ -244,44 +361,58 @@ public synchronized OutputStream
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/106#discussion_r65430832
--- Diff:
core/src/test/java/org/apache/accumulo/core/file/rfile/bcfile/CompressionTest.java
---
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache
Github user phrocker commented on the issue:
https://github.com/apache/accumulo/pull/106
Made some change per Keith to avoid synchronization entirely. I initially
didn't notice those two functions causing issues; however, I agree that the
synchronization isn't necessary. R
Github user phrocker commented on the issue:
https://github.com/apache/accumulo/pull/106
@madrob When are you cutting 1.7.2? I'd like to make an additional change
per @keith-turner and get this into 1.7.2, but don't wanna to slow you down.
---
If your project is set up f
GitHub user phrocker opened a pull request:
https://github.com/apache/accumulo/pull/106
ACCUMULO-4153: Update the getCodec method to no longer be synchronizeâ¦
â¦d using static initializer in enum
Targeting 1.6 as that is the branch we are currently using. I'd rathe
Github user phrocker closed the pull request at:
https://github.com/apache/accumulo/pull/105
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/105#discussion_r65285666
--- Diff:
core/src/test/java/org/apache/accumulo/core/file/rfile/bcfile/CompressionTest.java
---
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/105#discussion_r65283651
--- Diff:
core/src/test/java/org/apache/accumulo/core/file/rfile/bcfile/CompressionTest.java
---
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/105#discussion_r65283105
--- Diff:
core/src/test/java/org/apache/accumulo/core/file/rfile/bcfile/CompressionTest.java
---
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache
Github user phrocker commented on the pull request:
https://github.com/apache/accumulo/pull/105
I left them synchronized because conf is not thread safe. I left that
paradigm the same because it was not a bottleneck in profiling. Creating a conf
per use would have been.
---
If
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/105#discussion_r65255235
--- Diff:
core/src/test/java/org/apache/accumulo/core/file/rfile/bcfile/CompressionTest.java
---
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/105#discussion_r65254781
--- Diff:
core/src/test/java/org/apache/accumulo/core/file/rfile/bcfile/CompressionTest.java
---
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache
GitHub user phrocker opened a pull request:
https://github.com/apache/accumulo/pull/105
ACCUMULO-4153: Update the getCodec method to no longer be synchronizeâ¦
â¦d using static initializer in enum
I forgot about this PR. I made changes and ran them in production. they
Github user phrocker commented on the pull request:
https://github.com/apache/accumulo/pull/103#issuecomment-77916
Josh, aka Josh, sent me a note to take a look. Because Josh, aka Josh,
tended to my chickens while I was away, will take a moment away from tending to
my flock to
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/73#discussion_r54028028
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/Compression.java
---
@@ -147,25 +148,27 @@ public synchronized OutputStream
Github user phrocker closed the pull request at:
https://github.com/apache/accumulo/pull/73
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/73#discussion_r54027165
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/Compression.java
---
@@ -147,25 +148,27 @@ public synchronized OutputStream
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/73#discussion_r5402
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/Compression.java
---
@@ -147,25 +148,27 @@ public synchronized OutputStream
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/73#discussion_r54006645
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/Compression.java
---
@@ -147,25 +148,27 @@ public synchronized OutputStream
GitHub user phrocker opened a pull request:
https://github.com/apache/accumulo/pull/73
ACCUMULO-4153: Update the getCodec method to no longer be synchronizeâ¦
â¦d and to use an atomic reference.
This is based only on JSTACKs across a running system. I've seen
improv
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/62#discussion_r48845580
--- Diff:
test/src/test/java/org/apache/accumulo/test/functional/SessionBlockVerifyIT.java
---
@@ -0,0 +1,181 @@
+/*
+ * Licensed to the Apache
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/60#discussion_r48753512
--- Diff:
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Scanner.java ---
@@ -38,100 +40,126 @@
private ScanDataSource
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/60#discussion_r48753072
--- Diff:
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Scanner.java ---
@@ -38,100 +40,126 @@
private ScanDataSource
GitHub user phrocker opened a pull request:
https://github.com/apache/accumulo/pull/62
ACCUMULO-3509: Make cleanup stateful to minimize blocking
By enabling state ( true/false) within the cleanup method, the change will
avoid blocking
on a scan session being swept. if the
Github user phrocker closed the pull request at:
https://github.com/apache/accumulo/pull/60
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user phrocker commented on the pull request:
https://github.com/apache/accumulo/pull/60#issuecomment-168673706
I'm going to target 1.6.5 so it can be merged up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
GitHub user phrocker opened a pull request:
https://github.com/apache/accumulo/pull/60
ACCUMULO-3509: Allow cleanup state to be kept to avoid blocking tservâ¦
â¦er session sweep
By enabling state ( true/false) from the cleanup method, the change will
avoid blocking
Github user phrocker commented on the pull request:
https://github.com/apache/accumulo/pull/27#issuecomment-92128596
my bad. I meant to push the checkstyle fixes with 5588570, but I didn't get
them all. Obviously I'm not familiar with computering.
---
If your project is
GitHub user phrocker opened a pull request:
https://github.com/apache/accumulo/pull/27
ACCUMULO-3709: Update both output formats. Add unit test based on Mock A...
Update both output formats. Add unit test based on Mock Accumulo that
exercise the mutations rejection exception
You
89 matches
Mail list logo
