[GitHub] accumulo issue #228: ACCUMULO-4596 Improvements to standalone cluster testin...

2017-03-06 Thread mikewalch
Github user mikewalch commented on the issue: https://github.com/apache/accumulo/pull/228 I tested these changes by running `ReadWriteIT` against and a local cluster started by uno. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] accumulo issue #228: ACCUMULO-4596 Improvements to standalone cluster testin...

2017-03-07 Thread mikewalch
Github user mikewalch commented on the issue: https://github.com/apache/accumulo/pull/228 @joshelser, let me know if my changes now work for you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] accumulo issue #228: ACCUMULO-4596 Improvements to standalone cluster testin...

2017-03-08 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/accumulo/pull/228 > let me know if my changes now work for you. Changes look OK to me now. Thanks for backing out those config changes. Have you tested (a subset of) the ITs using a standalone clus

[GitHub] accumulo issue #228: ACCUMULO-4596 Improvements to standalone cluster testin...

2017-03-08 Thread mikewalch
Github user mikewalch commented on the issue: https://github.com/apache/accumulo/pull/228 @joshelser, I pushed another commit 12c260c0135e2c8 that should resolve your concerns. I added changes to the accumulo scripts to support `ACCUMULO_CONF_DIR` for backwards compatibility. I also

[GitHub] accumulo issue #228: ACCUMULO-4596 Improvements to standalone cluster testin...

2017-03-08 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/accumulo/pull/228 > I also added two properties to standalone cluster testing, accumulo.it.cluster.standalone.client.env & accumulo.it.cluster.standalone.server.env, that will allow users to optionally add envir

[GitHub] accumulo issue #228: ACCUMULO-4596 Improvements to standalone cluster testin...

2017-03-08 Thread mikewalch
Github user mikewalch commented on the issue: https://github.com/apache/accumulo/pull/228 > accumulo.it.cluster.standalone.client.env="ACCUMULO_CONF_DIR=/etc/accumulo-client" accumulo.it.cluster.standalone.server.env="ACCUMULO_CONF_DIR=/etc/accumulo-server" Yes that was h

[GitHub] accumulo issue #228: ACCUMULO-4596 Improvements to standalone cluster testin...

2017-03-08 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/accumulo/pull/228 > We could remove accumulo.it.cluster.standalone.server.conf as its no longer being used Wait, I was almost with you. If this is not being used, then your PR is still broken... --- If

[GitHub] accumulo issue #228: ACCUMULO-4596 Improvements to standalone cluster testin...

2017-03-10 Thread mikewalch
Github user mikewalch commented on the issue: https://github.com/apache/accumulo/pull/228 While I removed use of `sudo` and the 'user' property from the standalone IT properties, they can still be set using a new 'client.prefix' and 'server.prefix' which replaces the the 'client.env'

[GitHub] accumulo issue #228: ACCUMULO-4596 Improvements to standalone cluster testin...

2017-03-10 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/accumulo/pull/228 > using a new 'client.prefix' and 'server.prefix' which replaces the the 'client.env' & 'server.env' Maybe 'client.cmd.prefix' and 'server.cmd.prefix' instead? > let me know if y

[GitHub] accumulo issue #228: ACCUMULO-4596 Improvements to standalone cluster testin...

2017-03-10 Thread mikewalch
Github user mikewalch commented on the issue: https://github.com/apache/accumulo/pull/228 > Maybe 'client.cmd.prefix' and 'server.cmd.prefix' instead? I updated the property names in bf9dfb4 --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] accumulo issue #228: ACCUMULO-4596 Improvements to standalone cluster testin...

2017-03-10 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/accumulo/pull/228 Thanks, Mike! Currently running 1.7.3 tests -- those should finish up in the hour at which point I'll run a local test of this PR. --- If your project is set up for it, you can reply to this ema

[GitHub] accumulo issue #228: ACCUMULO-4596 Improvements to standalone cluster testin...

2017-03-10 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/accumulo/pull/228 FYI the following does not work ``` accumulo.it.cluster.standalone.client.prefix="export ACCUMULO_CONF_DIR=/etc/accumulo-client;" accumulo.it.cluster.standalone.server.prefix="sud

[GitHub] accumulo issue #228: ACCUMULO-4596 Improvements to standalone cluster testin...

2017-03-10 Thread mikewalch
Github user mikewalch commented on the issue: https://github.com/apache/accumulo/pull/228 I looked at my properties file again. Actually, I don't use quotes. It looks like below: ``` accumulo.it.cluster.standalone.client.prefix=export ACCUMULO_CONF_DIR=/etc/accumulo-client;

[GitHub] accumulo issue #228: ACCUMULO-4596 Improvements to standalone cluster testin...

2017-03-10 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/accumulo/pull/228 Cool, thanks for clarifying, Mike. I'm also seeing that test still failing. The GC never comes back up, fails with the below. ``` 2017-03-10 16:27:05,828 [start.Main] ERROR:

[GitHub] accumulo issue #228: ACCUMULO-4596 Improvements to standalone cluster testin...

2017-03-10 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/accumulo/pull/228 Same for the tserver in org.apache.accumulo.test.CleanWalIT. Locally, I'm doing: `mvn verify -Dtest=foo -Daccumulo.it.properties=/Users/jelser/standalone.properties -Dcheckstyle.

[GitHub] accumulo issue #228: ACCUMULO-4596 Improvements to standalone cluster testin...

2017-03-10 Thread mikewalch
Github user mikewalch commented on the issue: https://github.com/apache/accumulo/pull/228 @joshelser, I will look into the test failures. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] accumulo issue #228: ACCUMULO-4596 Improvements to standalone cluster testin...

2017-03-13 Thread mikewalch
Github user mikewalch commented on the issue: https://github.com/apache/accumulo/pull/228 I ran more ITs. `BadDeleteMarkersCreatedIT` and `CleanWallIT` worked for me. However, I ran all standalone ITs and several tests timed out (for reference, one was was `SessionBlockVerifyIT`) .

[GitHub] accumulo issue #228: ACCUMULO-4596 Improvements to standalone cluster testin...

2017-03-13 Thread joshelser
Github user joshelser commented on the issue: https://github.com/apache/accumulo/pull/228 > I switched to the master branch and they also timed out there so it's not this PR that is causing the failures That's fine -- I'm not worried about those. We're running most (all?) of