[GitHub] accumulo issue #243: ACCUMULO-4619 fix split hanging on Error

Github user mjwall commented on the issue: https://github.com/apache/accumulo/pull/243 Sweet, thank you sir. On Tue, Apr 18, 2017 at 2:45 PM Keith Turner wrote: > @mjwall I merged this in 8c0f03a >

[GitHub] accumulo issue #243: ACCUMULO-4619 fix split hanging on Error

Github user keith-turner commented on the issue: https://github.com/apache/accumulo/pull/243 @mjwall I merged this in 8c0f03ac2d8e06b220e2882d54914f2034625e15 and forgot to close the PR --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] accumulo issue #243: ACCUMULO-4619 fix split hanging on Error

Github user mjwall commented on the issue: https://github.com/apache/accumulo/pull/243 @keith-turner is this ready or are there still outstanding questions? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] accumulo issue #243: ACCUMULO-4619 fix split hanging on Error

Github user mjwall commented on the issue: https://github.com/apache/accumulo/pull/243 +1 Nice cleanup Keith. I went back to https://issues.apache.org/jira/browse/ACCUMULO-4332 to see if we could do something similar but didn't see anything. --- If your project is set up for

[GitHub] accumulo issue #243: ACCUMULO-4619 fix split hanging on Error

Github user keith-turner commented on the issue: https://github.com/apache/accumulo/pull/243 In 9523996 I wrapped the exceptions instead of throwing an exception from a background thread. I also rethrew error as a wrapped error. --- If your project is set up for it, you can reply

[GitHub] accumulo issue #243: ACCUMULO-4619 fix split hanging on Error

Github user keith-turner commented on the issue: https://github.com/apache/accumulo/pull/243 @joshelser I agree with your comment about `throw (Error) excep`. However I have a general issue with all of the addsplit code that rethrows, it only shows the stack trace for the background

[GitHub] accumulo issue #243: ACCUMULO-4619 fix split hanging on Error

Github user joshelser commented on the issue: https://github.com/apache/accumulo/pull/243 > Do you think I should check the type and rethrow an Error? The more I think about it, I still think there should be: ```java if (excep instanceof Error) { throw (Error

[GitHub] accumulo issue #243: ACCUMULO-4619 fix split hanging on Error

Github user joshelser commented on the issue: https://github.com/apache/accumulo/pull/243 > What I am doing is similar to what a Future would do, except it would wrap the Throwable with an ExecutionException. OK. If that is what a ThreadPool/Executor would do, then I agree wit

[GitHub] accumulo issue #243: ACCUMULO-4619 fix split hanging on Error

Github user keith-turner commented on the issue: https://github.com/apache/accumulo/pull/243 > I'm worried about masking Errors that are unrecoverable by re-throwing them as RTEs. Do you think I should check the type and rethrow an Error? --- If your project is set up for it

[GitHub] accumulo issue #243: ACCUMULO-4619 fix split hanging on Error

Github user keith-turner commented on the issue: https://github.com/apache/accumulo/pull/243 > If we do get an Error, do we want to keep running? What I am doing is similar to what a Future would do, except it would wrap the Throwable with an ExecutionException. This is why I

[GitHub] accumulo issue #243: ACCUMULO-4619 fix split hanging on Error

Github user joshelser commented on the issue: https://github.com/apache/accumulo/pull/243 If we do get an `Error`, do we want to keep running? I know there was at least one place where we tried to bail out if we got an Error. I'm worried about masking Errors that are unrecoverable by

[GitHub] accumulo issue #243: ACCUMULO-4619 fix split hanging on Error

Github user keith-turner commented on the issue: https://github.com/apache/accumulo/pull/243 > Seems reasonable. Any advantage to using an explicit uncaught exception handler longer term? I was thinking about this and did not come to an firm conclusions. I made some